You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/11/24 07:35:57 UTC

[GitHub] [ignite-3] rpuch commented on a change in pull request #467: IGNITE-15971 Fix problems with dynamic configuration

rpuch commented on a change in pull request #467:
URL: https://github.com/apache/ignite-3/pull/467#discussion_r755766465



##########
File path: modules/configuration/src/main/java/org/apache/ignite/internal/configuration/ConfigurationChanger.java
##########
@@ -383,59 +383,68 @@ public SuperRoot superRoot() {
         StorageRoots localRoots = storageRoots;
         
         return CompletableFuture
-                .supplyAsync(() -> {

Review comment:
       Isn't it allowed to improve code readability while reading code? I thought code improvements are always welcome




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org