You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/17 10:10:00 UTC

[GitHub] [flink] JingsongLi commented on a change in pull request #11108: [FLINK-16113][table-planner-blink] ExpressionReducer shouldn't escape the reduced string value

JingsongLi commented on a change in pull request #11108: [FLINK-16113][table-planner-blink] ExpressionReducer shouldn't escape the reduced string value
URL: https://github.com/apache/flink/pull/11108#discussion_r380090326
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/ExpressionReducer.scala
 ##########
 @@ -138,8 +138,8 @@ class ExpressionReducer(
                SqlTypeName.MULTISET =>
             reducedValues.add(unreduced)
           case SqlTypeName.VARCHAR | SqlTypeName.CHAR =>
-            val escapeVarchar = StringEscapeUtils
 
 Review comment:
   This code should consistent with `GenerateUtils.generateLiteral`.
   It is merging error when merged blink to flink.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services