You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/12/25 03:46:22 UTC
[GitHub] [incubator-doris] Skysheepwang opened a new pull request #5148: [Feature] Implementation of histogram metric
Skysheepwang opened a new pull request #5148:
URL: https://github.com/apache/incubator-doris/pull/5148
## Proposed changes
#5146
Add histogram metrics into `util/metrics.h`. The data structure of histogram is implemented in `util/histogram.h`, which could also be used in other situations that in need of histogram. Unit testis added as well.
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [] Documentation Update (if none of the other choices apply)
- [x] Code refactor (Modify the code structure, format the code, etc...)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have create an issue on (Fix #5146), and have described the bug/feature there in detail
- [x] Compiling and unit tests pass locally with my changes
- [x] I have added tests that prove my fix is effective or that my feature works
- [] If this change need a document change, I have updated the document
- [x] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #5148: [Feature] Implementation of histogram metric
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #5148:
URL: https://github.com/apache/incubator-doris/pull/5148
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] acelyc111 commented on a change in pull request #5148: [Feature] Implementation of histogram metric
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on a change in pull request #5148:
URL: https://github.com/apache/incubator-doris/pull/5148#discussion_r548821974
##########
File path: be/src/util/metrics.h
##########
@@ -159,6 +160,35 @@ class CoreLocalCounter : public Metric {
CoreLocalValue<T> _value;
};
+class HistogramMetric : public Metric {
+public:
+ HistogramMetric() { clear(); }
Review comment:
No need to clear() in constructor?
##########
File path: be/src/util/histogram.h
##########
@@ -0,0 +1,113 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include <string>
+#include <vector>
+#include <map>
+#include <atomic>
+
+#include "common/logging.h"
+
+namespace doris {
+
+// Histogram data structure implementation:
Review comment:
These code are almost copied from rocksdb, we have to update LICENSE.txt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Skysheepwang commented on a change in pull request #5148: [Feature] Implementation of histogram metric
Posted by GitBox <gi...@apache.org>.
Skysheepwang commented on a change in pull request #5148:
URL: https://github.com/apache/incubator-doris/pull/5148#discussion_r548828806
##########
File path: be/src/util/metrics.h
##########
@@ -159,6 +160,35 @@ class CoreLocalCounter : public Metric {
CoreLocalValue<T> _value;
};
+class HistogramMetric : public Metric {
+public:
+ HistogramMetric() { clear(); }
Review comment:
Yes, the `_stat.clear()` will be called in `HistogramStat` 's constructor. I will remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org