You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@twill.apache.org by chtyim <gi...@git.apache.org> on 2018/10/01 16:01:11 UTC

[GitHub] twill pull request #71: TWILL-262 YarnUtils#cloneHaNnCredentials uses DFSUti...

Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/twill/pull/71#discussion_r221661448
  
    --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/yarn/YarnUtils.java ---
    @@ -202,6 +223,28 @@ public static void cloneHaNnCredentials(Configuration config) throws IOException
         }
       }
     
    +  /***
    +   * When hadoop_version > 2.8.0, class DFSUtils has no method getHaNnRpcAddresses(Configuration config)
    --- End diff --
    
    This is not a very clear javadoc that describe what this method does (it should have the same javadoc as the `DFSUtil.getHaNnRpcAddresses` method).


---