You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/04/28 09:33:48 UTC
[GitHub] [rocketmq] lwclover opened a new pull request, #4224: Delete repeated calls in MQClientInstance.start
lwclover opened a new pull request, #4224:
URL: https://github.com/apache/rocketmq/pull/4224
fix #4223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lwclover closed pull request #4224: Delete repeated calls in MQClientInstance.start
Posted by GitBox <gi...@apache.org>.
lwclover closed pull request #4224: Delete repeated calls in MQClientInstance.start
URL: https://github.com/apache/rocketmq/pull/4224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lwclover closed pull request #4224: [ISSUE #4223]Delete repeated calls in MQClientInstance.start
Posted by GitBox <gi...@apache.org>.
lwclover closed pull request #4224: [ISSUE #4223]Delete repeated calls in MQClientInstance.start
URL: https://github.com/apache/rocketmq/pull/4224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lwclover closed pull request #4224: [ISSUE #4223]Delete repeated calls in MQClientInstance#start
Posted by GitBox <gi...@apache.org>.
lwclover closed pull request #4224: [ISSUE #4223]Delete repeated calls in MQClientInstance#start
URL: https://github.com/apache/rocketmq/pull/4224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] cserwen commented on a diff in pull request #4224: [ISSUE #4223]Delete repeated calls in MQClientInstance.start
Posted by GitBox <gi...@apache.org>.
cserwen commented on code in PR #4224:
URL: https://github.com/apache/rocketmq/pull/4224#discussion_r861665850
##########
client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java:
##########
@@ -240,8 +240,6 @@ public void start() throws MQClientException {
this.pullMessageService.start();
// Start rebalance service
this.rebalanceService.start();
- // Start push service
- this.defaultMQProducer.getDefaultMQProducerImpl().start(false);
Review Comment:
It will be used to send retry messages if exception happens.
https://github.com/apache/rocketmq/blob/df3f8de4c03a282de052b130ae368ab00faca039/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImpl.java#L512
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lwclover commented on pull request #4224: [ISSUE #4223]Delete repeated calls in MQClientInstance#start
Posted by GitBox <gi...@apache.org>.
lwclover commented on PR #4224:
URL: https://github.com/apache/rocketmq/pull/4224#issuecomment-1113176287
> DefaultMQPushConsumerImpl.java
> It will be used to send retry messages if exception happens.
>
> https://github.com/apache/rocketmq/blob/df3f8de4c03a282de052b130ae368ab00faca039/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImpl.java#L512
>
> 
It's not like we're talking about the same problem, you can review my code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lwclover closed pull request #4224: [ISSUE #4223]Delete repeated calls in MQClientInstance#start
Posted by GitBox <gi...@apache.org>.
lwclover closed pull request #4224: [ISSUE #4223]Delete repeated calls in MQClientInstance#start
URL: https://github.com/apache/rocketmq/pull/4224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] cserwen commented on pull request #4224: [ISSUE #4223]Delete repeated calls in MQClientInstance#start
Posted by GitBox <gi...@apache.org>.
cserwen commented on PR #4224:
URL: https://github.com/apache/rocketmq/pull/4224#issuecomment-1118106570
> > DefaultMQPushConsumerImpl.java
>
> > It will be used to send retry messages if exception happens.
> > https://github.com/apache/rocketmq/blob/df3f8de4c03a282de052b130ae368ab00faca039/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImpl.java#L512
> >
> > 
>
> It's not like we're talking about the same problem, you can review my code.
Yes, I have reviewed your code before. IMOļ¼the consumer may not work normally if you remove it. Besides, It only brings an extra heartbeat and does not add a new scheduled task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org