You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2008/08/12 19:57:44 UTC

[jira] Created: (HBASE-822) Update thrift README and HBase.thrift to use thrift 20080411

Update thrift README and HBase.thrift to use thrift 20080411
------------------------------------------------------------

                 Key: HBASE-822
                 URL: https://issues.apache.org/jira/browse/HBASE-822
             Project: Hadoop HBase
          Issue Type: Bug
            Reporter: stack
         Attachments: HBase.thrift.patch, README.txt.patch

>From hbase-dev list titled 'Thrift':

{code}
Hey,
When using thrift as per the README.txt in
$HBASE_HOME/src/examples/thrift is outdated and uses deprecated
arguments for thrift.  The command should be

$thrift --gen cpp --gen java -gen rb \
    ../../../src/java/org/apache/hadoop/hbase/thrift/Hbase.thrift

Also, the Hbase.thrift file is a little outdated.  It uses namespaces now.

java_package org.apache.hadoop.hbase.thrift.generated
cpp_namespace apache.hadoop.hbase.thrift
ruby_namespace Apache.Hadoop.Hbase.Thrift

Should be

namespace java org.apache.hadoop.hbase.thrift.generated
namespace cpp  apache.hadoop.hbase.thrift
namespace rb Apache.Hadoop.Hbase.Thrift

I have attached both patch files.

Thanks,
Michael




34,36c34,36
< java_package org.apache.hadoop.hbase.thrift.generated
< cpp_namespace apache.hadoop.hbase.thrift
< ruby_namespace Apache.Hadoop.Hbase.Thrift
---
> > namespace java org.apache.hadoop.hbase.thrift.generated
> > namespace cpp  apache.hadoop.hbase.thrift
> > namespace rb Apache.Hadoop.Hbase.Thrift



12c12
< thrift -cpp -java -rb \
---
> > thrift --gen cpp -- gen java --gen rb \
{code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Created: (HBASE-822) Update thrift README and HBase.thrift to use thrift 20080411

Posted by Michael <mi...@gmail.com>.
One small change.  just a typo actually:

$thrift --gen cpp --gen java -gen rb \
    ../../../src/java/org/apache/hadoop/hbase/thrift/Hbase.thrift

Should be

$thrift --gen cpp --gen java --gen rb \
    ../../../src/java/org/apache/hadoop/hbase/thrift/Hbase.thrift

stack (JIRA) wrote:
> Update thrift README and HBase.thrift to use thrift 20080411
> ------------------------------------------------------------
> 
>                  Key: HBASE-822
>                  URL: https://issues.apache.org/jira/browse/HBASE-822
>              Project: Hadoop HBase
>           Issue Type: Bug
>             Reporter: stack
>          Attachments: HBase.thrift.patch, README.txt.patch
> 
> From hbase-dev list titled 'Thrift':
> 
> {code}
> Hey,
> When using thrift as per the README.txt in
> $HBASE_HOME/src/examples/thrift is outdated and uses deprecated
> arguments for thrift.  The command should be
> 
> $thrift --gen cpp --gen java -gen rb \
>     ../../../src/java/org/apache/hadoop/hbase/thrift/Hbase.thrift
> 
> Also, the Hbase.thrift file is a little outdated.  It uses namespaces now.
> 
> java_package org.apache.hadoop.hbase.thrift.generated
> cpp_namespace apache.hadoop.hbase.thrift
> ruby_namespace Apache.Hadoop.Hbase.Thrift
> 
> Should be
> 
> namespace java org.apache.hadoop.hbase.thrift.generated
> namespace cpp  apache.hadoop.hbase.thrift
> namespace rb Apache.Hadoop.Hbase.Thrift
> 
> I have attached both patch files.
> 
> Thanks,
> Michael
> 
> 
> 
> 
> 34,36c34,36
> < java_package org.apache.hadoop.hbase.thrift.generated
> < cpp_namespace apache.hadoop.hbase.thrift
> < ruby_namespace Apache.Hadoop.Hbase.Thrift
> ---
>>> namespace java org.apache.hadoop.hbase.thrift.generated
>>> namespace cpp  apache.hadoop.hbase.thrift
>>> namespace rb Apache.Hadoop.Hbase.Thrift
> 
> 
> 
> 12c12
> < thrift -cpp -java -rb \
> ---
>>> thrift --gen cpp -- gen java --gen rb \
> {code}
> 

[jira] Updated: (HBASE-822) Update thrift README and HBase.thrift to use thrift 20080411

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-822:
------------------------

    Attachment: HBase.thrift.patch

> Update thrift README and HBase.thrift to use thrift 20080411
> ------------------------------------------------------------
>
>                 Key: HBASE-822
>                 URL: https://issues.apache.org/jira/browse/HBASE-822
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>         Attachments: HBase.thrift.patch, README.txt.patch
>
>
> From hbase-dev list titled 'Thrift':
> {code}
> Hey,
> When using thrift as per the README.txt in
> $HBASE_HOME/src/examples/thrift is outdated and uses deprecated
> arguments for thrift.  The command should be
> $thrift --gen cpp --gen java -gen rb \
>     ../../../src/java/org/apache/hadoop/hbase/thrift/Hbase.thrift
> Also, the Hbase.thrift file is a little outdated.  It uses namespaces now.
> java_package org.apache.hadoop.hbase.thrift.generated
> cpp_namespace apache.hadoop.hbase.thrift
> ruby_namespace Apache.Hadoop.Hbase.Thrift
> Should be
> namespace java org.apache.hadoop.hbase.thrift.generated
> namespace cpp  apache.hadoop.hbase.thrift
> namespace rb Apache.Hadoop.Hbase.Thrift
> I have attached both patch files.
> Thanks,
> Michael
> 34,36c34,36
> < java_package org.apache.hadoop.hbase.thrift.generated
> < cpp_namespace apache.hadoop.hbase.thrift
> < ruby_namespace Apache.Hadoop.Hbase.Thrift
> ---
> > > namespace java org.apache.hadoop.hbase.thrift.generated
> > > namespace cpp  apache.hadoop.hbase.thrift
> > > namespace rb Apache.Hadoop.Hbase.Thrift
> 12c12
> < thrift -cpp -java -rb \
> ---
> > > thrift --gen cpp -- gen java --gen rb \
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-822) Update thrift README and HBase.thrift to use thrift 20080411

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621915#action_12621915 ] 

stack commented on HBASE-822:
-----------------------------

Michael notest that the REAME.txt under examples needs to point at that thrift package javadoc since this is where start of thrift server is described.

> Update thrift README and HBase.thrift to use thrift 20080411
> ------------------------------------------------------------
>
>                 Key: HBASE-822
>                 URL: https://issues.apache.org/jira/browse/HBASE-822
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>         Attachments: HBase.thrift.patch, README.txt.patch
>
>
> From hbase-dev list titled 'Thrift':
> {code}
> Hey,
> When using thrift as per the README.txt in
> $HBASE_HOME/src/examples/thrift is outdated and uses deprecated
> arguments for thrift.  The command should be
> $thrift --gen cpp --gen java -gen rb \
>     ../../../src/java/org/apache/hadoop/hbase/thrift/Hbase.thrift
> Also, the Hbase.thrift file is a little outdated.  It uses namespaces now.
> java_package org.apache.hadoop.hbase.thrift.generated
> cpp_namespace apache.hadoop.hbase.thrift
> ruby_namespace Apache.Hadoop.Hbase.Thrift
> Should be
> namespace java org.apache.hadoop.hbase.thrift.generated
> namespace cpp  apache.hadoop.hbase.thrift
> namespace rb Apache.Hadoop.Hbase.Thrift
> I have attached both patch files.
> Thanks,
> Michael
> 34,36c34,36
> < java_package org.apache.hadoop.hbase.thrift.generated
> < cpp_namespace apache.hadoop.hbase.thrift
> < ruby_namespace Apache.Hadoop.Hbase.Thrift
> ---
> > > namespace java org.apache.hadoop.hbase.thrift.generated
> > > namespace cpp  apache.hadoop.hbase.thrift
> > > namespace rb Apache.Hadoop.Hbase.Thrift
> 12c12
> < thrift -cpp -java -rb \
> ---
> > > thrift --gen cpp -- gen java --gen rb \
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HBASE-822) Update thrift README and HBase.thrift to use thrift 20080411

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack resolved HBASE-822.
-------------------------

       Resolution: Fixed
    Fix Version/s: 0.3.0
                   0.2.1

Committed fixes to README (Tim Sell had already changed Hbase.thrift).

> Update thrift README and HBase.thrift to use thrift 20080411
> ------------------------------------------------------------
>
>                 Key: HBASE-822
>                 URL: https://issues.apache.org/jira/browse/HBASE-822
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>             Fix For: 0.2.1, 0.3.0
>
>         Attachments: HBase.thrift.patch, README.txt.patch
>
>
> From hbase-dev list titled 'Thrift':
> {code}
> Hey,
> When using thrift as per the README.txt in
> $HBASE_HOME/src/examples/thrift is outdated and uses deprecated
> arguments for thrift.  The command should be
> $thrift --gen cpp --gen java -gen rb \
>     ../../../src/java/org/apache/hadoop/hbase/thrift/Hbase.thrift
> Also, the Hbase.thrift file is a little outdated.  It uses namespaces now.
> java_package org.apache.hadoop.hbase.thrift.generated
> cpp_namespace apache.hadoop.hbase.thrift
> ruby_namespace Apache.Hadoop.Hbase.Thrift
> Should be
> namespace java org.apache.hadoop.hbase.thrift.generated
> namespace cpp  apache.hadoop.hbase.thrift
> namespace rb Apache.Hadoop.Hbase.Thrift
> I have attached both patch files.
> Thanks,
> Michael
> 34,36c34,36
> < java_package org.apache.hadoop.hbase.thrift.generated
> < cpp_namespace apache.hadoop.hbase.thrift
> < ruby_namespace Apache.Hadoop.Hbase.Thrift
> ---
> > > namespace java org.apache.hadoop.hbase.thrift.generated
> > > namespace cpp  apache.hadoop.hbase.thrift
> > > namespace rb Apache.Hadoop.Hbase.Thrift
> 12c12
> < thrift -cpp -java -rb \
> ---
> > > thrift --gen cpp -- gen java --gen rb \
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-822) Update thrift README and HBase.thrift to use thrift 20080411

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621937#action_12621937 ] 

stack commented on HBASE-822:
-----------------------------

More from Michael:
{code}
One small change.  just a typo actually:

$thrift --gen cpp --gen java -gen rb \
    ../../../src/java/org/apache/hadoop/hbase/thrift/Hbase.thrift

Should be

$thrift --gen cpp --gen java --gen rb \
    ../../../src/java/org/apache/hadoop/hbase/thrift/Hbase.thrift
{code}

> Update thrift README and HBase.thrift to use thrift 20080411
> ------------------------------------------------------------
>
>                 Key: HBASE-822
>                 URL: https://issues.apache.org/jira/browse/HBASE-822
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>         Attachments: HBase.thrift.patch, README.txt.patch
>
>
> From hbase-dev list titled 'Thrift':
> {code}
> Hey,
> When using thrift as per the README.txt in
> $HBASE_HOME/src/examples/thrift is outdated and uses deprecated
> arguments for thrift.  The command should be
> $thrift --gen cpp --gen java -gen rb \
>     ../../../src/java/org/apache/hadoop/hbase/thrift/Hbase.thrift
> Also, the Hbase.thrift file is a little outdated.  It uses namespaces now.
> java_package org.apache.hadoop.hbase.thrift.generated
> cpp_namespace apache.hadoop.hbase.thrift
> ruby_namespace Apache.Hadoop.Hbase.Thrift
> Should be
> namespace java org.apache.hadoop.hbase.thrift.generated
> namespace cpp  apache.hadoop.hbase.thrift
> namespace rb Apache.Hadoop.Hbase.Thrift
> I have attached both patch files.
> Thanks,
> Michael
> 34,36c34,36
> < java_package org.apache.hadoop.hbase.thrift.generated
> < cpp_namespace apache.hadoop.hbase.thrift
> < ruby_namespace Apache.Hadoop.Hbase.Thrift
> ---
> > > namespace java org.apache.hadoop.hbase.thrift.generated
> > > namespace cpp  apache.hadoop.hbase.thrift
> > > namespace rb Apache.Hadoop.Hbase.Thrift
> 12c12
> < thrift -cpp -java -rb \
> ---
> > > thrift --gen cpp -- gen java --gen rb \
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-822) Update thrift README and HBase.thrift to use thrift 20080411

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-822:
------------------------

    Attachment: README.txt.patch

> Update thrift README and HBase.thrift to use thrift 20080411
> ------------------------------------------------------------
>
>                 Key: HBASE-822
>                 URL: https://issues.apache.org/jira/browse/HBASE-822
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>         Attachments: HBase.thrift.patch, README.txt.patch
>
>
> From hbase-dev list titled 'Thrift':
> {code}
> Hey,
> When using thrift as per the README.txt in
> $HBASE_HOME/src/examples/thrift is outdated and uses deprecated
> arguments for thrift.  The command should be
> $thrift --gen cpp --gen java -gen rb \
>     ../../../src/java/org/apache/hadoop/hbase/thrift/Hbase.thrift
> Also, the Hbase.thrift file is a little outdated.  It uses namespaces now.
> java_package org.apache.hadoop.hbase.thrift.generated
> cpp_namespace apache.hadoop.hbase.thrift
> ruby_namespace Apache.Hadoop.Hbase.Thrift
> Should be
> namespace java org.apache.hadoop.hbase.thrift.generated
> namespace cpp  apache.hadoop.hbase.thrift
> namespace rb Apache.Hadoop.Hbase.Thrift
> I have attached both patch files.
> Thanks,
> Michael
> 34,36c34,36
> < java_package org.apache.hadoop.hbase.thrift.generated
> < cpp_namespace apache.hadoop.hbase.thrift
> < ruby_namespace Apache.Hadoop.Hbase.Thrift
> ---
> > > namespace java org.apache.hadoop.hbase.thrift.generated
> > > namespace cpp  apache.hadoop.hbase.thrift
> > > namespace rb Apache.Hadoop.Hbase.Thrift
> 12c12
> < thrift -cpp -java -rb \
> ---
> > > thrift --gen cpp -- gen java --gen rb \
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.