You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by vi...@apache.org on 2021/08/10 05:01:14 UTC
[superset] 04/25: fix: Adding report bug (#16065)
This is an automated email from the ASF dual-hosted git repository.
villebro pushed a commit to branch 1.3
in repository https://gitbox.apache.org/repos/asf/superset.git
commit d320a97ae6dc37c370764bb7a54291f5f454d3bc
Author: AAfghahi <48...@users.noreply.github.com>
AuthorDate: Wed Aug 4 14:37:46 2021 -0400
fix: Adding report bug (#16065)
* report add fix
* added theme
(cherry picked from commit 4359650b7db973818407c68e4f2ec634b5b89503)
---
.../components/ReportModal/HeaderReportActionsDropdown/index.tsx | 6 ++++--
superset-frontend/src/reports/actions/reports.js | 4 ++--
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/superset-frontend/src/components/ReportModal/HeaderReportActionsDropdown/index.tsx b/superset-frontend/src/components/ReportModal/HeaderReportActionsDropdown/index.tsx
index df0253c..2ffc6f2 100644
--- a/superset-frontend/src/components/ReportModal/HeaderReportActionsDropdown/index.tsx
+++ b/superset-frontend/src/components/ReportModal/HeaderReportActionsDropdown/index.tsx
@@ -18,7 +18,7 @@
*/
import React, { useState } from 'react';
import { useSelector } from 'react-redux';
-import { t, SupersetTheme, css } from '@superset-ui/core';
+import { t, SupersetTheme, css, useTheme } from '@superset-ui/core';
import Icons from 'src/components/Icons';
import { Switch } from 'src/components/Switch';
import { AlertObject } from 'src/views/CRUD/alert/types';
@@ -47,6 +47,7 @@ export default function HeaderReportActionsDropDown({
currentReportDeleting,
setCurrentReportDeleting,
] = useState<AlertObject | null>(null);
+ const theme = useTheme();
const toggleActiveKey = async (data: AlertObject, checked: boolean) => {
if (data?.id) {
@@ -60,7 +61,7 @@ export default function HeaderReportActionsDropDown({
};
const menu = () => (
- <Menu selectable={false}>
+ <Menu selectable={false} css={{ width: '200px' }}>
<Menu.Item>
{t('Email reports active')}
<Switch
@@ -68,6 +69,7 @@ export default function HeaderReportActionsDropDown({
checked={report?.active}
onClick={(checked: boolean) => toggleActiveKey(report, checked)}
size="small"
+ css={{ marginLeft: theme.gridUnit * 2 }}
/>
</Menu.Item>
<Menu.Item onClick={showReportModal}>{t('Edit email report')}</Menu.Item>
diff --git a/superset-frontend/src/reports/actions/reports.js b/superset-frontend/src/reports/actions/reports.js
index 546fe96..0407383 100644
--- a/superset-frontend/src/reports/actions/reports.js
+++ b/superset-frontend/src/reports/actions/reports.js
@@ -102,8 +102,8 @@ export const addReport = report => dispatch => {
endpoint: `/api/v1/report/`,
jsonPayload: report,
})
- .then(() => {
- dispatch({ type: ADD_REPORT, report });
+ .then(({ json }) => {
+ dispatch({ type: ADD_REPORT, json });
dispatch(addSuccessToast(t('The report has been created')));
})
.catch(() =>