You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/05/30 05:37:51 UTC
[GitHub] [shardingsphere] misselvexu opened a new pull request, #18059: Add unit test cases for WeOpen-Star .
misselvexu opened a new pull request, #18059:
URL: https://github.com/apache/shardingsphere/pull/18059
Fixes #17574 .
Fixes #17573 .
Fixes #17572 .
Fixes #17571 .
Fixes #17570 .
Fixes #17569 .
Fixes #17568 .
Fixes #17567 .
Fixes #17566 .
Fixes #17565 .
Fixes #17564 .
Fixes #17563 .
Changes proposed in this pull request:
- https://github.com/apache/shardingsphere/issues/17563.
- https://github.com/apache/shardingsphere/issues/17564
- https://github.com/apache/shardingsphere/issues/17565
- https://github.com/apache/shardingsphere/issues/17566
- https://github.com/apache/shardingsphere/issues/17567
- https://github.com/apache/shardingsphere/issues/17568
- https://github.com/apache/shardingsphere/issues/17569
- https://github.com/apache/shardingsphere/issues/17570
- https://github.com/apache/shardingsphere/issues/17571
- https://github.com/apache/shardingsphere/issues/17572
- https://github.com/apache/shardingsphere/issues/17573
- https://github.com/apache/shardingsphere/issues/17574
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #18059: Add unit test cases for WeOpen-Star .
Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #18059:
URL: https://github.com/apache/shardingsphere/pull/18059
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zjcnb commented on pull request #18059: Add unit test cases for WeOpen-Star .
Posted by GitBox <gi...@apache.org>.
zjcnb commented on PR #18059:
URL: https://github.com/apache/shardingsphere/pull/18059#issuecomment-1146733252
@misselvexu Why not submit multiple PRs separately? it's too painful for reviewers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #18059: Add unit test cases for WeOpen-Star .
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #18059:
URL: https://github.com/apache/shardingsphere/pull/18059#issuecomment-1140742619
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18059?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18059](https://codecov.io/gh/apache/shardingsphere/pull/18059?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (06f9381) into [master](https://codecov.io/gh/apache/shardingsphere/commit/0f8ffc35a6a87af4fe9af49a0c184220ac2a7497?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0f8ffc3) will **increase** coverage by `0.05%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #18059 +/- ##
============================================
+ Coverage 58.95% 59.01% +0.05%
- Complexity 2151 2155 +4
============================================
Files 3669 3672 +3
Lines 54139 54129 -10
Branches 9186 9186
============================================
+ Hits 31919 31942 +23
+ Misses 19515 19481 -34
- Partials 2705 2706 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/18059?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/shardingsphere/infra/instance/utils/IpUtils.java](https://codecov.io/gh/apache/shardingsphere/pull/18059/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9pbnN0YW5jZS91dGlscy9JcFV0aWxzLmphdmE=) | `60.00% <0.00%> (-8.00%)` | :arrow_down: |
| [...l/parser/core/database/visitor/SQLVisitorRule.java](https://codecov.io/gh/apache/shardingsphere/pull/18059/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL2RhdGFiYXNlL3Zpc2l0b3IvU1FMVmlzaXRvclJ1bGUuamF2YQ==) | `100.00% <0.00%> (ø)` | |
| [...gy/sharding/NoneShardingStrategyConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/18059/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9hcGkvY29uZmlnL3N0cmF0ZWd5L3NoYXJkaW5nL05vbmVTaGFyZGluZ1N0cmF0ZWd5Q29uZmlndXJhdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ngsphere/infra/instance/definition/InstanceId.java](https://codecov.io/gh/apache/shardingsphere/pull/18059/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9pbnN0YW5jZS9kZWZpbml0aW9uL0luc3RhbmNlSWQuamF2YQ==) | | |
| [...common/statement/ddl/CreateDiskgroupStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/18059/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvY29tbW9uL3N0YXRlbWVudC9kZGwvQ3JlYXRlRGlza2dyb3VwU3RhdGVtZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...i/sharding/standard/StandardShardingAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/18059/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9hcGkvc2hhcmRpbmcvc3RhbmRhcmQvU3RhbmRhcmRTaGFyZGluZ0FsZ29yaXRobS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...tatement/ddl/CreateDiskgroupStatementTestCase.java](https://codecov.io/gh/apache/shardingsphere/pull/18059/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvamF4Yi9jYXNlcy9kb21haW4vc3RhdGVtZW50L2RkbC9DcmVhdGVEaXNrZ3JvdXBTdGF0ZW1lbnRUZXN0Q2FzZS5qYXZh) | `100.00% <0.00%> (ø)` | |
| [...ent/oracle/ddl/OracleCreateDiskgroupStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/18059/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9zdGF0ZW1lbnQvb3JhY2xlL2RkbC9PcmFjbGVDcmVhdGVEaXNrZ3JvdXBTdGF0ZW1lbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...eterized/jaxb/cases/domain/SQLParserTestCases.java](https://codecov.io/gh/apache/shardingsphere/pull/18059/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvamF4Yi9jYXNlcy9kb21haW4vU1FMUGFyc2VyVGVzdENhc2VzLmphdmE=) | `99.85% <0.00%> (+<0.01%)` | :arrow_up: |
| [...r/statement/impl/OracleDDLStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/18059/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1vcmFjbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvb3JhY2xlL3Zpc2l0b3Ivc3RhdGVtZW50L2ltcGwvT3JhY2xlRERMU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `87.50% <0.00%> (+0.04%)` | :arrow_up: |
| ... and [14 more](https://codecov.io/gh/apache/shardingsphere/pull/18059/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18059?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18059?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4332e31...06f9381](https://codecov.io/gh/apache/shardingsphere/pull/18059?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] misselvexu commented on pull request #18059: Add unit test cases for WeOpen-Star .
Posted by GitBox <gi...@apache.org>.
misselvexu commented on PR #18059:
URL: https://github.com/apache/shardingsphere/pull/18059#issuecomment-1146747635
> @misselvexu Why not submit multiple PRs separately? it's too painful for reviewers.
Too much pr is a bit troublesome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org