You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by revans2 <gi...@git.apache.org> on 2016/01/05 15:30:20 UTC

[GitHub] storm pull request: [STORM-1415] Some improvements for trident map...

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/973#discussion_r48849410
  
    --- Diff: storm-core/src/jvm/storm/trident/state/map/MapCombinerAggStateUpdater.java ---
    @@ -33,24 +33,25 @@
     import storm.trident.tuple.TridentTupleView.ProjectionFactory;
     
     public class MapCombinerAggStateUpdater implements StateUpdater<MapState> {
    +    //ANY CHANGE TO THIS CODE MUST BE SERIALIZABLE COMPATIBLE OR THERE WILL BE PROBLEMS
    +    private static final long serialVersionUID = 4783054195826968400L;
    +
         CombinerAggregator _agg;
         Fields _groupFields;
         Fields _inputFields;
         ProjectionFactory _groupFactory;
         ProjectionFactory _inputFactory;
    --- End diff --
    
    Because we are setting the serialVersionUID now.  Can we mark _groupFactory and _inputFactory as transient?  They are set in the prepare, so having them not be transient is unneeded.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---