You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/03/09 19:14:39 UTC

[GitHub] wes3 commented on issue #897: Move cmsis_nvic.h files frm BSP to MCU

wes3 commented on issue #897: Move cmsis_nvic.h files frm BSP to MCU
URL: https://github.com/apache/mynewt-core/pull/897#issuecomment-371917001
 
 
   OK, I suspected that might be the case. Again, just my opinion, but I think having defines in cmsis_nvic.h for the various MCU's. For example:
   
   #ifdef __STM32F407xx_H
   #define NUM_VECTORS 81
   #endif
    
   Excuse my shorthand but you get the idea. For some reason seeing the #include syscfg.h in cmsis_nvic.h bothers me.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services