You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Geoff Reedy (JIRA)" <ji...@apache.org> on 2008/11/17 21:36:44 UTC
[jira] Created: (WICKET-1938) Use XMLUnit for framework tests
Use XMLUnit for framework tests
-------------------------------
Key: WICKET-1938
URL: https://issues.apache.org/jira/browse/WICKET-1938
Project: Wicket
Issue Type: Improvement
Reporter: Geoff Reedy
Currently the framework tests are comparing xml/html documents as strings. This causes spurious test failures when executed on a 1.6 JDK. For example:
Running org.apache.wicket.ajax.AjaxRequestTargetTest
2c2
< <style type="text/css" id="org-apache-wicket-ajax-MockComponent1-0">
---
> <style id="org-apache-wicket-ajax-MockComponent1-0" type="text/css">
2c2
< <link href="resources/org.apache.wicket.ajax.MockComponent3/mockStyleSheet3.css" rel="stylesheet" type="text/css"/>
---
> <link rel="stylesheet" type="text/css" href="resources/org.apache.wicket.ajax.MockComponent3/mockStyleSheet3.css"/>
Tests run: 3, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.087 sec <<< FAILURE!
Obviously the snippets are semantically equivalent. XMLUnit would have recognized this and not failed the test.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1938) Use XMLUnit for framework tests
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juergen Donnerstag resolved WICKET-1938.
----------------------------------------
Resolution: Duplicate
Fix Version/s: (was: 1.5-M1)
1.4-RC2
WICKET-1389
> Use XMLUnit for framework tests
> -------------------------------
>
> Key: WICKET-1938
> URL: https://issues.apache.org/jira/browse/WICKET-1938
> Project: Wicket
> Issue Type: Improvement
> Reporter: Geoff Reedy
> Fix For: 1.4-RC2
>
>
> Currently the framework tests are comparing xml/html documents as strings. This causes spurious test failures when executed on a 1.6 JDK. For example:
> Running org.apache.wicket.ajax.AjaxRequestTargetTest
> 2c2
> < <style type="text/css" id="org-apache-wicket-ajax-MockComponent1-0">
> ---
> > <style id="org-apache-wicket-ajax-MockComponent1-0" type="text/css">
> 2c2
> < <link href="resources/org.apache.wicket.ajax.MockComponent3/mockStyleSheet3.css" rel="stylesheet" type="text/css"/>
> ---
> > <link rel="stylesheet" type="text/css" href="resources/org.apache.wicket.ajax.MockComponent3/mockStyleSheet3.css"/>
> Tests run: 3, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.087 sec <<< FAILURE!
> Obviously the snippets are semantically equivalent. XMLUnit would have recognized this and not failed the test.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1938) Use XMLUnit for framework tests
Posted by "Geoff Reedy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654431#action_12654431 ]
Geoff Reedy commented on WICKET-1938:
-------------------------------------
According to the XmlUnit website: XMLUnit for Java can also treat HTML content (even badly-formed HTML) as valid XML to allow these assertions to be made about the content of web pages too.
Anyway it looks like the output for the wicket test cases are well-formed XML too.
> Use XMLUnit for framework tests
> -------------------------------
>
> Key: WICKET-1938
> URL: https://issues.apache.org/jira/browse/WICKET-1938
> Project: Wicket
> Issue Type: Improvement
> Reporter: Geoff Reedy
> Fix For: 1.5-M1
>
>
> Currently the framework tests are comparing xml/html documents as strings. This causes spurious test failures when executed on a 1.6 JDK. For example:
> Running org.apache.wicket.ajax.AjaxRequestTargetTest
> 2c2
> < <style type="text/css" id="org-apache-wicket-ajax-MockComponent1-0">
> ---
> > <style id="org-apache-wicket-ajax-MockComponent1-0" type="text/css">
> 2c2
> < <link href="resources/org.apache.wicket.ajax.MockComponent3/mockStyleSheet3.css" rel="stylesheet" type="text/css"/>
> ---
> > <link rel="stylesheet" type="text/css" href="resources/org.apache.wicket.ajax.MockComponent3/mockStyleSheet3.css"/>
> Tests run: 3, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.087 sec <<< FAILURE!
> Obviously the snippets are semantically equivalent. XMLUnit would have recognized this and not failed the test.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1938) Use XMLUnit for framework tests
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654191#action_12654191 ]
Juergen Donnerstag commented on WICKET-1938:
--------------------------------------------
true, but XMLUnit is not able to handle HTML. Some html tags are allowed to have no close tag.
> Use XMLUnit for framework tests
> -------------------------------
>
> Key: WICKET-1938
> URL: https://issues.apache.org/jira/browse/WICKET-1938
> Project: Wicket
> Issue Type: Improvement
> Reporter: Geoff Reedy
> Fix For: 1.5-M1
>
>
> Currently the framework tests are comparing xml/html documents as strings. This causes spurious test failures when executed on a 1.6 JDK. For example:
> Running org.apache.wicket.ajax.AjaxRequestTargetTest
> 2c2
> < <style type="text/css" id="org-apache-wicket-ajax-MockComponent1-0">
> ---
> > <style id="org-apache-wicket-ajax-MockComponent1-0" type="text/css">
> 2c2
> < <link href="resources/org.apache.wicket.ajax.MockComponent3/mockStyleSheet3.css" rel="stylesheet" type="text/css"/>
> ---
> > <link rel="stylesheet" type="text/css" href="resources/org.apache.wicket.ajax.MockComponent3/mockStyleSheet3.css"/>
> Tests run: 3, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.087 sec <<< FAILURE!
> Obviously the snippets are semantically equivalent. XMLUnit would have recognized this and not failed the test.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1938) Use XMLUnit for framework tests
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656372#action_12656372 ]
Juergen Donnerstag commented on WICKET-1938:
--------------------------------------------
I'll play a bit with xmlunit.
Wicket does not automatically generate well formed xml. A setting exist to do that, but default it is off. The html provided will be forwarded to the output
> Use XMLUnit for framework tests
> -------------------------------
>
> Key: WICKET-1938
> URL: https://issues.apache.org/jira/browse/WICKET-1938
> Project: Wicket
> Issue Type: Improvement
> Reporter: Geoff Reedy
> Fix For: 1.5-M1
>
>
> Currently the framework tests are comparing xml/html documents as strings. This causes spurious test failures when executed on a 1.6 JDK. For example:
> Running org.apache.wicket.ajax.AjaxRequestTargetTest
> 2c2
> < <style type="text/css" id="org-apache-wicket-ajax-MockComponent1-0">
> ---
> > <style id="org-apache-wicket-ajax-MockComponent1-0" type="text/css">
> 2c2
> < <link href="resources/org.apache.wicket.ajax.MockComponent3/mockStyleSheet3.css" rel="stylesheet" type="text/css"/>
> ---
> > <link rel="stylesheet" type="text/css" href="resources/org.apache.wicket.ajax.MockComponent3/mockStyleSheet3.css"/>
> Tests run: 3, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.087 sec <<< FAILURE!
> Obviously the snippets are semantically equivalent. XMLUnit would have recognized this and not failed the test.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1938) Use XMLUnit for framework tests
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656374#action_12656374 ]
Juergen Donnerstag commented on WICKET-1938:
--------------------------------------------
actually problem has been fixed already: WICKET-1389
> Use XMLUnit for framework tests
> -------------------------------
>
> Key: WICKET-1938
> URL: https://issues.apache.org/jira/browse/WICKET-1938
> Project: Wicket
> Issue Type: Improvement
> Reporter: Geoff Reedy
> Fix For: 1.4-RC2
>
>
> Currently the framework tests are comparing xml/html documents as strings. This causes spurious test failures when executed on a 1.6 JDK. For example:
> Running org.apache.wicket.ajax.AjaxRequestTargetTest
> 2c2
> < <style type="text/css" id="org-apache-wicket-ajax-MockComponent1-0">
> ---
> > <style id="org-apache-wicket-ajax-MockComponent1-0" type="text/css">
> 2c2
> < <link href="resources/org.apache.wicket.ajax.MockComponent3/mockStyleSheet3.css" rel="stylesheet" type="text/css"/>
> ---
> > <link rel="stylesheet" type="text/css" href="resources/org.apache.wicket.ajax.MockComponent3/mockStyleSheet3.css"/>
> Tests run: 3, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.087 sec <<< FAILURE!
> Obviously the snippets are semantically equivalent. XMLUnit would have recognized this and not failed the test.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1938) Use XMLUnit for framework tests
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-1938:
----------------------------------
Fix Version/s: 1.5-M1
> Use XMLUnit for framework tests
> -------------------------------
>
> Key: WICKET-1938
> URL: https://issues.apache.org/jira/browse/WICKET-1938
> Project: Wicket
> Issue Type: Improvement
> Reporter: Geoff Reedy
> Fix For: 1.5-M1
>
>
> Currently the framework tests are comparing xml/html documents as strings. This causes spurious test failures when executed on a 1.6 JDK. For example:
> Running org.apache.wicket.ajax.AjaxRequestTargetTest
> 2c2
> < <style type="text/css" id="org-apache-wicket-ajax-MockComponent1-0">
> ---
> > <style id="org-apache-wicket-ajax-MockComponent1-0" type="text/css">
> 2c2
> < <link href="resources/org.apache.wicket.ajax.MockComponent3/mockStyleSheet3.css" rel="stylesheet" type="text/css"/>
> ---
> > <link rel="stylesheet" type="text/css" href="resources/org.apache.wicket.ajax.MockComponent3/mockStyleSheet3.css"/>
> Tests run: 3, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.087 sec <<< FAILURE!
> Obviously the snippets are semantically equivalent. XMLUnit would have recognized this and not failed the test.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.