You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2016/04/19 18:16:05 UTC
Review Request 46391: Clarified several agent log messages.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46391/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar and Vinod Kone.
Repository: mesos
Description
-------
When diagnosing problems, it can be useful to distinguish
between executors that are "terminating" vs. "terminated".
Diffs
-----
src/slave/slave.cpp d82dec2b10d496065013eb4ad6a35dc054b72553
Diff: https://reviews.apache.org/r/46391/diff/
Testing
-------
make check
Thanks,
Neil Conway
Re: Review Request 46391: Clarified several agent log messages.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46391/#review130170
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On April 22, 2016, 3:28 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46391/
> -----------------------------------------------------------
>
> (Updated April 22, 2016, 3:28 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When diagnosing problems, it can be useful to distinguish
> between executors that are "terminating" vs. "terminated".
>
>
> Diffs
> -----
>
> src/slave/slave.cpp a365e8f5f8d63bf80614fccf6adf35a4fee07526
>
> Diff: https://reviews.apache.org/r/46391/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 46391: Clarified several agent log messages.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46391/#review130177
-----------------------------------------------------------
Patch looks great!
Reviews applied: [46391]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 22, 2016, 3:28 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46391/
> -----------------------------------------------------------
>
> (Updated April 22, 2016, 3:28 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When diagnosing problems, it can be useful to distinguish
> between executors that are "terminating" vs. "terminated".
>
>
> Diffs
> -----
>
> src/slave/slave.cpp a365e8f5f8d63bf80614fccf6adf35a4fee07526
>
> Diff: https://reviews.apache.org/r/46391/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 46391: Clarified several agent log messages.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46391/
-----------------------------------------------------------
(Updated April 22, 2016, 3:28 p.m.)
Review request for mesos, Anand Mazumdar and Vinod Kone.
Changes
-------
Address review comment.
Repository: mesos
Description
-------
When diagnosing problems, it can be useful to distinguish
between executors that are "terminating" vs. "terminated".
Diffs (updated)
-----
src/slave/slave.cpp a365e8f5f8d63bf80614fccf6adf35a4fee07526
Diff: https://reviews.apache.org/r/46391/diff/
Testing
-------
make check
Thanks,
Neil Conway
Re: Review Request 46391: Clarified several agent log messages.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46391/#review129616
-----------------------------------------------------------
Patch looks great!
Reviews applied: [46391]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 19, 2016, 4:16 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46391/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 4:16 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When diagnosing problems, it can be useful to distinguish
> between executors that are "terminating" vs. "terminated".
>
>
> Diffs
> -----
>
> src/slave/slave.cpp d82dec2b10d496065013eb4ad6a35dc054b72553
>
> Diff: https://reviews.apache.org/r/46391/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 46391: Clarified several agent log messages.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46391/#review129999
-----------------------------------------------------------
src/slave/slave.cpp (line 1826)
<https://reviews.apache.org/r/46391/#comment193603>
s/statusText/executorState/
- Vinod Kone
On April 19, 2016, 4:16 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46391/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 4:16 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When diagnosing problems, it can be useful to distinguish
> between executors that are "terminating" vs. "terminated".
>
>
> Diffs
> -----
>
> src/slave/slave.cpp d82dec2b10d496065013eb4ad6a35dc054b72553
>
> Diff: https://reviews.apache.org/r/46391/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Neil Conway
>
>