You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by John Sirois <js...@apache.org> on 2016/04/12 06:44:42 UTC
Review Request 46069: Add a test for invalid member nodes.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46069/
-----------------------------------------------------------
Review request for Aurora and Zameer Manji.
Bugs: AURORA-1468
https://issues.apache.org/jira/browse/AURORA-1468
Repository: aurora
Description
-------
src/test/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitorTest.java | 24 +++++++++++++++++++++++-
1 file changed, 23 insertions(+), 1 deletion(-)
Diffs
-----
src/test/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitorTest.java 0879c2e19d7aec7564afef2558fdd653bf2ccdb1
Diff: https://reviews.apache.org/r/46069/diff/
Testing
-------
Locally green: `./gradlew -Pq build`
Thanks,
John Sirois
Re: Review Request 46069: Add a test for invalid member nodes.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46069/#review128333
-----------------------------------------------------------
Ship it!
Master (140b6e7) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 12, 2016, 4:44 a.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46069/
> -----------------------------------------------------------
>
> (Updated April 12, 2016, 4:44 a.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Bugs: AURORA-1468
> https://issues.apache.org/jira/browse/AURORA-1468
>
>
> Repository: aurora
>
>
> Description
> -------
>
> src/test/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitorTest.java | 24 +++++++++++++++++++++++-
> 1 file changed, 23 insertions(+), 1 deletion(-)
>
>
> Diffs
> -----
>
> src/test/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitorTest.java 0879c2e19d7aec7564afef2558fdd653bf2ccdb1
>
> Diff: https://reviews.apache.org/r/46069/diff/
>
>
> Testing
> -------
>
> Locally green: `./gradlew -Pq build`
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 46069: Add a test for invalid member nodes.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46069/#review128472
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On April 11, 2016, 9:44 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46069/
> -----------------------------------------------------------
>
> (Updated April 11, 2016, 9:44 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Bugs: AURORA-1468
> https://issues.apache.org/jira/browse/AURORA-1468
>
>
> Repository: aurora
>
>
> Description
> -------
>
> src/test/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitorTest.java | 24 +++++++++++++++++++++++-
> 1 file changed, 23 insertions(+), 1 deletion(-)
>
>
> Diffs
> -----
>
> src/test/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitorTest.java 0879c2e19d7aec7564afef2558fdd653bf2ccdb1
>
> Diff: https://reviews.apache.org/r/46069/diff/
>
>
> Testing
> -------
>
> Locally green: `./gradlew -Pq build`
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 46069: Add a test for invalid member nodes.
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46069/#review128331
-----------------------------------------------------------
This is a follow-up to https://reviews.apache.org/r/45902/ that required the JSON Codec fix from https://reviews.apache.org/r/45992/.
- John Sirois
On April 11, 2016, 10:44 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46069/
> -----------------------------------------------------------
>
> (Updated April 11, 2016, 10:44 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Bugs: AURORA-1468
> https://issues.apache.org/jira/browse/AURORA-1468
>
>
> Repository: aurora
>
>
> Description
> -------
>
> src/test/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitorTest.java | 24 +++++++++++++++++++++++-
> 1 file changed, 23 insertions(+), 1 deletion(-)
>
>
> Diffs
> -----
>
> src/test/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitorTest.java 0879c2e19d7aec7564afef2558fdd653bf2ccdb1
>
> Diff: https://reviews.apache.org/r/46069/diff/
>
>
> Testing
> -------
>
> Locally green: `./gradlew -Pq build`
>
>
> Thanks,
>
> John Sirois
>
>