You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/04 05:20:44 UTC
[GitHub] [flink] luoyuxia opened a new pull request, #19876: [FLINK-27895][build] Enable the CI test for Hive's 3.x
luoyuxia opened a new pull request, #19876:
URL: https://github.com/apache/flink/pull/19876
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)*
## Brief change log
*(for example:)*
- *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
- *Deployments RPC transmits only the blob storage reference*
- *TaskManagers retrieve the TaskInfo from the blob cache*
## Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (100MB)*
- *Extended integration test for recovery after master (JobManager) failure*
- *Added test that validates that TaskInfo is transferred only once across recoveries*
- *Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #19876: [FLINK-27895][hive][build] Enable test for Hive 3.1.2 in nightly builds
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #19876:
URL: https://github.com/apache/flink/pull/19876#discussion_r892085091
##########
flink-connectors/flink-connector-hive/pom.xml:
##########
@@ -1024,9 +1024,25 @@ under the License.
<profiles>
<!-- Activate these profiles with -Phive-x.x.x to build and test against different Hive versions -->
<profile>
- <id>hive-3.1.1</id>
+ <id>hive-3.1.2</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <configuration>
+ <!-- disable running test in parallel for hive 3.1.2, otherwise, there'll be some concurrency issues -->
Review Comment:
Do you have an example for such an issue?
##########
flink-connectors/flink-connector-hive/pom.xml:
##########
@@ -1024,9 +1024,25 @@ under the License.
<profiles>
<!-- Activate these profiles with -Phive-x.x.x to build and test against different Hive versions -->
<profile>
- <id>hive-3.1.1</id>
+ <id>hive-3.1.2</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <configuration>
+ <!-- disable running test in parallel for hive 3.1.2, otherwise, there'll be some concurrency issues -->
+ <forkCount>1</forkCount>
+ <reuseForks>false</reuseForks>
+ <systemPropertyVariables>
+ <derby.stream.error.file>${project.build.directory}/derby.log</derby.stream.error.file>
+ </systemPropertyVariables>
+ </configuration>
+ </plugin>
+ </plugins>
+ </build>
<properties>
- <hive.version>3.1.1</hive.version>
+ <hive.version>3.1.2</hive.version>
Review Comment:
Why are we now also bumping hive? That should be a separate change.
##########
flink-connectors/flink-connector-hive/pom.xml:
##########
@@ -1024,9 +1024,25 @@ under the License.
<profiles>
<!-- Activate these profiles with -Phive-x.x.x to build and test against different Hive versions -->
<profile>
- <id>hive-3.1.1</id>
+ <id>hive-3.1.2</id>
Review Comment:
Ideally we drop the patch version from the profile id so we don't have to touch the ci scripts every time we bump hive.
##########
flink-connectors/flink-connector-hive/pom.xml:
##########
@@ -1024,9 +1024,25 @@ under the License.
<profiles>
<!-- Activate these profiles with -Phive-x.x.x to build and test against different Hive versions -->
<profile>
- <id>hive-3.1.1</id>
+ <id>hive-3.1.2</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <configuration>
+ <!-- disable running test in parallel for hive 3.1.2, otherwise, there'll be some concurrency issues -->
+ <forkCount>1</forkCount>
+ <reuseForks>false</reuseForks>
Review Comment:
FYI this doesn't work because the settings in the unit/Itcase executions take precedence.
##########
flink-connectors/flink-connector-hive/pom.xml:
##########
@@ -1024,9 +1024,25 @@ under the License.
<profiles>
<!-- Activate these profiles with -Phive-x.x.x to build and test against different Hive versions -->
<profile>
- <id>hive-3.1.1</id>
+ <id>hive-3.1.2</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <configuration>
+ <!-- disable running test in parallel for hive 3.1.2, otherwise, there'll be some concurrency issues -->
+ <forkCount>1</forkCount>
+ <reuseForks>false</reuseForks>
+ <systemPropertyVariables>
+ <derby.stream.error.file>${project.build.directory}/derby.log</derby.stream.error.file>
+ </systemPropertyVariables>
Review Comment:
This is redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on a diff in pull request #19876: [FLINK-27895][hive][build] Enable test for Hive 3.1.2 in nightly builds
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on code in PR #19876:
URL: https://github.com/apache/flink/pull/19876#discussion_r891121329
##########
tools/azure-pipelines/jobs-template.yml:
##########
@@ -100,6 +100,8 @@ jobs:
module: tests
misc:
module: misc
+ connector_hive_312:
+ module: connector_hive_312
Review Comment:
Agreed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on a diff in pull request #19876: [FLINK-27895][hive][build] Enable test for Hive 3.x in nightly builds
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on code in PR #19876:
URL: https://github.com/apache/flink/pull/19876#discussion_r894388661
##########
flink-connectors/flink-connector-hive/pom.xml:
##########
@@ -1024,9 +1024,25 @@ under the License.
<profiles>
<!-- Activate these profiles with -Phive-x.x.x to build and test against different Hive versions -->
<profile>
- <id>hive-3.1.1</id>
+ <id>hive-3.1.2</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <configuration>
+ <!-- disable running test in parallel for hive 3.1.2, otherwise, there'll be some concurrency issues -->
+ <forkCount>1</forkCount>
+ <reuseForks>false</reuseForks>
Review Comment:
Thanks for you explanation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on a diff in pull request #19876: [FLINK-27895][hive][build] Enable test for Hive 3.x in nightly builds
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on code in PR #19876:
URL: https://github.com/apache/flink/pull/19876#discussion_r892160004
##########
flink-connectors/flink-connector-hive/pom.xml:
##########
@@ -1024,9 +1024,25 @@ under the License.
<profiles>
<!-- Activate these profiles with -Phive-x.x.x to build and test against different Hive versions -->
<profile>
- <id>hive-3.1.1</id>
+ <id>hive-3.1.2</id>
Review Comment:
I change it `hive3` now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on a diff in pull request #19876: [FLINK-27895][build] Enable the CI test for Hive 3.1.2
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on code in PR #19876:
URL: https://github.com/apache/flink/pull/19876#discussion_r890943036
##########
tools/azure-pipelines/jobs-template.yml:
##########
@@ -100,6 +100,8 @@ jobs:
module: tests
misc:
module: misc
+ connector_hive_312:
+ module: connector_hive_312
Review Comment:
I think any connector should be part of the connector tests, not as a separate module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on pull request #19876: [FLINK-27895][hive][build] Enable test for Hive 3.1.2 in nightly builds
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on PR #19876:
URL: https://github.com/apache/flink/pull/19876#issuecomment-1148564939
@zentol Thanks for your suggestion. It works for me to have it in the cron jobs. Now, I put it in the `cron_hadoop313`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on a diff in pull request #19876: [FLINK-27895][hive][build] Enable test for Hive 3.x in nightly builds
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on code in PR #19876:
URL: https://github.com/apache/flink/pull/19876#discussion_r892162595
##########
flink-connectors/flink-connector-hive/pom.xml:
##########
@@ -1024,9 +1024,25 @@ under the License.
<profiles>
<!-- Activate these profiles with -Phive-x.x.x to build and test against different Hive versions -->
<profile>
- <id>hive-3.1.1</id>
+ <id>hive-3.1.2</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <configuration>
+ <!-- disable running test in parallel for hive 3.1.2, otherwise, there'll be some concurrency issues -->
Review Comment:
When remove the following configuration and run test with `mvn test -Phive3` in `flink/flink-connectors/flink-connector-hive`, it will throw the exception
`Caused by: MetaException(message:Required table missing : "DBS" in Catalog "" Schema "". DataNucleus requires this table to perform its persistence operations. Either your MetaData is incorrect, or you need to enable "datanucleus.schema.autoCreateTables")`.
But after add the following configuration to disable running in parallel, and run with `mvn test -Phive3`, everything is ok without throw any exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #19876: [FLINK-27895][hive][build] Enable test for Hive 3.x in nightly builds
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #19876:
URL: https://github.com/apache/flink/pull/19876#discussion_r893207290
##########
flink-connectors/flink-connector-hive/pom.xml:
##########
@@ -1024,9 +1024,25 @@ under the License.
<profiles>
<!-- Activate these profiles with -Phive-x.x.x to build and test against different Hive versions -->
<profile>
- <id>hive-3.1.1</id>
+ <id>hive-3.1.2</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <configuration>
+ <!-- disable running test in parallel for hive 3.1.2, otherwise, there'll be some concurrency issues -->
Review Comment:
This is not an issue with concurrency. It fails when multiple hive tests are run sequentially within the same JVM (so it's an issue related to forkReuse). This implies something isn't being cleaned up properly when the test exits; and a subsequent test picks up the empty database.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #19876: [FLINK-27895][hive][build] Enable test for Hive 3.x in nightly builds
Posted by GitBox <gi...@apache.org>.
zentol merged PR #19876:
URL: https://github.com/apache/flink/pull/19876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on pull request #19876: [FLINK-27895][build] Enable the CI test for Hive 3.1.2
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on PR #19876:
URL: https://github.com/apache/flink/pull/19876#issuecomment-1148102825
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #19876: [FLINK-27895][hive][build] Enable test for Hive 3.x in nightly builds
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #19876:
URL: https://github.com/apache/flink/pull/19876#discussion_r894602361
##########
flink-connectors/flink-connector-hive/pom.xml:
##########
@@ -1024,9 +1024,25 @@ under the License.
<profiles>
<!-- Activate these profiles with -Phive-x.x.x to build and test against different Hive versions -->
<profile>
- <id>hive-3.1.1</id>
+ <id>hive-3.1.2</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <configuration>
+ <!-- disable running test in parallel for hive 3.1.2, otherwise, there'll be some concurrency issues -->
Review Comment:
Perfect, thanks for looking into it 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on pull request #19876: [FLINK-27895][hive][build] Enable test for Hive 3.x in nightly builds
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on PR #19876:
URL: https://github.com/apache/flink/pull/19876#issuecomment-1153038068
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #19876: [FLINK-27895][build] Enable the CI test for Hive 3.1.2
Posted by GitBox <gi...@apache.org>.
zentol commented on PR #19876:
URL: https://github.com/apache/flink/pull/19876#issuecomment-1148521489
Hive already consumes a fair bit of CI time, so I'm not really keen on _adding_ another run of those tests.
Would it work for you to have this setup in one of the cron jobs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19876: [FLINK-27895][build] Enable the CI test for Hive's 3.x
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19876:
URL: https://github.com/apache/flink/pull/19876#issuecomment-1146539680
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "15425334700214c0c4822f0b8c37e15eacc8fe7b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "15425334700214c0c4822f0b8c37e15eacc8fe7b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 15425334700214c0c4822f0b8c37e15eacc8fe7b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on pull request #19876: [FLINK-27895][build] Enable the CI test for Hive 3.1.2
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on PR #19876:
URL: https://github.com/apache/flink/pull/19876#issuecomment-1146980941
@zentol Could you please help review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on a diff in pull request #19876: [FLINK-27895][hive][build] Enable test for Hive 3.x in nightly builds
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on code in PR #19876:
URL: https://github.com/apache/flink/pull/19876#discussion_r892156919
##########
flink-connectors/flink-connector-hive/pom.xml:
##########
@@ -1024,9 +1024,25 @@ under the License.
<profiles>
<!-- Activate these profiles with -Phive-x.x.x to build and test against different Hive versions -->
<profile>
- <id>hive-3.1.1</id>
+ <id>hive-3.1.2</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <configuration>
+ <!-- disable running test in parallel for hive 3.1.2, otherwise, there'll be some concurrency issues -->
+ <forkCount>1</forkCount>
+ <reuseForks>false</reuseForks>
+ <systemPropertyVariables>
+ <derby.stream.error.file>${project.build.directory}/derby.log</derby.stream.error.file>
+ </systemPropertyVariables>
+ </configuration>
+ </plugin>
+ </plugins>
+ </build>
<properties>
- <hive.version>3.1.1</hive.version>
+ <hive.version>3.1.2</hive.version>
Review Comment:
Yes, I agree. That should be a separate change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #19876: [FLINK-27895][hive][build] Enable test for Hive 3.x in nightly builds
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #19876:
URL: https://github.com/apache/flink/pull/19876#discussion_r893205666
##########
flink-connectors/flink-connector-hive/pom.xml:
##########
@@ -1024,9 +1024,25 @@ under the License.
<profiles>
<!-- Activate these profiles with -Phive-x.x.x to build and test against different Hive versions -->
<profile>
- <id>hive-3.1.1</id>
+ <id>hive-3.1.2</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <configuration>
+ <!-- disable running test in parallel for hive 3.1.2, otherwise, there'll be some concurrency issues -->
+ <forkCount>1</forkCount>
+ <reuseForks>false</reuseForks>
Review Comment:
The reuseForks setting does apply to unit tests, but the forkCount is genuinely ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #19876: [FLINK-27895][hive][build] Enable test for Hive 3.x in nightly builds
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #19876:
URL: https://github.com/apache/flink/pull/19876#discussion_r892348919
##########
flink-connectors/flink-connector-hive/pom.xml:
##########
@@ -1024,9 +1024,25 @@ under the License.
<profiles>
<!-- Activate these profiles with -Phive-x.x.x to build and test against different Hive versions -->
<profile>
- <id>hive-3.1.1</id>
+ <id>hive-3.1.2</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <configuration>
+ <!-- disable running test in parallel for hive 3.1.2, otherwise, there'll be some concurrency issues -->
Review Comment:
It would be good to figure out what the underlying issue is.
Because given that the tests do not run concurrently within a single JVM I would have to conclude that they share some data on disk, which is a terrible idea to start with.
We just spent quite some effort to get things to run with multiple JVMs and re-using forks; we are not throwing that away for Hive 3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #19876: [FLINK-27895][hive][build] Enable test for Hive 3.x in nightly builds
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #19876:
URL: https://github.com/apache/flink/pull/19876#discussion_r893207290
##########
flink-connectors/flink-connector-hive/pom.xml:
##########
@@ -1024,9 +1024,25 @@ under the License.
<profiles>
<!-- Activate these profiles with -Phive-x.x.x to build and test against different Hive versions -->
<profile>
- <id>hive-3.1.1</id>
+ <id>hive-3.1.2</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <configuration>
+ <!-- disable running test in parallel for hive 3.1.2, otherwise, there'll be some concurrency issues -->
Review Comment:
This is not an issue with concurrency. It fails when multiple hive tests are run sequentially within the same JVM. This implies something isn't being cleaned up properly when the test exits; and a subsequent test picks up the empty database.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on a diff in pull request #19876: [FLINK-27895][hive][build] Enable test for Hive 3.x in nightly builds
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on code in PR #19876:
URL: https://github.com/apache/flink/pull/19876#discussion_r894388314
##########
flink-connectors/flink-connector-hive/pom.xml:
##########
@@ -1024,9 +1024,25 @@ under the License.
<profiles>
<!-- Activate these profiles with -Phive-x.x.x to build and test against different Hive versions -->
<profile>
- <id>hive-3.1.1</id>
+ <id>hive-3.1.2</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <configuration>
+ <!-- disable running test in parallel for hive 3.1.2, otherwise, there'll be some concurrency issues -->
Review Comment:
@zentol Thanks very much for your detail explaination and sorry for my misleading. After spending some time debuging, I found the root cause. Put it simply, the reason is some test modify a static variable, and then boil the other test.
More detail is in [FLINK-27999](https://issues.apache.org/jira/browse/FLINK-27999). I'll fix [FLINK-27999](https://issues.apache.org/jira/browse/FLINK-27999) firstly. After it merges, I think we revisit this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on pull request #19876: [FLINK-27895][hive][build] Enable test for Hive 3.x in nightly builds
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on PR #19876:
URL: https://github.com/apache/flink/pull/19876#issuecomment-1152896621
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org