You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/30 20:23:29 UTC
[GitHub] [airflow] osule opened a new pull request #7298: Fix syntax error
constructing list of process ids
osule opened a new pull request #7298: Fix syntax error constructing list of process ids
URL: https://github.com/apache/airflow/pull/7298
Construction of list of pids passed in kill command raises a Syntax error because
ordering of the arguments to `map` function doesn't conform to function
parameter definition.
A list comprehension replaces the existing `map` function to make the code
forward compatible with Python 3 and at the same time expand to a list of pids.
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] ~Unit tests coverage for changes (not needed for documentation changes)~
- [x] ~Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"~
- [x] ~Relevant documentation is updated including usage instructions.~
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #7298: [AIRFLOW-6686] Fix
syntax error constructing list of process ids
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #7298: [AIRFLOW-6686] Fix syntax error constructing list of process ids
URL: https://github.com/apache/airflow/pull/7298#issuecomment-580522543
Travis is sad. I restarted failed jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj merged pull request #7298: [AIRFLOW-6686] Fix
syntax error constructing list of process ids
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #7298: [AIRFLOW-6686] Fix syntax error constructing list of process ids
URL: https://github.com/apache/airflow/pull/7298
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7298: [AIRFLOW-6686] Fix
syntax error constructing list of process ids
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7298: [AIRFLOW-6686] Fix syntax error constructing list of process ids
URL: https://github.com/apache/airflow/pull/7298#issuecomment-580653289
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7298?src=pr&el=h1) Report
> Merging [#7298](https://codecov.io/gh/apache/airflow/pull/7298?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/83c037873ff694eed67ba8b30f2d9c88b2c7c6f2?src=pr&el=desc) will **increase** coverage by `1.74%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7298?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7298 +/- ##
==========================================
+ Coverage 83.85% 85.59% +1.74%
==========================================
Files 863 863
Lines 40488 40509 +21
==========================================
+ Hits 33951 34675 +724
+ Misses 6537 5834 -703
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7298?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/7298/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `82.5% <ø> (ø)` | :arrow_up: |
| [...w/providers/apache/hive/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7298/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL215c3FsX3RvX2hpdmUucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/security/kerberos.py](https://codecov.io/gh/apache/airflow/pull/7298/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZWN1cml0eS9rZXJiZXJvcy5weQ==) | `30.43% <0%> (-45.66%)` | :arrow_down: |
| [airflow/providers/mysql/operators/mysql.py](https://codecov.io/gh/apache/airflow/pull/7298/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbXlzcWwvb3BlcmF0b3JzL215c3FsLnB5) | `55% <0%> (-45%)` | :arrow_down: |
| [...irflow/example\_dags/example\_kubernetes\_executor.py](https://codecov.io/gh/apache/airflow/pull/7298/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9rdWJlcm5ldGVzX2V4ZWN1dG9yLnB5) | `50% <0%> (-30.96%)` | :arrow_down: |
| [...example\_dags/example\_kubernetes\_executor\_config.py](https://codecov.io/gh/apache/airflow/pull/7298/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9rdWJlcm5ldGVzX2V4ZWN1dG9yX2NvbmZpZy5weQ==) | `44.82% <0%> (-23.6%)` | :arrow_down: |
| [airflow/providers/apache/hive/hooks/hive.py](https://codecov.io/gh/apache/airflow/pull/7298/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvaG9va3MvaGl2ZS5weQ==) | `76.02% <0%> (-1.54%)` | :arrow_down: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7298/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `76.44% <0%> (-0.97%)` | :arrow_down: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7298/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `90.9% <0%> (-0.83%)` | :arrow_down: |
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7298/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `89.19% <0%> (-0.15%)` | :arrow_down: |
| ... and [241 more](https://codecov.io/gh/apache/airflow/pull/7298/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7298?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7298?src=pr&el=footer). Last update [83c0378...d688126](https://codecov.io/gh/apache/airflow/pull/7298?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services