[GitHub] [netbeans-mavenutils-archetypes] asbachb commented on a diff in pull request #2: Created a maven-archetype which is able to generate a web application…

["asbachb (via GitHub)" <gi...@apache.org>]

asbachb commented on code in PR #2:
URL: https://github.com/apache/netbeans-mavenutils-archetypes/pull/2#discussion_r1211819443


##########
netbeans-jakartaee-war-archetype/src/main/resources/archetype-resources/pom.xml:
##########
@@ -0,0 +1,41 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" 
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <modelVersion>4.0.0</modelVersion>
+
+    <groupId>${groupId}</groupId>
+    <artifactId>${artifactId}</artifactId>
+    <version>${version}</version>
+    <packaging>war</packaging>
+
+    <properties>
+        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+        <maven.compiler.source>${javaVersion}</maven.compiler.source>
+        <maven.compiler.target>${javaVersion}</maven.compiler.target>

Review Comment:
   I implemented a prototype where this is adjusted in the post project creation groovy script:  https://github.com/asbachb/netbeans-mavenutils-archetypes/blob/master/netbeans-jakartaee-war-archetype/src/main/resources/META-INF/archetype-post-generate.groovy#L10-L21
   
   Not 100% if I like it, but it works.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists