You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2020/01/10 05:24:45 UTC
[GitHub] [libcloud] Kami opened a new pull request #1406: Skip object
checksum check on upload if server side AWS KMS encryption is used
Kami opened a new pull request #1406: Skip object checksum check on upload if server side AWS KMS encryption is used
URL: https://github.com/apache/libcloud/pull/1406
This pull request updates S3 driver code to skip uploaded object checksum check at the end of the upload when server side AWS KMS encryption is used for that object.
In such scenario, ETag header value doesn't contain object data MD5 digest.
As part of that change I also noticed some of the tests were out of date and some of the mock http methods are not needed anymore so I did some cleanup. That likely happened during the requests migration.
Resolves #1401.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] Kami merged pull request #1406: Skip object checksum
check on upload if server side AWS KMS encryption is used
Posted by GitBox <gi...@apache.org>.
Kami merged pull request #1406: Skip object checksum check on upload if server side AWS KMS encryption is used
URL: https://github.com/apache/libcloud/pull/1406
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] codecov-io commented on issue #1406: Skip object
checksum check on upload if server side AWS KMS encryption is used
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1406: Skip object checksum check on upload if server side AWS KMS encryption is used
URL: https://github.com/apache/libcloud/pull/1406#issuecomment-572884460
# [Codecov](https://codecov.io/gh/apache/libcloud/pull/1406?src=pr&el=h1) Report
> Merging [#1406](https://codecov.io/gh/apache/libcloud/pull/1406?src=pr&el=desc) into [trunk](https://codecov.io/gh/apache/libcloud/commit/435d82b89665c265b76744760152059f713e3b3c?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/libcloud/pull/1406?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## trunk #1406 +/- ##
==========================================
+ Coverage 86.44% 86.46% +0.01%
==========================================
Files 366 366
Lines 76767 76773 +6
Branches 7529 7529
==========================================
+ Hits 66365 66378 +13
+ Misses 7534 7527 -7
Partials 2868 2868
```
| [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1406?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [libcloud/test/storage/test\_s3.py](https://codecov.io/gh/apache/libcloud/pull/1406/diff?src=pr&el=tree#diff-bGliY2xvdWQvdGVzdC9zdG9yYWdlL3Rlc3RfczMucHk=) | `92.77% <100%> (+1.3%)` | :arrow_up: |
| [libcloud/storage/drivers/s3.py](https://codecov.io/gh/apache/libcloud/pull/1406/diff?src=pr&el=tree#diff-bGliY2xvdWQvc3RvcmFnZS9kcml2ZXJzL3MzLnB5) | `89.34% <100%> (+0.06%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1406?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1406?src=pr&el=footer). Last update [435d82b...8bf5724](https://codecov.io/gh/apache/libcloud/pull/1406?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services