[jira] [Commented] (GEODE-4092) New protocol does not have an API to get the best server to connect to

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16306489#comment-16306489 ] 

ASF GitHub Bot commented on GEODE-4092:
---------------------------------------

bschuchardt opened a new pull request #1210: GEODE-4092 New protocol does not have an API to get the best server t…
URL: https://github.com/apache/geode/pull/1210
 
 
   …o connect to
   
   GetAllAvailableServers has been replaced by GetServer.  The handler uses
   the ServerLocator's processRequest API to ensure we have the same
   functionality as existing non-protobuf locator request handling.
   
   If a server isn't found we are returning Success with a null server
   location.  Should this be changed to return an error code?
   
   @upthewaterspout @WireBaron @PivotalSarge @galen-pivotal 
   
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   - [x] Does `gradlew build` run cleanly?
   
   - [x] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> New protocol does not have an API to get the best server to connect to
> ----------------------------------------------------------------------
>
>                 Key: GEODE-4092
>                 URL: https://issues.apache.org/jira/browse/GEODE-4092
>             Project: Geode
>          Issue Type: Improvement
>          Components: client/server
>            Reporter: Dan Smith
>
> The new client protocol has a GetAvailableServersRequest. This returns all of the servers the locator knows about.
> Unfortunately, this does not allow the locator to load balance the clients. We should remove GetAvailableServers and only provide a GetServer request which directs the client to the best available server.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)