You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@opennlp.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/19 04:46:41 UTC
[jira] [Commented] (OPENNLP-958) Add a NameFinder feature generator
that works with POS Tags
[ https://issues.apache.org/jira/browse/OPENNLP-958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974062#comment-15974062 ]
ASF GitHub Bot commented on OPENNLP-958:
----------------------------------------
GitHub user wcolen opened a pull request:
https://github.com/apache/opennlp/pull/170
OPENNLP-958: [WIP] Add POS Name Finder feature generator
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
- [X] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wcolen/opennlp nfpos
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/opennlp/pull/170.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #170
----
commit ec82dd9c516ca54e18cd2bca0cb5d7b4b67a285d
Author: William D C M SILVA <co...@apache.org>
Date: 2017-01-24T21:12:09Z
starting the work
commit 184cd8d764677e3d5af919b11517c331ed5d24a5
Author: William D C M SILVA <co...@apache.org>
Date: 2017-01-25T02:55:41Z
starting the work
commit e4ada42dcbdf4c5808fd16a52973098e92c17e28
Author: William D C M SILVA <co...@apache.org>
Date: 2017-04-18T21:50:57Z
fix fg name
commit f5cda91bc0f08419c8355afd35a0990264c869fc
Author: William D C M SILVA <co...@apache.org>
Date: 2017-04-19T04:39:50Z
OPENNLP-958: fix resource manager and add TokenPOS FG
----
> Add a NameFinder feature generator that works with POS Tags
> -----------------------------------------------------------
>
> Key: OPENNLP-958
> URL: https://issues.apache.org/jira/browse/OPENNLP-958
> Project: OpenNLP
> Issue Type: Bug
> Components: Name Finder
> Affects Versions: 1.7.1
> Reporter: William Colen
> Assignee: William Colen
> Fix For: 1.8.0
>
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)