You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/03/03 03:50:43 UTC

[GitHub] [incubator-hudi] xushiyan commented on issue #1360: [HUDI-344][RFC-09] Hudi Dataset Snapshot Exporter

xushiyan commented on issue #1360: [HUDI-344][RFC-09] Hudi Dataset Snapshot Exporter
URL: https://github.com/apache/incubator-hudi/pull/1360#issuecomment-593753301
 
 
   @OpenOpened Thanks for the changes. I saw there are issues with existing Copier tests which need some further refactoring and fixing. 
   
   I'd like to set a realistic criteria for merging this PR: as we don't have to make the utility perfect in the first round so I'd give +1 as long as the functionality works in a basic manner: output can be generated, no worry in perf and fully covered in unit tests. In addition, putting an `@experimental` in the class docs and do not `@deprecate` the original Copier. Please kindly share your input. @leesf @vinothchandar thanks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services