You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by sjudeng <gi...@git.apache.org> on 2016/10/18 00:37:18 UTC
[GitHub] tinkerpop pull request #458: Message scope initialization in PeerPressureVer...
GitHub user sjudeng opened a pull request:
https://github.com/apache/tinkerpop/pull/458
Message scope initialization in PeerPressureVertexProgram
These updates resolve issues observed running tinkerpop-3.2.2 tests against Titan. Sorry if this should have been submitted through JIRA.
### Message scope initialization in PeerPressureTest
Failing test was `g_V_peerPressure_byXclusterX_byXoutEXknowsXX_pageRankX1X_byXrankX_byXoutEXknowsXX_timesX2X_group_byXclusterX_byXrank_sumX`
During test execution it was observed at the failing (vote) step that the message scope was `VertexStep(OUT,[knows],edge)`, but this didn't match the message scope, `VertexStep(OUT,edge)`, in the statically initialized set, `VOTE_SCOPE`, returned by `PeerPressureVertexProgram#getMessageScopes`. This caused an error in the custom memory implementation that is resolved by moving the initialization as shown in this PR.
### Vertex id checks in BulkDumperVertexProgramTest
Vertex id checks fail when implementation does not support user-specified ids
### Transaction rollback in TransactionTest
Implementation fails to rollback a transaction that is already closed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ngageoint/tinkerpop tp32-tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/458.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #458
----
commit 531e62c3302fec092fa7e10d5c87b96e8eb4f4a6
Author: sjudeng <sj...@users.noreply.github.com>
Date: 2016-10-18T00:02:46Z
Lazy message scope initialization in PeerPressureVertexProgram. Remove vertex id checks in BulkDumperVertexProgramTest. Don't rollback transaction if already closed in TransactionTest.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #458: Message scope initialization in PeerPressureVertexProg...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/458
Ahhhhhhhh! Interesting. This has been a thorn in our side for some time.
VOTE +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #458: Message scope initialization in PeerPressureVertexProg...
Posted by sjudeng <gi...@git.apache.org>.
Github user sjudeng commented on the issue:
https://github.com/apache/tinkerpop/pull/458
Should be good now. I first tried to do this by reapplying the commit on tp32 before I realized I needed to edit the PR itself.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #458: Message scope initialization in PeerPressureVer...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/458
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #458: Message scope initialization in PeerPressureVertexProg...
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/458
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #458: Message scope initialization in PeerPressureVertexProg...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/458
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #458: Message scope initialization in PeerPressureVertexProg...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/458
@sjudeng do you mind re-targeting this pull request to the tp32 branch? In that way it will get fixed along the 3.2.x line of code. we can merge forward to master on our end so that is available on 3.3.x as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---