[GitHub] [skywalking] wu-sheng commented on a change in pull request #7399: Support Metric level function `serviceRelation` in `MAL` and binding envoy metrics into the topology.

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #7399:
URL: https://github.com/apache/skywalking/pull/7399#discussion_r683449641



##########
File path: docs/en/concepts-and-designs/mal.md
##########
@@ -236,14 +236,17 @@ last_server_state_sync_time_in_seconds.tagEqual('production', 'catalog').downsam
 
 ## Metric level function
 
-There are three levels in metric: service, instance and endpoint. They extract level relevant labels from metric labels, then informs the meter-system the level to which this metric belongs.
+They extract level relevant labels from metric labels, then informs the meter-system the level to which this metric belongs.
 
  - `servcie([svc_label1, svc_label2...])` extracts service level labels from the array argument.
  - `instance([svc_label1, svc_label2...], [ins_label1, ins_label2...])` extracts service level labels from the first array argument, 
                                                                         extracts instance level labels from the second array argument.
  - `endpoint([svc_label1, svc_label2...], [ep_label1, ep_label2...])` extracts service level labels from the first array argument, 
                                                                       extracts endpoint level labels from the second array argument.
-
+ - `serviceRelation(DetectPoint, [svc_label1...], [related_svc_label1...])` DetectPoint including `DetectPoint.CLIENT` and `DetectPoint.SERVER`, 
+   extracts `service` labels from the first array argument, extracts `related service` labels from the second array argument.
+   If `DetectPoint.CLIENT` the `related service` is upstream of the `service`.
+   If `DetectPoint.SERVER` the `related service` is downstream of the `service`.

Review comment:
       Agree, I think using the consistent order `[source], [target]` makes more sense, and easier to read.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org