You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/09/26 20:01:39 UTC
Review Request: Added some tests for the ZooKeeper based master detector.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7292/
-----------------------------------------------------------
Review request for mesos, John Sirois, Vinod Kone, and Ben Mahler.
Description
-------
See summary (4 of 7).
Diffs
-----
src/tests/zookeeper_tests.cpp 2e04069
Diff: https://reviews.apache.org/r/7292/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: Added some tests for the ZooKeeper based master detector.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Sept. 26, 2012, 8:28 p.m., Vinod Kone wrote:
> > src/tests/zookeeper_tests.cpp, line 180
> > <https://reviews.apache.org/r/7292/diff/1/?file=160212#file160212line180>
> >
> > am I blind or is there a diff here?
I'll pretend that didn't happen. ;)
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7292/#review11941
-----------------------------------------------------------
On Sept. 26, 2012, 6:01 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7292/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2012, 6:01 p.m.)
>
>
> Review request for mesos, John Sirois, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> See summary (4 of 7).
>
>
> Diffs
> -----
>
> src/tests/zookeeper_tests.cpp 2e04069
>
> Diff: https://reviews.apache.org/r/7292/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Added some tests for the ZooKeeper based master detector.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7292/#review11941
-----------------------------------------------------------
Ship it!
src/tests/zookeeper_tests.cpp
<https://reviews.apache.org/r/7292/#comment25476>
am I blind or is there a diff here?
- Vinod Kone
On Sept. 26, 2012, 6:01 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7292/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2012, 6:01 p.m.)
>
>
> Review request for mesos, John Sirois, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> See summary (4 of 7).
>
>
> Diffs
> -----
>
> src/tests/zookeeper_tests.cpp 2e04069
>
> Diff: https://reviews.apache.org/r/7292/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Added some tests for the ZooKeeper based master detector.
Posted by John Sirois <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7292/#review11953
-----------------------------------------------------------
Ship it!
Ship It!
- John Sirois
On Sept. 26, 2012, 6:01 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7292/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2012, 6:01 p.m.)
>
>
> Review request for mesos, John Sirois, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> See summary (4 of 7).
>
>
> Diffs
> -----
>
> src/tests/zookeeper_tests.cpp 2e04069
>
> Diff: https://reviews.apache.org/r/7292/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Added some tests for the ZooKeeper based master detector.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7292/#review11999
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Sept. 26, 2012, 6:01 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7292/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2012, 6:01 p.m.)
>
>
> Review request for mesos, John Sirois, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> See summary (4 of 7).
>
>
> Diffs
> -----
>
> src/tests/zookeeper_tests.cpp 2e04069
>
> Diff: https://reviews.apache.org/r/7292/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>