You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2014/07/16 17:23:28 UTC

[GitHub] incubator-brooklyn pull request: membership tracking policy defaul...

GitHub user aledsage opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/73

    membership tracking policy default to no duplicates

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/incubator-brooklyn fix/MembershipTrackingPolicy-default-to-no-duplicates

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/73.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #73
    
----
commit e832afb3959f7f7e0226a128bf0a26ade0d8cff7
Author: Aled Sage <al...@gmail.com>
Date:   2014-07-16T14:34:03Z

    MembershipTrackingPolicy: default to not notifying of duplicates

commit 18f633f3921b92754663bf5c5f8cf34ec1911ac9
Author: Aled Sage <al...@gmail.com>
Date:   2014-07-16T14:35:36Z

    White space tidies

commit 12141c762452b35bbe10bfb451fb70262835e929
Author: Aled Sage <al...@gmail.com>
Date:   2014-07-16T14:35:59Z

    Fix SshFeedIntegrationTest.testDynamicEnvAndCommandSupplier

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: membership tracking policy defaul...

Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/73#issuecomment-49203692
  
    This is a sensible change. Have verified tests pass. No other comments, happy for it to be merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: membership tracking policy defaul...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/73


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: membership tracking policy defaul...

Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/73#issuecomment-49278059
  
    Merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: membership tracking policy defaul...

Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/73#issuecomment-49182163
  
    Background for this change... originally the AbstractMembershipTrackingPolicy was not configurable. It would not notify of duplicates for serviceUp, but would for other attributes.
    
    This was changed a while back so it was configurable, but trying to preserve original behaviour. However, there was a bug: serviceUp duplicates were being sent through, resulting in 1000s of effector calls in some entities trying to respond to the change!
    
    Given the event is "entityChanged" it makes sense for the default to be false. For places where it is important to get the duplicate (e.g. where timestamps are important for recording workload etc) then one can configure the policy accordingly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---