You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "endrinmusa (via GitHub)" <gi...@apache.org> on 2023/07/20 22:55:09 UTC
[GitHub] [superset] endrinmusa opened a new pull request, #23919: fix(celery worker): install unzip & wget
endrinmusa opened a new pull request, #23919:
URL: https://github.com/apache/superset/pull/23919
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
I stumbled upon this issue that the worker was not able to install chrome and chromedriver because wget and unzip were missing. So adding them during worker init will fix the issue.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
Before adding:
After adding:
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
Simply try to init the worker with Kubernetes config, with apt install unzip wget -y added to the command: part.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(celery worker): install unzip & wget [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on PR #23919:
URL: https://github.com/apache/superset/pull/23919#issuecomment-2668782936
hi @endrinmusa, I'll be closing this one off as the proposed packages have been [added](https://github.com/apache/superset/blame/master/docs/docs/installation/kubernetes.mdx#L327-L331) in the latest `master` branch. Thank you for your contributing effort!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(celery worker): install unzip & wget [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #23919:
URL: https://github.com/apache/superset/pull/23919#issuecomment-2299310711
Just needs a bit of a rebase, otherwise... sorry this didn't get attention sooner! We're trying to get better about keeping PRs on track.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(celery worker): install unzip & wget [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on PR #23919:
URL: https://github.com/apache/superset/pull/23919#issuecomment-2299372986
Some people really like having super lean images for production, bloating images has impact on speed of autoscaling/deploys/... It feels we should layer this in a dev or fat image if at all. Seems unzip/wget would support in-docker troubleshooting/debugging, but why can't you just `apt-get` while in the image? Also realizing we have a fair amount of Dockerfile-type content in docs which seems off, that stuff should be in actual Dockerfiles and layered properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(celery worker): install unzip & wget [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber closed pull request #23919: fix(celery worker): install unzip & wget
URL: https://github.com/apache/superset/pull/23919
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina closed pull request #23919: fix(celery worker): install unzip & wget
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina closed pull request #23919: fix(celery worker): install unzip & wget
URL: https://github.com/apache/superset/pull/23919
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org