You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/01/24 01:57:57 UTC
[GitHub] [mynewt-core] vrahane opened a new pull request #2164: flash_test:
fix resource leak on error
vrahane opened a new pull request #2164: flash_test: fix resource leak on error
URL: https://github.com/apache/mynewt-core/pull/2164
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2164:
flash_test: fix resource leak on error
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #2164: flash_test: fix resource leak on error
URL: https://github.com/apache/mynewt-core/pull/2164#issuecomment-577960766
<!-- style-bot -->
## Style check summary
#### test/flash_test/src/flash_test.c
<details>
```diff
@@ -290,7 +291,7 @@
if (i == 0) {
streamer_printf(streamer,
"Speed test, hal_flash_read(%d, 0x%x%s, %d)\n",
- flash_dev, (unsigned int)addr, move?"..":"", (unsigned int)sz);
+ flash_dev, (unsigned int)addr, move ? ".." : "", (unsigned int)sz);
cnt = flash_speed_test(flash_dev, addr, sz, move);
streamer_printf(streamer, "%d\n", cnt >> 1);
} else {
@@ -300,7 +301,7 @@
streamer_printf(streamer,
"Speed test, hal_flash_read(%d, 0x%x%s, X)\n",
- flash_dev, (unsigned int)addr, move?"..":"");
+ flash_dev, (unsigned int)addr, move ? ".." : "");
for (i = 0; i < sizeof(sizes) / sizeof(sizes[0]); i++) {
cnt = flash_speed_test(flash_dev, addr, sizes[i], move);
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-core] vrahane merged pull request #2164: flash_test: fix
resource leak on error
Posted by GitBox <gi...@apache.org>.
vrahane merged pull request #2164: flash_test: fix resource leak on error
URL: https://github.com/apache/mynewt-core/pull/2164
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services