You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "kezhenxu94 (GitHub)" <gi...@apache.org> on 2019/02/14 10:29:57 UTC

[GitHub] [incubator-dubbo-ops] kezhenxu94 opened pull request #304: Cleanup

Optimizations and cleanup:
- replace local constants with global constants
- remove unnecessary declarations
- create adapter for util method

[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/304 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] codecov-io commented on issue #304: Cleanup

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/304?src=pr&el=h1) Report
> Merging [#304](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/304?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-ops/commit/45c0d4181eebfeed656e8c8f695e78bdee4a2762?src=pr&el=desc) will **increase** coverage by `0.26%`.
> The diff coverage is `1.88%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/304/graphs/tree.svg?width=650&token=fYsc8RuDGB&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/304?src=pr&el=tree)

```diff
@@              Coverage Diff              @@
##             develop     #304      +/-   ##
=============================================
+ Coverage      19.38%   19.65%   +0.26%     
  Complexity       289      289              
=============================================
  Files             91       95       +4     
  Lines           3637     3582      -55     
  Branches         566      553      -13     
=============================================
- Hits             705      704       -1     
+ Misses          2857     2803      -54     
  Partials          75       75
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/304?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apache/dubbo/admin/common/util/OverrideUtils.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/304/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9hZG1pbi9jb21tb24vdXRpbC9PdmVycmlkZVV0aWxzLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...e/dubbo/admin/service/impl/GenericServiceImpl.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/304/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9hZG1pbi9zZXJ2aWNlL2ltcGwvR2VuZXJpY1NlcnZpY2VJbXBsLmphdmE=) | `76.92% <ø> (+18.09%)` | `2 <0> (ø)` | :arrow_down: |
| [.../dubbo/admin/controller/LoadBalanceController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/304/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9hZG1pbi9jb250cm9sbGVyL0xvYWRCYWxhbmNlQ29udHJvbGxlci5qYXZh) | `84.21% <ø> (ø)` | `14 <0> (ø)` | :arrow_down: |
| [...che/dubbo/admin/controller/AccessesController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/304/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9hZG1pbi9jb250cm9sbGVyL0FjY2Vzc2VzQ29udHJvbGxlci5qYXZh) | `88.88% <ø> (ø)` | `14 <0> (ø)` | :arrow_down: |
| [.../dubbo/admin/service/impl/OverrideServiceImpl.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/304/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9hZG1pbi9zZXJ2aWNlL2ltcGwvT3ZlcnJpZGVTZXJ2aWNlSW1wbC5qYXZh) | `0.57% <0%> (ø)` | `1 <0> (ø)` | :arrow_down: |
| [...el/adapter/BalancingDTO2OverrideConfigAdapter.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/304/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9hZG1pbi9tb2RlbC9hZGFwdGVyL0JhbGFuY2luZ0RUTzJPdmVycmlkZUNvbmZpZ0FkYXB0ZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...o/admin/model/adapter/WeightToOverrideAdapter.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/304/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9hZG1pbi9tb2RlbC9hZGFwdGVyL1dlaWdodFRvT3ZlcnJpZGVBZGFwdGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...min/model/adapter/LoadBalance2OverrideAdapter.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/304/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9hZG1pbi9tb2RlbC9hZGFwdGVyL0xvYWRCYWxhbmNlMk92ZXJyaWRlQWRhcHRlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...l/adapter/DynamicConfigDTO2OverrideDTOAdapter.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/304/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9hZG1pbi9tb2RlbC9hZGFwdGVyL0R5bmFtaWNDb25maWdEVE8yT3ZlcnJpZGVEVE9BZGFwdGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [.../org/apache/dubbo/admin/DubboAdminApplication.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/304/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9hZG1pbi9EdWJib0FkbWluQXBwbGljYXRpb24uamF2YQ==) | `33.33% <0%> (ø)` | `1 <0> (ø)` | :arrow_down: |
| ... and [5 more](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/304/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/304?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/304?src=pr&el=footer). Last update [45c0d41...475830e](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/304?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/304 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] nzomkxia closed pull request #304: Cleanup

Posted by "nzomkxia (GitHub)" <gi...@apache.org>.
[ pull request closed by nzomkxia ]

[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/304 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] codecov-io commented on issue #304: Cleanup

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/304?src=pr&el=h1) Report
> Merging [#304](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/304?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-ops/commit/45c0d4181eebfeed656e8c8f695e78bdee4a2762?src=pr&el=desc) will **increase** coverage by `0.24%`.
> The diff coverage is `1.88%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/304/graphs/tree.svg?width=650&token=fYsc8RuDGB&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/304?src=pr&el=tree)

```diff
@@              Coverage Diff              @@
##             develop     #304      +/-   ##
=============================================
+ Coverage      19.38%   19.63%   +0.24%     
+ Complexity       289      288       -1     
=============================================
  Files             91       95       +4     
  Lines           3637     3586      -51     
  Branches         566      553      -13     
=============================================
- Hits             705      704       -1     
+ Misses          2857     2807      -50     
  Partials          75       75
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/304?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../dubbo/admin/controller/LoadBalanceController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/304/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9hZG1pbi9jb250cm9sbGVyL0xvYWRCYWxhbmNlQ29udHJvbGxlci5qYXZh) | `84.21% <ø> (ø)` | `14 <0> (ø)` | :arrow_down: |
| [.../apache/dubbo/admin/common/util/OverrideUtils.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/304/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9hZG1pbi9jb21tb24vdXRpbC9PdmVycmlkZVV0aWxzLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...che/dubbo/admin/controller/AccessesController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/304/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9hZG1pbi9jb250cm9sbGVyL0FjY2Vzc2VzQ29udHJvbGxlci5qYXZh) | `88.88% <ø> (ø)` | `14 <0> (ø)` | :arrow_down: |
| [...o/admin/model/adapter/WeightToOverrideAdapter.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/304/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9hZG1pbi9tb2RlbC9hZGFwdGVyL1dlaWdodFRvT3ZlcnJpZGVBZGFwdGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [.../org/apache/dubbo/admin/DubboAdminApplication.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/304/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9hZG1pbi9EdWJib0FkbWluQXBwbGljYXRpb24uamF2YQ==) | `33.33% <0%> (ø)` | `1 <0> (ø)` | :arrow_down: |
| [.../dubbo/admin/service/impl/OverrideServiceImpl.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/304/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9hZG1pbi9zZXJ2aWNlL2ltcGwvT3ZlcnJpZGVTZXJ2aWNlSW1wbC5qYXZh) | `0.57% <0%> (ø)` | `1 <0> (ø)` | :arrow_down: |
| [...el/adapter/BalancingDTO2OverrideConfigAdapter.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/304/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9hZG1pbi9tb2RlbC9hZGFwdGVyL0JhbGFuY2luZ0RUTzJPdmVycmlkZUNvbmZpZ0FkYXB0ZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...min/model/adapter/LoadBalance2OverrideAdapter.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/304/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9hZG1pbi9tb2RlbC9hZGFwdGVyL0xvYWRCYWxhbmNlMk92ZXJyaWRlQWRhcHRlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...l/adapter/DynamicConfigDTO2OverrideDTOAdapter.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/304/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9hZG1pbi9tb2RlbC9hZGFwdGVyL0R5bmFtaWNDb25maWdEVE8yT3ZlcnJpZGVEVE9BZGFwdGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...va/org/apache/dubbo/admin/config/ConfigCenter.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/304/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9hZG1pbi9jb25maWcvQ29uZmlnQ2VudGVyLmphdmE=) | `92.3% <100%> (-0.15%)` | `17 <0> (ø)` | |
| ... and [4 more](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/304/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/304?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/304?src=pr&el=footer). Last update [45c0d41...df0439c](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/304?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/304 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org