You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chi Zhang <ch...@gmail.com> on 2015/09/25 20:58:06 UTC

Review Request 38770: routing: fixed a file descriptor leak.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38770/
-----------------------------------------------------------

Review request for mesos, Ben Mahler, Jie Yu, and Cong Wang.


Repository: mesos


Description
-------

routing: fixed a file descriptor leak.


Diffs
-----

  src/linux/routing/link/link.cpp 552e2d76a6f7d2ffc366a65957d0ac849b504b2e 

Diff: https://reviews.apache.org/r/38770/diff/


Testing
-------


Thanks,

Chi Zhang

Re: Review Request 38770: routing: fixed a file descriptor leak.

Posted by Cong Wang <cw...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38770/#review100661
-----------------------------------------------------------

Ship it!


Or you can do unconditionally os::close() after that ioctl() to save a few code... but this is very minor.

- Cong Wang


On Sept. 25, 2015, 7:07 p.m., Chi Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38770/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2015, 7:07 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, and Cong Wang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> routing: fixed a file descriptor leak.
> 
> 
> Diffs
> -----
> 
>   src/linux/routing/link/link.cpp 552e2d76a6f7d2ffc366a65957d0ac849b504b2e 
> 
> Diff: https://reviews.apache.org/r/38770/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Re: Review Request 38770: routing: fixed a file descriptor leak.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38770/#review100675
-----------------------------------------------------------


Patch looks great!

Reviews applied: [38770]

All tests passed.

- Mesos ReviewBot


On Sept. 25, 2015, 7:07 p.m., Chi Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38770/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2015, 7:07 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, and Cong Wang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> routing: fixed a file descriptor leak.
> 
> 
> Diffs
> -----
> 
>   src/linux/routing/link/link.cpp 552e2d76a6f7d2ffc366a65957d0ac849b504b2e 
> 
> Diff: https://reviews.apache.org/r/38770/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Re: Review Request 38770: routing: fixed a file descriptor leak.

Posted by Chi Zhang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38770/
-----------------------------------------------------------

(Updated Sept. 25, 2015, 8:33 p.m.)


Review request for mesos, Ben Mahler, Jie Yu, and Cong Wang.


Bugs: MESOS-3519
    https://issues.apache.org/jira/browse/MESOS-3519


Repository: mesos


Description
-------

routing: fixed a file descriptor leak.


Diffs
-----

  src/linux/routing/link/link.cpp 552e2d76a6f7d2ffc366a65957d0ac849b504b2e 

Diff: https://reviews.apache.org/r/38770/diff/


Testing
-------

make check


Thanks,

Chi Zhang

Re: Review Request 38770: routing: fixed a file descriptor leak.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38770/#review100670
-----------------------------------------------------------

Ship it!


Thanks! Would you mind tracking these under a ticket to clean up all the leaks we've found? Also, would love to see a ticket for a reference-counted FileDescriptor.

- Ben Mahler


On Sept. 25, 2015, 7:07 p.m., Chi Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38770/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2015, 7:07 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, and Cong Wang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> routing: fixed a file descriptor leak.
> 
> 
> Diffs
> -----
> 
>   src/linux/routing/link/link.cpp 552e2d76a6f7d2ffc366a65957d0ac849b504b2e 
> 
> Diff: https://reviews.apache.org/r/38770/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Re: Review Request 38770: routing: fixed a file descriptor leak.

Posted by Chi Zhang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38770/
-----------------------------------------------------------

(Updated Sept. 25, 2015, 7:07 p.m.)


Review request for mesos, Ben Mahler, Jie Yu, and Cong Wang.


Repository: mesos


Description
-------

routing: fixed a file descriptor leak.


Diffs
-----

  src/linux/routing/link/link.cpp 552e2d76a6f7d2ffc366a65957d0ac849b504b2e 

Diff: https://reviews.apache.org/r/38770/diff/


Testing (updated)
-------

make check


Thanks,

Chi Zhang