You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/12/07 22:25:16 UTC

[GitHub] [maven-site] slawekjaranowski opened a new pull request, #351: Using an SPDX identifier as the license name in example

slawekjaranowski opened a new pull request, #351:
URL: https://github.com/apache/maven-site/pull/351

   According to recommendation a few lines below


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-site] slawekjaranowski merged pull request #351: Using an SPDX identifier as the license name in example

Posted by GitBox <gi...@apache.org>.
slawekjaranowski merged PR #351:
URL: https://github.com/apache/maven-site/pull/351


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-site] michael-o commented on pull request #351: Using an SPDX identifier as the license name in example

Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #351:
URL: https://github.com/apache/maven-site/pull/351#issuecomment-1345616098

   > > Looking at https://spdx.org/licenses/ it differentiates between name and id. Here, we abuse our name as id. I consider this to be logically wrong.
   > 
   > We have text:
   > 
   > > Using an [https://spdx.org/licenses/}SPDX](https://spdx.org/licenses/%7DSPDX) identifier as the license `name` is recommended.
   > 
   > So how should be ...
   > 
   > I merged similar in ASF parent pom 😄
   
   I know that we have it and only because we don't have an id element. For me, it feels wrong, honestly, but I won't object to merge it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-site] michael-o commented on pull request #351: Using an SPDX identifier as the license name in example

Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #351:
URL: https://github.com/apache/maven-site/pull/351#issuecomment-1349775831

   > For me id is more useful than an arbitrary label. Therefore I think we should stick to using an id in the name element (although the naming of the element is unfortunate)
   
   Real men don't wear clothes with labels, they have custom-tailored.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-site] kwin commented on pull request #351: Using an SPDX identifier as the license name in example

Posted by GitBox <gi...@apache.org>.
kwin commented on PR #351:
URL: https://github.com/apache/maven-site/pull/351#issuecomment-1349743139

   For me id is more useful than an arbitrary label. Therefore I think we should stick to using an id in the name element (although the naming of the element is unfortunate)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-site] slawekjaranowski commented on pull request #351: Using an SPDX identifier as the license name in example

Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #351:
URL: https://github.com/apache/maven-site/pull/351#issuecomment-1345614717

   > Looking at https://spdx.org/licenses/ it differentiates between name and id. Here, we abuse our name as id. I consider this to be logically wrong.
   
   We have text:
   
   > Using an https://spdx.org/licenses/}SPDX identifier as the license `name` is recommended.
   
   So how should be ...
   
   I merged similar in ASF parent pom 😄 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org