You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by GitBox <gi...@apache.org> on 2021/02/08 06:49:29 UTC

[GitHub] [bigtop] sekikn opened a new pull request #728: BIGTOP-3491. Add Ubuntu 20.04 support to the Bigtop toolchain.

sekikn opened a new pull request #728:
URL: https://github.com/apache/bigtop/pull/728


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bigtop] sekikn commented on pull request #728: BIGTOP-3491. Add Ubuntu 20.04 support to the Bigtop toolchain.

Posted by GitBox <gi...@apache.org>.
sekikn commented on pull request #728:
URL: https://github.com/apache/bigtop/pull/728#issuecomment-774916477


   I tested that `sudo bigtop_toolchain/bin/puppetize.sh`, `./gradlew toolchain`, and (after relogin) `/gradlew zookeeper-pkg -Dbuildwithdeps=true` worked with this PR on Ubuntu 20.04.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bigtop] iwasakims merged pull request #728: BIGTOP-3491. Add Ubuntu 20.04 support to the Bigtop toolchain.

Posted by GitBox <gi...@apache.org>.
iwasakims merged pull request #728:
URL: https://github.com/apache/bigtop/pull/728


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bigtop] sekikn commented on a change in pull request #728: BIGTOP-3491. Add Ubuntu 20.04 support to the Bigtop toolchain.

Posted by GitBox <gi...@apache.org>.
sekikn commented on a change in pull request #728:
URL: https://github.com/apache/bigtop/pull/728#discussion_r575972361



##########
File path: bigtop_toolchain/manifests/packages.pp
##########
@@ -204,7 +204,6 @@
         "bison",
         "flex",
         "python-dev",
-        "python-pip",

Review comment:
       Yes I think so. Python2 is still used in some components, but pip2 is not as far as I can see.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bigtop] iwasakims commented on a change in pull request #728: BIGTOP-3491. Add Ubuntu 20.04 support to the Bigtop toolchain.

Posted by GitBox <gi...@apache.org>.
iwasakims commented on a change in pull request #728:
URL: https://github.com/apache/bigtop/pull/728#discussion_r575950604



##########
File path: bigtop_toolchain/manifests/packages.pp
##########
@@ -204,7 +204,6 @@
         "bison",
         "flex",
         "python-dev",
-        "python-pip",

Review comment:
       Can we remove pip (for Python 2) from all distributions?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bigtop] iwasakims commented on a change in pull request #728: BIGTOP-3491. Add Ubuntu 20.04 support to the Bigtop toolchain.

Posted by GitBox <gi...@apache.org>.
iwasakims commented on a change in pull request #728:
URL: https://github.com/apache/bigtop/pull/728#discussion_r576067754



##########
File path: bigtop_toolchain/manifests/packages.pp
##########
@@ -204,7 +204,6 @@
         "bison",
         "flex",
         "python-dev",
-        "python-pip",

Review comment:
       I think we should see the effect on Ubuntu/Debian first by committing this as is.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org