[GitHub] [helix] jiajunwang commented on a change in pull request #1041: Change the error message to be meaningful naming

[GitBox <gi...@apache.org>]

jiajunwang commented on a change in pull request #1041:
URL: https://github.com/apache/helix/pull/1041#discussion_r434867243



##########
File path: helix-rest/src/main/java/org/apache/helix/rest/server/json/instance/StoppableCheck.java
##########
@@ -29,9 +29,9 @@
 public class StoppableCheck {
   // Category to differentiate which step the check fails
   public enum Category {
-    HELIX_OWN_CHECK("Helix:"),
-    CUSTOM_INSTANCE_CHECK("CustomInstance:"),
-    CUSTOM_PARTITION_CHECK("CustomPartition:");
+    HELIX_OWN_CHECK("HELIX:"),
+    CUSTOM_INSTANCE_CHECK("CUSTOM_INSTANCE_HEALTH_FAILURE:"),

Review comment:
       I would prefer to put the ":" into the string formatting part later. The enum info should be cleaner the better.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org