[Bug 6440] New: 20_vbounce.cf "has undefined dependency" warnings

[bu...@issues.apache.org]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6440

           Summary: 20_vbounce.cf "has undefined dependency" warnings
           Product: Spamassassin
           Version: 3.3.1
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Rules
        AssignedTo: dev@spamassassin.apache.org
        ReportedBy: alex.uribl@gmail.com


When disabling VBounce plugin
(#loadplugin Mail::SpamAssassin::Plugin::VBounce)

lint spits:

May 31 14:40:59.187 [1539] dbg: rules: meta test CRBOUNCE_MESSAGE has undefined
dependency '__MY_SERVERS_FOUND'
May 31 14:40:59.217 [1539] dbg: rules: meta test VBOUNCE_MESSAGE has undefined
dependency '__MY_SERVERS_FOUND'
May 31 14:40:59.226 [1539] dbg: rules: meta test BOUNCE_MESSAGE has undefined
dependency '__HAVE_BOUNCE_RELAYS'
May 31 14:40:59.226 [1539] dbg: rules: meta test BOUNCE_MESSAGE has undefined
dependency '__MY_SERVERS_FOUND'
May 31 14:40:59.228 [1539] dbg: rules: meta test FROM_MISSP_SPF_FAIL has
undefined dependency 'SPF_FAIL'
May 31 14:40:59.237 [1539] info: rules: meta test ANY_BOUNCE_MESSAGE has
dependency 'BOUNCE_MESSAGE' with a zero score
May 31 14:40:59.237 [1539] info: rules: meta test ANY_BOUNCE_MESSAGE has
dependency 'VBOUNCE_MESSAGE' with a zero score
May 31 14:40:59.244 [1539] dbg: rules: meta test CHALLENGE_RESPONSE has
undefined dependency '__MY_SERVERS_FOUND'

moving the "endif" to the bottom of the 20_vbounce.cf would eliminate these
warning.

comments ?

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6440] 20_vbounce.cf "has undefined dependency" warnings

[bu...@bugzilla.spamassassin.org]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6440

--- Comment #1 from Kevin A. McGrail <km...@pccc.com> 2011-10-29 04:49:46 UTC ---
Created attachment 4997
  --> https://issues.apache.org/SpamAssassin/attachment.cgi?id=4997
Patch to add more plugin conditions to rules in 20_vbounce.cf

I edited 20_vbounce.cf and disabled the plugin.  However, moving the endif to
the end does not appear to get rid of these errors for me.

I've noted this error before but can't find the bug.  For example, adding if
(version < 3.200000) and using rules from 3.2 still throws 

Oct 29 00:38:09.935 [5915] dbg: rules: meta test KAM_BLANK02 has undefined
dependency 'MSGID_FROM_MTA_ID'

So I think there are two issues:

vbounce might need more conditions in places where the __HAVE_BOUNCE_RELAYS and
__MY_SERVERS_FOUND are referenced.  And link could use improvements to
recognize the conditions.

As for the rest of the rules and moving the endif to the end, I'm guessing JM
had that scoped tightly for a reason and since it doesn't get rid of the lint
error, it's not needed.

Attached is a patch to add more conditions but this doesn't resolve the lint
issue for me.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.