Re: [PR] Deliver key metadata to parquet encryption [iceberg]

["ggershinsky (via GitHub)" <gi...@apache.org>]

ggershinsky commented on code in PR #6762:
URL: https://github.com/apache/iceberg/pull/6762#discussion_r1342920622


##########
api/src/main/java/org/apache/iceberg/encryption/EncryptionKeyMetadata.java:
##########
@@ -49,4 +54,12 @@ static EncryptionKeyMetadata empty() {
   ByteBuffer buffer();
 
   EncryptionKeyMetadata copy();
+
+  default ByteBuffer encryptionKey() {
+    throw new UnsupportedOperationException("Not implemented");
+  }
+
+  default ByteBuffer aadPrefix() {
+    return null;

Review Comment:
   Null is technically possible. It'd be indeed safer to throw an unsupported exception here as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org