You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by ericcarlschwartz <gi...@git.apache.org> on 2015/07/09 01:17:52 UTC
[GitHub] trafficserver pull request: [TS-3476] Add a log tag for applicatio...
GitHub user ericcarlschwartz opened a pull request:
https://github.com/apache/trafficserver/pull/244
[TS-3476] Add a log tag for application protocol
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yahoo/trafficserver TS-3476
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/244.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #244
----
commit 8a4dbe864677379abb9e726acb26d9fb242c1aa5
Author: ericcarlschwartz <es...@gmail.com>
Date: 2015-07-06T22:14:56Z
[TS-3476] Add a log tag for application protocol
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-3476] Add a log tag for applicatio...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/244
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-3476] Add a log tag for applicatio...
Posted by shinrich <gi...@git.apache.org>.
Github user shinrich commented on the pull request:
https://github.com/apache/trafficserver/pull/244#issuecomment-119948800
Looks good to me.
My only question was why had the PluginIdentity been earlier removed as a parent of the SpdyClientSession? @SolidWallOfCode dug up the commit and it turned out I did it as part of a commit to move more logic into that abstract ProxyClientSession class. I'm sure that was an accident, so adding it back should be just fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-3476] Add a log tag for applicatio...
Posted by ericcarlschwartz <gi...@git.apache.org>.
Github user ericcarlschwartz commented on the pull request:
https://github.com/apache/trafficserver/pull/244#issuecomment-120004282
@shinrich ah yeah I wasn't sure why it'd been dropped but I also can't see any reason adding it back would introduce any problems either
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-3476] Add a log tag for applicatio...
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/244#issuecomment-119953440
Looks reasonable as a stopgap to me. Hopefully we can in the near future do better through restructuring the underlying protocol handling structure as in TS-3612. We should revisit this code after that is done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---