Re: Holy crap on a cracker!

[Ruediger Pluem <rp...@apache.org>]

IMHO this is works as designed. This stuff is currently only in trunk and the tests pass there.
No regression for 2.4.x.

Regards

Rüdiger

Jim Jagielski wrote:
> The 2.4 branch is spewing out loads of (bogus??) test results...
> 
> Anyone else seeing this? Any idea why we continue to have tests
> that do these false positives (assuming that is what they are)??
> 
> t/apache/http_strict.t ....... 1/83 # Failed test 1 in t/apache/http_strict.t at line 134
> # Failed test 2 in t/apache/http_strict.t at line 134 fail #2
> # Failed test 3 in t/apache/http_strict.t at line 134 fail #3
> # Failed test 4 in t/apache/http_strict.t at line 134 fail #4
> # Failed test 5 in t/apache/http_strict.t at line 134 fail #5
> # Failed test 6 in t/apache/http_strict.t at line 134 fail #6
> # Failed test 7 in t/apache/http_strict.t at line 134 fail #7
> # Failed test 8 in t/apache/http_strict.t at line 134 fail #8
> # Failed test 9 in t/apache/http_strict.t at line 134 fail #9
> # Failed test 10 in t/apache/http_strict.t at line 134 fail #10
> # Failed test 11 in t/apache/http_strict.t at line 134 fail #11
> # Failed test 12 in t/apache/http_strict.t at line 134 fail #12
> # Failed test 13 in t/apache/http_strict.t at line 134 fail #13
> # Failed test 14 in t/apache/http_strict.t at line 134 fail #14
> # Failed test 15 in t/apache/http_strict.t at line 134 fail #15
> # Failed test 16 in t/apache/http_strict.t at line 134 fail #16
> # Failed test 17 in t/apache/http_strict.t at line 134 fail #17
> # Failed test 18 in t/apache/http_strict.t at line 134 fail #18
> # Failed test 19 in t/apache/http_strict.t at line 134 fail #19
> # Failed test 20 in t/apache/http_strict.t at line 134 fail #20
> # Failed test 21 in t/apache/http_strict.t at line 134 fail #21
> # Failed test 22 in t/apache/http_strict.t at line 134 fail #22
> # Failed test 23 in t/apache/http_strict.t at line 134 fail #23
> # Failed test 24 in t/apache/http_strict.t at line 134 fail #24
> # Failed test 25 in t/apache/http_strict.t at line 134 fail #25
> # Failed test 26 in t/apache/http_strict.t at line 134 fail #26
> # Failed test 27 in t/apache/http_strict.t at line 134 fail #27
> # Failed test 28 in t/apache/http_strict.t at line 134 fail #28
> # Failed test 29 in t/apache/http_strict.t at line 134 fail #29
> # Failed test 30 in t/apache/http_strict.t at line 134 fail #30
> # Failed test 31 in t/apache/http_strict.t at line 134 fail #31
> # Failed test 32 in t/apache/http_strict.t at line 134 fail #32
> # Failed test 33 in t/apache/http_strict.t at line 134 fail #33
> # Failed test 34 in t/apache/http_strict.t at line 134 fail #34
> # Failed test 35 in t/apache/http_strict.t at line 134 fail #35
> # Failed test 36 in t/apache/http_strict.t at line 134 fail #36
> # Failed test 37 in t/apache/http_strict.t at line 134 fail #37
> # Failed test 38 in t/apache/http_strict.t at line 134 fail #38
> # Failed test 39 in t/apache/http_strict.t at line 134 fail #39
> # Failed test 40 in t/apache/http_strict.t at line 134 fail #40
> # Failed test 41 in t/apache/http_strict.t at line 134 fail #41
> # Failed test 42 in t/apache/http_strict.t at line 134 fail #42
> # Failed test 43 in t/apache/http_strict.t at line 134 fail #43
> # Failed test 44 in t/apache/http_strict.t at line 134 fail #44
> # Failed test 45 in t/apache/http_strict.t at line 134 fail #45
> # Failed test 46 in t/apache/http_strict.t at line 134 fail #46
> # Failed test 47 in t/apache/http_strict.t at line 134 fail #47
> # Failed test 48 in t/apache/http_strict.t at line 134 fail #48
> # Failed test 49 in t/apache/http_strict.t at line 134 fail #49
> # Failed test 50 in t/apache/http_strict.t at line 134 fail #50
> # Failed test 51 in t/apache/http_strict.t at line 134 fail #51
> # Failed test 52 in t/apache/http_strict.t at line 134 fail #52
> # Failed test 53 in t/apache/http_strict.t at line 134 fail #53
> # Failed test 54 in t/apache/http_strict.t at line 134 fail #54
> # Failed test 55 in t/apache/http_strict.t at line 134 fail #55
> # Failed test 56 in t/apache/http_strict.t at line 134 fail #56
> # Failed test 57 in t/apache/http_strict.t at line 134 fail #57
> # Failed test 58 in t/apache/http_strict.t at line 134 fail #58
> # Failed test 59 in t/apache/http_strict.t at line 134 fail #59
> # Failed test 60 in t/apache/http_strict.t at line 134 fail #60
> # Failed test 61 in t/apache/http_strict.t at line 134 fail #61
> # Failed test 62 in t/apache/http_strict.t at line 134 fail #62
> # Failed test 63 in t/apache/http_strict.t at line 134 fail #63
> # Failed test 64 in t/apache/http_strict.t at line 134 fail #64
> # Failed test 65 in t/apache/http_strict.t at line 134 fail #65
> # Failed test 66 in t/apache/http_strict.t at line 134 fail #66
> # Failed test 67 in t/apache/http_strict.t at line 134 fail #67
> # Failed test 68 in t/apache/http_strict.t at line 134 fail #68
> # Failed test 69 in t/apache/http_strict.t at line 134 fail #69
> # Failed test 70 in t/apache/http_strict.t at line 134 fail #70
> # Failed test 71 in t/apache/http_strict.t at line 134 fail #71
> # Failed test 72 in t/apache/http_strict.t at line 134 fail #72
> # Failed test 73 in t/apache/http_strict.t at line 134 fail #73
> # Failed test 74 in t/apache/http_strict.t at line 134 fail #74
> # Failed test 75 in t/apache/http_strict.t at line 134 fail #75
> # Failed test 76 in t/apache/http_strict.t at line 134 fail #76
> # Failed test 77 in t/apache/http_strict.t at line 134 fail #77
> # Failed test 78 in t/apache/http_strict.t at line 134 fail #78
> # Failed test 79 in t/apache/http_strict.t at line 134 fail #79
> # Failed test 80 in t/apache/http_strict.t at line 134 fail #80
> # Failed test 81 in t/apache/http_strict.t at line 134 fail #81
> # Failed test 82 in t/apache/http_strict.t at line 134 fail #82
> # Failed test 83 in t/apache/http_strict.t at line 134 fail #83
> t/apache/http_strict.t ....... Failed 83/83 subtests 
> ...
> t/apache/server_name_port.t .. 1/84 # Failed test 32 in t/apache/server_name_port.t at line 107 fail #21
> # Failed test 35 in t/apache/server_name_port.t at line 107 fail #23
> # Failed test 56 in t/apache/server_name_port.t at line 107 fail #37
> # Failed test 57 in t/apache/server_name_port.t at line 107 fail #38
> # Failed test 59 in t/apache/server_name_port.t at line 107 fail #39
> # Failed test 60 in t/apache/server_name_port.t at line 107 fail #40
> # Failed test 80 in t/apache/server_name_port.t at line 107 fail #53
> # Failed test 81 in t/apache/server_name_port.t at line 107 fail #54
> t/apache/server_name_port.t .. 82/84 # Failed test 83 in t/apache/server_name_port.t at line 107 fail #55
> # Failed test 84 in t/apache/server_name_port.t at line 107 fail #56
> t/apache/server_name_port.t .. Failed 10/84 subtests 
> 
> 
> 

Re: Holy crap on a cracker!

[Jim Jagielski <ji...@jaguNET.com>]

fwiw, I went ahead and fix that...

On Feb 8, 2013, at 1:16 PM, Jim Jagielski <ji...@jagunet.com> wrote:

> Yeah, but the tests should KNOW that this is only in trunk.
> That's my ultimate point.
> 

Re: Holy crap on a cracker!

[Jim Jagielski <ji...@jaguNET.com>]

Cool. Thx!

On Feb 8, 2013, at 3:23 PM, Stefan Fritsch <sf...@sfritsch.de> wrote:

> On Friday 08 February 2013, Jim Jagielski wrote:
>> Yeah, but the tests should KNOW that this is only in trunk.
>> That's my ultimate point.
>> 
>> Tests should be set to either ensure correct/expected operation
>> or that bugs are fixed. These tests are there to check that
>> the trunk-only patches work; they should not flag "failures"
>> in 2.4.x in cases where (1) there are no regressions or
>> (2) the "feature" is just in trunk.
> 
> Sorry, I forgot the need_min_apache_version('2.5') in http_strict.t 
> However, server_name_port.t tests for actual bugs. Those tests should 
> not be skipped in 2.4/2.2 just because the bugs have not been fixed 
> there. I have marked them as todo, now.
> 

Re: Holy crap on a cracker!

[Stefan Fritsch <sf...@sfritsch.de>]

On Friday 08 February 2013, Jim Jagielski wrote:
> Yeah, but the tests should KNOW that this is only in trunk.
> That's my ultimate point.
> 
> Tests should be set to either ensure correct/expected operation
> or that bugs are fixed. These tests are there to check that
> the trunk-only patches work; they should not flag "failures"
> in 2.4.x in cases where (1) there are no regressions or
> (2) the "feature" is just in trunk.

Sorry, I forgot the need_min_apache_version('2.5') in http_strict.t 
However, server_name_port.t tests for actual bugs. Those tests should 
not be skipped in 2.4/2.2 just because the bugs have not been fixed 
there. I have marked them as todo, now.

Re: Holy crap on a cracker!

[Jim Jagielski <ji...@jaguNET.com>]

Yeah, but the tests should KNOW that this is only in trunk.
That's my ultimate point.

Tests should be set to either ensure correct/expected operation
or that bugs are fixed. These tests are there to check that
the trunk-only patches work; they should not flag "failures"
in 2.4.x in cases where (1) there are no regressions or
(2) the "feature" is just in trunk.

On Feb 8, 2013, at 1:09 PM, Ruediger Pluem <rp...@apache.org> wrote:

> IMHO this is works as designed. This stuff is currently only in trunk and the tests pass there.
> No regression for 2.4.x.
> 
> Regards
> 
> Rüdiger
> 
> Jim Jagielski wrote:
>> The 2.4 branch is spewing out loads of (bogus??) test results...
>> 
>> Anyone else seeing this? Any idea why we continue to have tests
>> that do these false positives (assuming that is what they are)??
>> 
>> t/apache/http_strict.t ....... 1/83 # Failed test 1 in t/apache/http_strict.t at line 134
>> # Failed test 2 in t/apache/http_strict.t at line 134 fail #2
>> # Failed test 3 in t/apache/http_strict.t at line 134 fail #3
>> # Failed test 4 in t/apache/http_strict.t at line 134 fail #4
>> # Failed test 5 in t/apache/http_strict.t at line 134 fail #5
>> # Failed test 6 in t/apache/http_strict.t at line 134 fail #6
>> # Failed test 7 in t/apache/http_strict.t at line 134 fail #7
>> # Failed test 8 in t/apache/http_strict.t at line 134 fail #8
>> # Failed test 9 in t/apache/http_strict.t at line 134 fail #9
>> # Failed test 10 in t/apache/http_strict.t at line 134 fail #10
>> # Failed test 11 in t/apache/http_strict.t at line 134 fail #11
>> # Failed test 12 in t/apache/http_strict.t at line 134 fail #12
>> # Failed test 13 in t/apache/http_strict.t at line 134 fail #13
>> # Failed test 14 in t/apache/http_strict.t at line 134 fail #14
>> # Failed test 15 in t/apache/http_strict.t at line 134 fail #15
>> # Failed test 16 in t/apache/http_strict.t at line 134 fail #16
>> # Failed test 17 in t/apache/http_strict.t at line 134 fail #17
>> # Failed test 18 in t/apache/http_strict.t at line 134 fail #18
>> # Failed test 19 in t/apache/http_strict.t at line 134 fail #19
>> # Failed test 20 in t/apache/http_strict.t at line 134 fail #20
>> # Failed test 21 in t/apache/http_strict.t at line 134 fail #21
>> # Failed test 22 in t/apache/http_strict.t at line 134 fail #22
>> # Failed test 23 in t/apache/http_strict.t at line 134 fail #23
>> # Failed test 24 in t/apache/http_strict.t at line 134 fail #24
>> # Failed test 25 in t/apache/http_strict.t at line 134 fail #25
>> # Failed test 26 in t/apache/http_strict.t at line 134 fail #26
>> # Failed test 27 in t/apache/http_strict.t at line 134 fail #27
>> # Failed test 28 in t/apache/http_strict.t at line 134 fail #28
>> # Failed test 29 in t/apache/http_strict.t at line 134 fail #29
>> # Failed test 30 in t/apache/http_strict.t at line 134 fail #30
>> # Failed test 31 in t/apache/http_strict.t at line 134 fail #31
>> # Failed test 32 in t/apache/http_strict.t at line 134 fail #32
>> # Failed test 33 in t/apache/http_strict.t at line 134 fail #33
>> # Failed test 34 in t/apache/http_strict.t at line 134 fail #34
>> # Failed test 35 in t/apache/http_strict.t at line 134 fail #35
>> # Failed test 36 in t/apache/http_strict.t at line 134 fail #36
>> # Failed test 37 in t/apache/http_strict.t at line 134 fail #37
>> # Failed test 38 in t/apache/http_strict.t at line 134 fail #38
>> # Failed test 39 in t/apache/http_strict.t at line 134 fail #39
>> # Failed test 40 in t/apache/http_strict.t at line 134 fail #40
>> # Failed test 41 in t/apache/http_strict.t at line 134 fail #41
>> # Failed test 42 in t/apache/http_strict.t at line 134 fail #42
>> # Failed test 43 in t/apache/http_strict.t at line 134 fail #43
>> # Failed test 44 in t/apache/http_strict.t at line 134 fail #44
>> # Failed test 45 in t/apache/http_strict.t at line 134 fail #45
>> # Failed test 46 in t/apache/http_strict.t at line 134 fail #46
>> # Failed test 47 in t/apache/http_strict.t at line 134 fail #47
>> # Failed test 48 in t/apache/http_strict.t at line 134 fail #48
>> # Failed test 49 in t/apache/http_strict.t at line 134 fail #49
>> # Failed test 50 in t/apache/http_strict.t at line 134 fail #50
>> # Failed test 51 in t/apache/http_strict.t at line 134 fail #51
>> # Failed test 52 in t/apache/http_strict.t at line 134 fail #52
>> # Failed test 53 in t/apache/http_strict.t at line 134 fail #53
>> # Failed test 54 in t/apache/http_strict.t at line 134 fail #54
>> # Failed test 55 in t/apache/http_strict.t at line 134 fail #55
>> # Failed test 56 in t/apache/http_strict.t at line 134 fail #56
>> # Failed test 57 in t/apache/http_strict.t at line 134 fail #57
>> # Failed test 58 in t/apache/http_strict.t at line 134 fail #58
>> # Failed test 59 in t/apache/http_strict.t at line 134 fail #59
>> # Failed test 60 in t/apache/http_strict.t at line 134 fail #60
>> # Failed test 61 in t/apache/http_strict.t at line 134 fail #61
>> # Failed test 62 in t/apache/http_strict.t at line 134 fail #62
>> # Failed test 63 in t/apache/http_strict.t at line 134 fail #63
>> # Failed test 64 in t/apache/http_strict.t at line 134 fail #64
>> # Failed test 65 in t/apache/http_strict.t at line 134 fail #65
>> # Failed test 66 in t/apache/http_strict.t at line 134 fail #66
>> # Failed test 67 in t/apache/http_strict.t at line 134 fail #67
>> # Failed test 68 in t/apache/http_strict.t at line 134 fail #68
>> # Failed test 69 in t/apache/http_strict.t at line 134 fail #69
>> # Failed test 70 in t/apache/http_strict.t at line 134 fail #70
>> # Failed test 71 in t/apache/http_strict.t at line 134 fail #71
>> # Failed test 72 in t/apache/http_strict.t at line 134 fail #72
>> # Failed test 73 in t/apache/http_strict.t at line 134 fail #73
>> # Failed test 74 in t/apache/http_strict.t at line 134 fail #74
>> # Failed test 75 in t/apache/http_strict.t at line 134 fail #75
>> # Failed test 76 in t/apache/http_strict.t at line 134 fail #76
>> # Failed test 77 in t/apache/http_strict.t at line 134 fail #77
>> # Failed test 78 in t/apache/http_strict.t at line 134 fail #78
>> # Failed test 79 in t/apache/http_strict.t at line 134 fail #79
>> # Failed test 80 in t/apache/http_strict.t at line 134 fail #80
>> # Failed test 81 in t/apache/http_strict.t at line 134 fail #81
>> # Failed test 82 in t/apache/http_strict.t at line 134 fail #82
>> # Failed test 83 in t/apache/http_strict.t at line 134 fail #83
>> t/apache/http_strict.t ....... Failed 83/83 subtests 
>> ...
>> t/apache/server_name_port.t .. 1/84 # Failed test 32 in t/apache/server_name_port.t at line 107 fail #21
>> # Failed test 35 in t/apache/server_name_port.t at line 107 fail #23
>> # Failed test 56 in t/apache/server_name_port.t at line 107 fail #37
>> # Failed test 57 in t/apache/server_name_port.t at line 107 fail #38
>> # Failed test 59 in t/apache/server_name_port.t at line 107 fail #39
>> # Failed test 60 in t/apache/server_name_port.t at line 107 fail #40
>> # Failed test 80 in t/apache/server_name_port.t at line 107 fail #53
>> # Failed test 81 in t/apache/server_name_port.t at line 107 fail #54
>> t/apache/server_name_port.t .. 82/84 # Failed test 83 in t/apache/server_name_port.t at line 107 fail #55
>> # Failed test 84 in t/apache/server_name_port.t at line 107 fail #56
>> t/apache/server_name_port.t .. Failed 10/84 subtests 
>> 
>> 
>> 
>