You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2018/05/15 14:00:05 UTC

[Impala-ASF-CR] IMPALA-7022: TestQueries.test subquery: Subquery must not return more than one row

Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10407


Change subject: IMPALA-7022: TestQueries.test_subquery: Subquery must not return more than one row
......................................................................

IMPALA-7022: TestQueries.test_subquery: Subquery must not return more than one row

TestQueries.test_subquery sometimes fails during exhaustive
tests.

In the tests we expect to catch an exception that is
prefixed by the "Query aborted:" string. The prefix is
usually added by impala_beeswax.py::wait_for_completion(),
but in rare cases it isn't added.

From the point of the test it is irrelevant if the exception
is prefixed with "Query aborted:" or not, so I removed it
from the expected exception string.

Change-Id: I3b8655ad273b1dd7a601099f617db609e4a4797b
---
M testdata/workloads/functional-query/queries/QueryTest/subquery.test
1 file changed, 4 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/10407/1
-- 
To view, visit http://gerrit.cloudera.org:8080/10407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3b8655ad273b1dd7a601099f617db609e4a4797b
Gerrit-Change-Number: 10407
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-7022: TestQueries.test subquery: Subquery must not return more than one row

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10407 )

Change subject: IMPALA-7022: TestQueries.test_subquery: Subquery must not return more than one row
......................................................................

IMPALA-7022: TestQueries.test_subquery: Subquery must not return more than one row

TestQueries.test_subquery sometimes fails during exhaustive
tests.

In the tests we expect to catch an exception that is
prefixed by the "Query aborted:" string. The prefix is
usually added by impala_beeswax.py::wait_for_completion(),
but in rare cases it isn't added.

From the point of the test it is irrelevant if the exception
is prefixed with "Query aborted:" or not, so I removed it
from the expected exception string.

Change-Id: I3b8655ad273b1dd7a601099f617db609e4a4797b
Reviewed-on: http://gerrit.cloudera.org:8080/10407
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Tim Armstrong <ta...@cloudera.com>
---
M testdata/workloads/functional-query/queries/QueryTest/subquery.test
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Tim Armstrong: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/10407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3b8655ad273b1dd7a601099f617db609e4a4797b
Gerrit-Change-Number: 10407
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-7022: TestQueries.test subquery: Subquery must not return more than one row

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has removed a vote on this change.

Change subject: IMPALA-7022: TestQueries.test_subquery: Subquery must not return more than one row
......................................................................


Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
-- 
To view, visit http://gerrit.cloudera.org:8080/10407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I3b8655ad273b1dd7a601099f617db609e4a4797b
Gerrit-Change-Number: 10407
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-7022: TestQueries.test subquery: Subquery must not return more than one row

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10407 )

Change subject: IMPALA-7022: TestQueries.test_subquery: Subquery must not return more than one row
......................................................................


Patch Set 1: Verified+1

This hit the same Junit test thing as my build


-- 
To view, visit http://gerrit.cloudera.org:8080/10407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b8655ad273b1dd7a601099f617db609e4a4797b
Gerrit-Change-Number: 10407
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 May 2018 23:37:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7022: TestQueries.test subquery: Subquery must not return more than one row

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10407 )

Change subject: IMPALA-7022: TestQueries.test_subquery: Subquery must not return more than one row
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2479/


-- 
To view, visit http://gerrit.cloudera.org:8080/10407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b8655ad273b1dd7a601099f617db609e4a4797b
Gerrit-Change-Number: 10407
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 May 2018 18:40:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7022: TestQueries.test subquery: Subquery must not return more than one row

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10407 )

Change subject: IMPALA-7022: TestQueries.test_subquery: Subquery must not return more than one row
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/10407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b8655ad273b1dd7a601099f617db609e4a4797b
Gerrit-Change-Number: 10407
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 May 2018 15:47:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7022: TestQueries.test subquery: Subquery must not return more than one row

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10407 )

Change subject: IMPALA-7022: TestQueries.test_subquery: Subquery must not return more than one row
......................................................................


Patch Set 1: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2479/


-- 
To view, visit http://gerrit.cloudera.org:8080/10407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b8655ad273b1dd7a601099f617db609e4a4797b
Gerrit-Change-Number: 10407
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 May 2018 22:14:07 +0000
Gerrit-HasComments: No