You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/01/18 17:53:49 UTC
[GitHub] [shardingsphere] ThanoshanMV opened a new pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE
ThanoshanMV opened a new pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084
Fixes #9059
Changes proposed in this pull request:
- added SQL definition of `DROP TABLE`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] ThanoshanMV commented on pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE
Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#issuecomment-763340030
> > Hi @tristaZero, since COMDEV-385 is hard and student applications start from at the end of March, I would like to try it as it'll help me to further explore the task, finish small subtasks and enough time to understand the task before submitting the application.
> > I would like to start with small subtasks of the main task and finish them.
>
> I prefer your choice. Preparation work helps us move it forward smoothly. The target definitions of `COMDEV-385` are `SELECT/UPDATE/DELETE/INSERT`. From my perspective, `SELECT` is the most difficult one. My suggestion is first to try `INSERT` or `DELETE`.
>
> Any questions, please be free to ping me or @wgy8283335 at your PR.
>
> Another concern is that I am not sure whether `GSOC2021` allows pre-raise PRs. If not, we need to figure out how to do our preparation work.
Thank you for guiding me @tristaZero. If `GSOC2021` allows us to pre-raise PRs on the main task then I would like to try on the `INSERT` statement, if I finished it successfully then I'll try other little tasks such as #9018 until I submit the application and eligible to work on the main task.
If `GSOC2021` doesn't allow us to pre-raise PRs then for the preparation, I would like to try other little tasks which will help me to try our COMDEV-385 once I'm eligible to do.
I'll get help from you and @wgy8283335.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] ThanoshanMV edited a comment on pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE
Posted by GitBox <gi...@apache.org>.
ThanoshanMV edited a comment on pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#issuecomment-764325579
Hi @tristaZero, I've searched through the documents and I haven't found anything about pre-PRs.
For the preparation work, I would like to do more tasks related to our COMDEV-385. I think this will allow me to explore more into the project and have a better understanding.
I'm okay with any of your tasks and suggestions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] ThanoshanMV commented on a change in pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE
Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on a change in pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#discussion_r560686983
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/antlr4/imports/oracle/DDLStatement.g4
##########
@@ -37,7 +37,7 @@ alterIndex
;
dropTable
- : DROP TABLE tableName
+ : DROP TABLE (schemaName DOT_)? tableName (CASCADE CONSTRAINTS)? (PURGE)?
Review comment:
Okay, I'll revert the previous commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on a change in pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE
Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#discussion_r560660485
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/main/resources/sql/supported/ddl/drop.xml
##########
@@ -23,6 +23,7 @@
<sql-case id="drop_table_restrict" value="DROP TABLE t_log RESTRICT" db-types="MySQL,PostgreSQL" />
<sql-case id="drop_table_cascade" value="DROP TABLE t_log CASCADE" db-types="MySQL,PostgreSQL" />
<sql-case id="drop_table_cascade_constraints_and_purge" value="DROP TABLE t_log CASCADE CONSTRAINTS PURGE" db-types="Oracle" />
+ <sql-case id="drop_table_purge" value="DROP TABLE t_log PURGE" db-types="Oracle" />
Review comment:
Hi sorry for my mistake. You're right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] wgy8283335 commented on a change in pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE
Posted by GitBox <gi...@apache.org>.
wgy8283335 commented on a change in pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#discussion_r560631305
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/antlr4/imports/oracle/DDLStatement.g4
##########
@@ -37,7 +37,7 @@ alterIndex
;
dropTable
- : DROP TABLE tableName
+ : DROP TABLE (schemaName DOT_)? tableName (CASCADE CONSTRAINTS)? (PURGE)?
Review comment:
I am wondering whether need add "(schemaName DOT_)?", as tableName definition is below:
```
tableName
: (owner DOT_)? name
```
@tristaZero I think it's better to remove "(schemaName DOT_)?", are you agree with me?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#issuecomment-763379873
Nice job. @ThanoshanMV
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] ThanoshanMV commented on a change in pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE
Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on a change in pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#discussion_r560686983
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/antlr4/imports/oracle/DDLStatement.g4
##########
@@ -37,7 +37,7 @@ alterIndex
;
dropTable
- : DROP TABLE tableName
+ : DROP TABLE (schemaName DOT_)? tableName (CASCADE CONSTRAINTS)? (PURGE)?
Review comment:
Okay, I'll change it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero edited a comment on pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE
Posted by GitBox <gi...@apache.org>.
tristaZero edited a comment on pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#issuecomment-762698534
@ThanoshanMV Thanks for your quick PR, I guess a test will be added later, for now let leave @wgy8283335 some time to give it a look.
Until now, some simple issues are picked up for you to have a basic learning about our [COMDEV-385](https://issues.apache.org/jira/browse/COMDEV-385) , which is much harder. Do you want to have some other little tasks or begin to try COMDEV-385?
BTW, the timeline in (GSOC2021)[https://community.apache.org/gsoc.html#prospective-asf-mentors-read-this] shows us,
> We are now collecting ideas for GSoC 2021
> 2021-03-30: Student applications start
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] ThanoshanMV commented on pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE
Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#issuecomment-764325579
Hi @tristaZero, I've searched through the documents and I haven't found anything about pre-PRs. Seems like we can not pre-PR. I'm also not sure about this.
For the preparation work, is there any other SQL definition other than `SELECT/UPDATE/DELETE/INSERT` which requires the same work and steps I need to follow as I would need to follow for `SELECT/UPDATE/DELETE/INSERT`? If not, I can do other preparation tasks which you assign me to do.
I'm okay with any of your tasks and suggestions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] ThanoshanMV commented on pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE
Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#issuecomment-762792216
Hi @tristaZero, I'll make the changes and let you know
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] ThanoshanMV commented on a change in pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE
Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on a change in pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#discussion_r560131402
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/main/resources/sql/supported/ddl/drop.xml
##########
@@ -23,6 +23,7 @@
<sql-case id="drop_table_restrict" value="DROP TABLE t_log RESTRICT" db-types="MySQL,PostgreSQL" />
<sql-case id="drop_table_cascade" value="DROP TABLE t_log CASCADE" db-types="MySQL,PostgreSQL" />
<sql-case id="drop_table_cascade_constraints_and_purge" value="DROP TABLE t_log CASCADE CONSTRAINTS PURGE" db-types="Oracle" />
+ <sql-case id="drop_table_purge" value="DROP TABLE t_log PURGE" db-types="Oracle" />
Review comment:
Okay, I'll do it @tristaZero
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#issuecomment-762698534
@ThanoshanMV Thanks for your quick PR, I guess a test will be added later, for now let leave @wgy8283335 some time to give it a look.
Until now, some simple issues are picked up for you to have a basic learning about our [COMDEV-385](https://issues.apache.org/jira/browse/COMDEV-385) , which is much harder. Do you want to have some other little tasks or begin to try COMDEV-385?
BTW, the timeline in (GSOC2021) [https://community.apache.org/gsoc.html#prospective-asf-mentors-read-this] shows us,
> We are now collecting ideas for GSoC 2021
> 2021-03-30: Student applications start
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on a change in pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE
Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#discussion_r560661158
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/antlr4/imports/oracle/DDLStatement.g4
##########
@@ -37,7 +37,7 @@ alterIndex
;
dropTable
- : DROP TABLE tableName
+ : DROP TABLE (schemaName DOT_)? tableName (CASCADE CONSTRAINTS)? (PURGE)?
Review comment:
Hi, If that' is the the definition of `tableName`, I agree to remove `(schemaName DOT_)?` from this `dropTable` definition.
@ThanoshanMV Could you give it a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on a change in pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE
Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#discussion_r560660485
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/main/resources/sql/supported/ddl/drop.xml
##########
@@ -23,6 +23,7 @@
<sql-case id="drop_table_restrict" value="DROP TABLE t_log RESTRICT" db-types="MySQL,PostgreSQL" />
<sql-case id="drop_table_cascade" value="DROP TABLE t_log CASCADE" db-types="MySQL,PostgreSQL" />
<sql-case id="drop_table_cascade_constraints_and_purge" value="DROP TABLE t_log CASCADE CONSTRAINTS PURGE" db-types="Oracle" />
+ <sql-case id="drop_table_purge" value="DROP TABLE t_log PURGE" db-types="Oracle" />
Review comment:
You're right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] ThanoshanMV commented on pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE
Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#issuecomment-762669706
Hi @tristaZero, I've added the SQL definition of `DROP TABLE`. Can you please check it?
I read [this issue](https://github.com/apache/shardingsphere/issues/4889) to understand the `start-index` and `stop-index`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#issuecomment-764209867
@ThanoshanMV
If there is any hints, you can comment on our COMDEV-385.
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] ThanoshanMV commented on pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE
Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#issuecomment-763064504
> @ThanoshanMV Thanks for your quick PR, I guess a test will be added later, for now let leave @wgy8283335 some time to give it a look.
>
> Until now, some simple issues are picked up for you to have a basic learning about our [COMDEV-385](https://issues.apache.org/jira/browse/COMDEV-385) , which is much harder. Do you want to have some other little tasks or begin to try COMDEV-385?
>
> BTW, the timeline in (GSOC2021)[https://community.apache.org/gsoc.html#prospective-asf-mentors-read-this] shows us,
>
> > We are now collecting ideas for GSoC 2021
> > 2021-03-30: Student applications start
Hi @tristaZero, since [COMDEV-385](https://issues.apache.org/jira/browse/COMDEV-385) is hard and student applications start from at the end of March, I would like to try it as it'll help me to further explore the task, finish small subtasks and enough time to understand the task before submitting the application.
I would like to start with small subtasks of the main task and finish them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] ThanoshanMV commented on pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE
Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#issuecomment-762800308
Hi @tristaZero, I've modified the definition. Can you please check it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#issuecomment-763321773
> Hi @tristaZero, since COMDEV-385 is hard and student applications start from at the end of March, I would like to try it as it'll help me to further explore the task, finish small subtasks and enough time to understand the task before submitting the application.
I would like to start with small subtasks of the main task and finish them.
I prefer your choice. Preparation work helps us move it forward smoothly. The target definitions of `COMDEV-385` are `SELECT/UPDATE/DELETE/INSERT`. From my perspective, `SELECT` is the most difficult one. My suggestion is first to try `INSERT` or `DELETE`.
Any questions, please be free to ping me or @wgy8283335 at your PR.
Another concern is that I am not sure whether `GSOC2021` allows pre-raise PRs. If not, we need to figure out how to do our preparation work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on a change in pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE
Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#discussion_r560129967
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/main/resources/sql/supported/ddl/drop.xml
##########
@@ -23,6 +23,7 @@
<sql-case id="drop_table_restrict" value="DROP TABLE t_log RESTRICT" db-types="MySQL,PostgreSQL" />
<sql-case id="drop_table_cascade" value="DROP TABLE t_log CASCADE" db-types="MySQL,PostgreSQL" />
<sql-case id="drop_table_cascade_constraints_and_purge" value="DROP TABLE t_log CASCADE CONSTRAINTS PURGE" db-types="Oracle" />
+ <sql-case id="drop_table_purge" value="DROP TABLE t_log PURGE" db-types="Oracle" />
Review comment:
I suppose `DROP TABLE from db PURGE` is a more valuable case. Could you add this one or replace that simple one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] ThanoshanMV commented on a change in pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE
Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on a change in pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#discussion_r560134744
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/main/resources/sql/supported/ddl/drop.xml
##########
@@ -23,6 +23,7 @@
<sql-case id="drop_table_restrict" value="DROP TABLE t_log RESTRICT" db-types="MySQL,PostgreSQL" />
<sql-case id="drop_table_cascade" value="DROP TABLE t_log CASCADE" db-types="MySQL,PostgreSQL" />
<sql-case id="drop_table_cascade_constraints_and_purge" value="DROP TABLE t_log CASCADE CONSTRAINTS PURGE" db-types="Oracle" />
+ <sql-case id="drop_table_purge" value="DROP TABLE t_log PURGE" db-types="Oracle" />
Review comment:
`DROP TABLE db.name PURGE`: is it the query we need to specify there?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] ThanoshanMV commented on pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE
Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#issuecomment-764325579
Hi @tristaZero, I've searched through the documents and I haven't found anything about pre-PRs. Seems like we can not pre-PR. I'm also not sure about this.
For the preparation work, is there any other SQL definition other than `SELECT/UPDATE/DELETE/INSERT` which requires the same work and steps I need to follow as I would need to follow for `SELECT/UPDATE/DELETE/INSERT`? If not, I can do other preparation tasks which you assign me to do.
I'm okay with any of your tasks and suggestions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] ThanoshanMV edited a comment on pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE
Posted by GitBox <gi...@apache.org>.
ThanoshanMV edited a comment on pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#issuecomment-764325579
Hi @tristaZero, I've searched through the documents and I haven't found anything about pre-PRs.
For the preparation work, I'll try to find out basic vague SQL grammar definitions and correct them referring to Oracle documentation in the [target directory](https://github.com/apache/shardingsphere/tree/master/shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/antlr4/imports/oracle)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] ThanoshanMV edited a comment on pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE
Posted by GitBox <gi...@apache.org>.
ThanoshanMV edited a comment on pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#issuecomment-764325579
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] ThanoshanMV commented on a change in pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE
Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on a change in pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#discussion_r560134744
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/main/resources/sql/supported/ddl/drop.xml
##########
@@ -23,6 +23,7 @@
<sql-case id="drop_table_restrict" value="DROP TABLE t_log RESTRICT" db-types="MySQL,PostgreSQL" />
<sql-case id="drop_table_cascade" value="DROP TABLE t_log CASCADE" db-types="MySQL,PostgreSQL" />
<sql-case id="drop_table_cascade_constraints_and_purge" value="DROP TABLE t_log CASCADE CONSTRAINTS PURGE" db-types="Oracle" />
+ <sql-case id="drop_table_purge" value="DROP TABLE t_log PURGE" db-types="Oracle" />
Review comment:
Do you mean case like `DROP TABLE db.tableName PURGE`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] ThanoshanMV commented on pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE
Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#issuecomment-763399795
> @ThanoshanMV
>
> So the key point here is to make sure the pre-PR issue. I glance through [GSOC2021](https://opensource.googleblog.com/2020/10/google-summer-of-code-2021-is-bringing.html) and did not find the exact answer? Could you give it a check?
> Maybe the last way for us is to email the organizer.
Okay Trista, I'll check it and let you know.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] ThanoshanMV edited a comment on pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE
Posted by GitBox <gi...@apache.org>.
ThanoshanMV edited a comment on pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#issuecomment-764325579
Hi @tristaZero, I've searched through the documents and I haven't found anything about pre-PRs. Seems like we can not pre-PR. I'm also not sure about this.
For the preparation work, I would like to do more tasks related to our COMDEV-385. I think this will allow me to explore more into the project and have a better understanding.
I'm okay with any of your tasks and suggestions.
I'll comment in the COMDEV-385.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] ThanoshanMV edited a comment on pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE
Posted by GitBox <gi...@apache.org>.
ThanoshanMV edited a comment on pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#issuecomment-764325579
Hi @tristaZero, I've searched through the documents and I haven't found anything about pre-PRs. Seems like we can not pre-PR. I'm also not sure about this.
For the preparation work, I would like to do more tasks related to our COMDEV-385. I think this will allow me to explore more into the project and have a better understanding.
I'm okay with any of your tasks and suggestions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#issuecomment-764209867
@ThanoshanMV
If there is any hints, you can comment on our COMDEV-385.
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#issuecomment-763371003
@ThanoshanMV
So the key point here is to make sure the pre-PR issue. I glance through [GSOC2021](https://opensource.googleblog.com/2020/10/google-summer-of-code-2021-is-bringing.html) and did not find the exact answer? Could you give it a check?
Maybe the last way for us is to email the organizer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org