You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Willis Blackburn (JIRA)" <ji...@apache.org> on 2010/12/27 21:02:46 UTC

[jira] Created: (WICKET-3286) DropDownChoice: "data" or "choices?"

DropDownChoice:  "data" or "choices?"
-------------------------------------

                 Key: WICKET-3286
                 URL: https://issues.apache.org/jira/browse/WICKET-3286
             Project: Wicket
          Issue Type: Improvement
          Components: wicket
    Affects Versions: 1.5-M3
            Reporter: Willis Blackburn


In DropDownChoice, sometimes the constructor argument is called "data" and sometimes "choices."  These look like the same parameter; wouldn't it be better to give the same parameter the same name across all the constructors?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (WICKET-3286) DropDownChoice: "data" or "choices?"

Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Juergen Donnerstag reassigned WICKET-3286:
------------------------------------------

    Assignee: Juergen Donnerstag

> DropDownChoice:  "data" or "choices?"
> -------------------------------------
>
>                 Key: WICKET-3286
>                 URL: https://issues.apache.org/jira/browse/WICKET-3286
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.5-M3
>            Reporter: Willis Blackburn
>            Assignee: Juergen Donnerstag
>
> In DropDownChoice, sometimes the constructor argument is called "data" and sometimes "choices."  These look like the same parameter; wouldn't it be better to give the same parameter the same name across all the constructors?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-3286) DropDownChoice: "data" or "choices?"

Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Juergen Donnerstag resolved WICKET-3286.
----------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5-M4

> DropDownChoice:  "data" or "choices?"
> -------------------------------------
>
>                 Key: WICKET-3286
>                 URL: https://issues.apache.org/jira/browse/WICKET-3286
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.5-M3
>            Reporter: Willis Blackburn
>            Assignee: Juergen Donnerstag
>             Fix For: 1.5-M4
>
>
> In DropDownChoice, sometimes the constructor argument is called "data" and sometimes "choices."  These look like the same parameter; wouldn't it be better to give the same parameter the same name across all the constructors?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.