You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Hervé Boutemy (JIRA)" <ji...@apache.org> on 2015/07/18 00:39:06 UTC
[jira] [Comment Edited] (MASSEMBLY-385) Filtering replaces tokens
it should not be replacing
[ https://issues.apache.org/jira/browse/MASSEMBLY-385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14424663#comment-14424663 ]
Hervé Boutemy edited comment on MASSEMBLY-385 at 7/17/15 10:38 PM:
-------------------------------------------------------------------
Fixed in [r806277|http://svn.apache.org/r806277]
One test is split into two to test an improved behavior. The original test does not expect property values containing colons (:) and backslashes (\) to be escaped when the file being filtered is a properties file which is now being done by maven-filtering.
A test is also added relating to this issue.
was (Author: elpunzalan):
Fixed in SVN.
One test is split into two to test an improved behavior. The original test does not expect property values containing colons (:) and backslashes (\) to be escaped when the file being filtered is a properties file which is now being done by maven-filtering.
A test is also added relating to this issue.
> Filtering replaces tokens it should not be replacing
> ----------------------------------------------------
>
> Key: MASSEMBLY-385
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-385
> Project: Maven Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-3
> Environment: Maven 2.0.9
> Reporter: Robert Bracewell
> Assignee: Edwin Punzalan
> Fix For: 2.2-beta-5
>
> Attachments: component.zip
>
>
> What is described below is attached as an example that duplicates this
> When filtering is turned on and a token ends with .url then very strange things happen
> The assembly descriptor uses
> {code:xml} <files>
> <file>
> <source>${basedir}/src/config/xml/applicationContext.xml</source>
> <outputDirectory>xml</outputDirectory>
> <filtered>true</filtered>
> </file>
> </files>{code}
> The file being filtered contains:
> {code:xml}<beans>
> <bean id="ThisIsATest">
> <property name="wapURLMessage" value="${wap.url.message}"/>
> <property name="wapURL" value="${wap.url}"/>
> <property name="vanityURLMessage" value="${vanity.url.message}"/>
> <property name="vanityURL" value="${vanity.url}"/>
> </bean>
> </beans>{code}
> After the assembly is run the file contains:
> {code:xml}<beans>
> <bean id="ThisIsATest">
> <property name="wapURLMessage" value="${wap.url.message}"/>
> <property name="wapURL" value="This is a not a URL but demonstrates the BUG/test1"/>
> <property name="vanityURLMessage" value="${vanity.url.message}"/>
> <property name="vanityURL" value="This is a not a URL but demonstrates the BUG/test1"/>
> </bean>
> </beans>{code}
> The string This is a not a URL but demonstrates the BUG comes from the url tag defined in parent pom
> The string test1 is the artifactId
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)