[GitHub] [ozone] neils-dev commented on a diff in pull request #4467: HDDS-8270. Measure checkAccess latency for Ozone objects

["neils-dev (via GitHub)" <gi...@apache.org>]

neils-dev commented on code in PR #4467:
URL: https://github.com/apache/ozone/pull/4467#discussion_r1155528481


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMPerformanceMetrics.java:
##########
@@ -140,4 +142,8 @@ public MutableRate getGetKeyInfoResolveBucketLatencyNs() {
   public void setForceContainerCacheRefresh(boolean value) {
     forceContainerCacheRefresh.add(value ? 1L : 0L);
   }
+
+  public MutableRate getCheckAccessLatencyNs() {

Review Comment:
   Thanks @tanvipenumudy for the patch.  Not sure about passing the _private_ metric `MutableRate` variable from this class to an external caller.  Should just have _getters_ and `setters` for the private `checkAccessLatencyNs `variable.  Can we not structure this so the variable remains hidden and private and just declare a setter for `checkAccessLatencyNs`, such as `public void setCheckAccessLatencyNs(long latencyInNs) `and pass the setter to a _**similar**_ utility function to `captureLatencyNs` that sets the `MutableRate` with the setter? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org