[GitHub] [avro] martin-g commented on a diff in pull request #2441: AVRO-3814: Fix schema resolution for records in union types

["martin-g (via GitHub)" <gi...@apache.org>]

martin-g commented on code in PR #2441:
URL: https://github.com/apache/avro/pull/2441#discussion_r1294451602


##########
lang/rust/avro/src/schema.rs:
##########
@@ -837,9 +837,11 @@ impl UnionSchema {
                 // extend known schemas with just resolved names
                 collected_names.extend(resolved_names);
                 let namespace = &schema.namespace().or_else(|| enclosing_namespace.clone());
+
                 value
-                    .validate_internal(schema, &collected_names, namespace)
-                    .is_none()
+                    .clone()

Review Comment:
   This is needed because `#resolve_internal()` accepts `mut self` ... I'll see whether this could be optimized somehow!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org