You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "nitishagar (via GitHub)" <gi...@apache.org> on 2026/04/30 09:47:19 UTC
[PR] fix(sunburst): remove label text outline in dark theme [superset]
nitishagar opened a new pull request, #39774:
URL: https://github.com/apache/superset/pull/39774
### SUMMARY
Sunburst segment labels were rendered with a black 1px text border (`textBorderColor` + `textBorderWidth: 1`), making them difficult to read — especially in dark theme where the white text + black outline creates a noisy appearance.
The fix is to remove the outline entirely. `theme.colorText` already provides the correct contrast color for both light and dark themes via Ant Design theme tokens, so no conditional logic is needed.
The center "Total" text label is untouched — it was already using `theme.colorText` correctly.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!-- Upload before/after screenshots to the PR via drag-drop. Don't commit image files. -->
### TESTING INSTRUCTIONS
1. Open a Superset instance with a Sunburst chart.
2. Switch to dark theme. Confirm segment labels render as clean solid text with no black outline.
3. Switch to light theme. Confirm labels remain readable (no regression).
4. Verify the center "Total" text is unchanged.
### ADDITIONAL INFORMATION
- [x] Has associated issue: Fixes #37905
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(sunburst): remove label text outline in dark theme [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #39774:
URL: https://github.com/apache/superset/pull/39774#issuecomment-4351412131
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(sunburst): remove label text outline in dark theme [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #39774:
URL: https://github.com/apache/superset/pull/39774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(sunburst): remove label text outline in dark theme [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #39774:
URL: https://github.com/apache/superset/pull/39774#issuecomment-4351515790
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/39774?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 64.46%. Comparing base ([`ae4c765`](https://app.codecov.io/gh/apache/superset/commit/ae4c765d7d6e851778823d55bb1500348abab514?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e979d5d`](https://app.codecov.io/gh/apache/superset/commit/e979d5da3a2353a926fc05275c7a2cf042ca4195?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #39774 +/- ##
==========================================
+ Coverage 64.41% 64.46% +0.04%
==========================================
Files 2566 2566
Lines 134284 134284
Branches 31194 31194
==========================================
+ Hits 86503 86564 +61
+ Misses 46283 46222 -61
Partials 1498 1498
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/39774/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/39774/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `66.68% <ø> (+0.08%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/39774?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org