You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "zhuangchong (via GitHub)" <gi...@apache.org> on 2024/03/11 05:09:34 UTC
[PR] [hotfix] upgrade json-path and avro version [incubator-paimon]
zhuangchong opened a new pull request, #2987:
URL: https://github.com/apache/incubator-paimon/pull/2987
<!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: closes #2966 #2965
<!-- What is the purpose of the change -->
### Tests
<!-- List UT and IT cases to verify this change -->
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] upgrade json-path and avro version [incubator-paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #2987:
URL: https://github.com/apache/incubator-paimon/pull/2987#discussion_r1525835695
##########
paimon-filesystems/paimon-s3-impl/src/main/resources/META-INF/NOTICE:
##########
@@ -14,7 +14,6 @@ This project bundles the following dependencies under the Apache Software Licens
- com.amazonaws:jmespath-java:1.12.319
- com.fasterxml.jackson.core:jackson-annotations:2.14.2
- com.fasterxml.jackson.core:jackson-core:2.14.2
-- com.fasterxml.jackson.core:jackson-databind:2.14.2
Review Comment:
unzip -l paimon-hadoop-shaded-0.8-SNAPSHOT.jar| grep databind
The jar contains databind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] upgrade json-path and avro version [incubator-paimon]
Posted by "zhuangchong (via GitHub)" <gi...@apache.org>.
zhuangchong commented on code in PR #2987:
URL: https://github.com/apache/incubator-paimon/pull/2987#discussion_r1525693251
##########
paimon-filesystems/paimon-s3-impl/src/main/resources/META-INF/NOTICE:
##########
@@ -14,7 +14,6 @@ This project bundles the following dependencies under the Apache Software Licens
- com.amazonaws:jmespath-java:1.12.319
- com.fasterxml.jackson.core:jackson-annotations:2.14.2
- com.fasterxml.jackson.core:jackson-core:2.14.2
-- com.fasterxml.jackson.core:jackson-databind:2.14.2
Review Comment:
I made changes based on UT.
https://github.com/apache/incubator-paimon/actions/runs/8228264920/job/22497412307#step:5:80
<img width="1058" alt="image" src="https://github.com/apache/incubator-paimon/assets/37063904/19253431-c4e7-4e53-9360-f5f3142e31e1">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] upgrade json-path and avro version [incubator-paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #2987:
URL: https://github.com/apache/incubator-paimon/pull/2987
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] upgrade json-path and avro version [incubator-paimon]
Posted by "zhuangchong (via GitHub)" <gi...@apache.org>.
zhuangchong commented on code in PR #2987:
URL: https://github.com/apache/incubator-paimon/pull/2987#discussion_r1526111740
##########
paimon-filesystems/paimon-s3-impl/src/main/resources/META-INF/NOTICE:
##########
@@ -14,7 +14,6 @@ This project bundles the following dependencies under the Apache Software Licens
- com.amazonaws:jmespath-java:1.12.319
- com.fasterxml.jackson.core:jackson-annotations:2.14.2
- com.fasterxml.jackson.core:jackson-core:2.14.2
-- com.fasterxml.jackson.core:jackson-databind:2.14.2
Review Comment:
Sorry, the notice checking UT is flawed, I'll check it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] upgrade json-path and avro version [incubator-paimon]
Posted by "zhuangchong (via GitHub)" <gi...@apache.org>.
zhuangchong commented on code in PR #2987:
URL: https://github.com/apache/incubator-paimon/pull/2987#discussion_r1526113666
##########
paimon-filesystems/paimon-s3-impl/src/main/resources/META-INF/NOTICE:
##########
@@ -14,7 +14,6 @@ This project bundles the following dependencies under the Apache Software Licens
- com.amazonaws:jmespath-java:1.12.319
- com.fasterxml.jackson.core:jackson-annotations:2.14.2
- com.fasterxml.jackson.core:jackson-core:2.14.2
-- com.fasterxml.jackson.core:jackson-databind:2.14.2
Review Comment:
I have restored this file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] upgrade json-path and avro version [incubator-paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #2987:
URL: https://github.com/apache/incubator-paimon/pull/2987#discussion_r1525685205
##########
paimon-filesystems/paimon-s3-impl/src/main/resources/META-INF/NOTICE:
##########
@@ -14,7 +14,6 @@ This project bundles the following dependencies under the Apache Software Licens
- com.amazonaws:jmespath-java:1.12.319
- com.fasterxml.jackson.core:jackson-annotations:2.14.2
- com.fasterxml.jackson.core:jackson-core:2.14.2
-- com.fasterxml.jackson.core:jackson-databind:2.14.2
Review Comment:
Why update here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] upgrade json-path and avro version [incubator-paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #2987:
URL: https://github.com/apache/incubator-paimon/pull/2987#discussion_r1525835951
##########
paimon-filesystems/paimon-s3-impl/src/main/resources/META-INF/NOTICE:
##########
@@ -14,7 +14,6 @@ This project bundles the following dependencies under the Apache Software Licens
- com.amazonaws:jmespath-java:1.12.319
- com.fasterxml.jackson.core:jackson-annotations:2.14.2
- com.fasterxml.jackson.core:jackson-core:2.14.2
-- com.fasterxml.jackson.core:jackson-databind:2.14.2
Review Comment:
You need to very careful when removing notice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org