You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Andrew Cornwall (JIRA)" <ji...@apache.org> on 2008/01/11 18:37:34 UTC
[jira] Created: (HARMONY-5382) [classlib][pack200] Class constant
pool sort order, instruction set fixes
[classlib][pack200] Class constant pool sort order, instruction set fixes
-------------------------------------------------------------------------
Key: HARMONY-5382
URL: https://issues.apache.org/jira/browse/HARMONY-5382
Project: Harmony
Issue Type: Improvement
Components: Classlib
Environment: All pack200
Reporter: Andrew Cornwall
Attachments: patches.zip
Currently, the pack200 code outputs its ClassConstantPools in an ordering inconsistent with that of the spec. This patch does three things:
- fixes the sort order of ClassConstantPools so they sort in the defined order (introducing a ClassPoolSet type)
- Changes the bytecode form of cldc and cldc_w instructions so they emit correctly (introducing a new NarrowClassRefForm)
- Changes the bytecode form of aload0_invokevirtual_super, aload0_invokespecial_super, aload0_invokestatic_super so they emit correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5382) [classlib][pack200] Class constant
pool sort order, instruction set fixes
Posted by "Andrew Cornwall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Cornwall updated HARMONY-5382:
-------------------------------------
Attachment: patches.zip
The attached patches.zip contains a main.patch with the code changes and a test.patch with JUnit test changes.
> [classlib][pack200] Class constant pool sort order, instruction set fixes
> -------------------------------------------------------------------------
>
> Key: HARMONY-5382
> URL: https://issues.apache.org/jira/browse/HARMONY-5382
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: All pack200
> Reporter: Andrew Cornwall
> Attachments: patches.zip
>
>
> Currently, the pack200 code outputs its ClassConstantPools in an ordering inconsistent with that of the spec. This patch does three things:
> - fixes the sort order of ClassConstantPools so they sort in the defined order (introducing a ClassPoolSet type)
> - Changes the bytecode form of cldc and cldc_w instructions so they emit correctly (introducing a new NarrowClassRefForm)
> - Changes the bytecode form of aload0_invokevirtual_super, aload0_invokespecial_super, aload0_invokestatic_super so they emit correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5382) [classlib][pack200] Class constant
pool sort order, instruction set fixes
Posted by "Andrew Cornwall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12558752#action_12558752 ]
Andrew Cornwall commented on HARMONY-5382:
------------------------------------------
The patch was applied correctly.
> [classlib][pack200] Class constant pool sort order, instruction set fixes
> -------------------------------------------------------------------------
>
> Key: HARMONY-5382
> URL: https://issues.apache.org/jira/browse/HARMONY-5382
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: All pack200
> Reporter: Andrew Cornwall
> Assignee: Tim Ellison
> Attachments: patches.zip
>
>
> Currently, the pack200 code outputs its ClassConstantPools in an ordering inconsistent with that of the spec. This patch does three things:
> - fixes the sort order of ClassConstantPools so they sort in the defined order (introducing a ClassPoolSet type)
> - Changes the bytecode form of cldc and cldc_w instructions so they emit correctly (introducing a new NarrowClassRefForm)
> - Changes the bytecode form of aload0_invokevirtual_super, aload0_invokespecial_super, aload0_invokestatic_super so they emit correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-5382) [classlib][pack200] Class constant
pool sort order, instruction set fixes
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Ellison closed HARMONY-5382.
--------------------------------
Verified by Andrew.
> [classlib][pack200] Class constant pool sort order, instruction set fixes
> -------------------------------------------------------------------------
>
> Key: HARMONY-5382
> URL: https://issues.apache.org/jira/browse/HARMONY-5382
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: All pack200
> Reporter: Andrew Cornwall
> Assignee: Tim Ellison
> Attachments: patches.zip
>
>
> Currently, the pack200 code outputs its ClassConstantPools in an ordering inconsistent with that of the spec. This patch does three things:
> - fixes the sort order of ClassConstantPools so they sort in the defined order (introducing a ClassPoolSet type)
> - Changes the bytecode form of cldc and cldc_w instructions so they emit correctly (introducing a new NarrowClassRefForm)
> - Changes the bytecode form of aload0_invokevirtual_super, aload0_invokespecial_super, aload0_invokestatic_super so they emit correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-5382) [classlib][pack200] Class constant
pool sort order, instruction set fixes
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Ellison resolved HARMONY-5382.
----------------------------------
Resolution: Fixed
Thanks Andrew.
Patch applied to PACK200 module at repo revision r611862.
Please check it was applied as you expected.
> [classlib][pack200] Class constant pool sort order, instruction set fixes
> -------------------------------------------------------------------------
>
> Key: HARMONY-5382
> URL: https://issues.apache.org/jira/browse/HARMONY-5382
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: All pack200
> Reporter: Andrew Cornwall
> Assignee: Tim Ellison
> Attachments: patches.zip
>
>
> Currently, the pack200 code outputs its ClassConstantPools in an ordering inconsistent with that of the spec. This patch does three things:
> - fixes the sort order of ClassConstantPools so they sort in the defined order (introducing a ClassPoolSet type)
> - Changes the bytecode form of cldc and cldc_w instructions so they emit correctly (introducing a new NarrowClassRefForm)
> - Changes the bytecode form of aload0_invokevirtual_super, aload0_invokespecial_super, aload0_invokestatic_super so they emit correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-5382) [classlib][pack200] Class constant
pool sort order, instruction set fixes
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Ellison reassigned HARMONY-5382:
------------------------------------
Assignee: Tim Ellison
> [classlib][pack200] Class constant pool sort order, instruction set fixes
> -------------------------------------------------------------------------
>
> Key: HARMONY-5382
> URL: https://issues.apache.org/jira/browse/HARMONY-5382
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: All pack200
> Reporter: Andrew Cornwall
> Assignee: Tim Ellison
> Attachments: patches.zip
>
>
> Currently, the pack200 code outputs its ClassConstantPools in an ordering inconsistent with that of the spec. This patch does three things:
> - fixes the sort order of ClassConstantPools so they sort in the defined order (introducing a ClassPoolSet type)
> - Changes the bytecode form of cldc and cldc_w instructions so they emit correctly (introducing a new NarrowClassRefForm)
> - Changes the bytecode form of aload0_invokevirtual_super, aload0_invokespecial_super, aload0_invokestatic_super so they emit correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.