[GitHub] [spark] LantaoJin edited a comment on pull request #31189: [SPARK-34122][SQL] Remove duplicated branches in CaseWhen

[GitBox <gi...@apache.org>]

LantaoJin edited a comment on pull request #31189:
URL: https://github.com/apache/spark/pull/31189#issuecomment-842181880


   > Looks reasonable to me; I still don't feel totally qualified to approve it. I expect it is a cheap enough check to be a win in enough cases to justify it.
   
   @srowen  You are right, all optimization rules have a check cost. The question is how the benefit is. One of our inner case, there are many SQLs generated by visual tools instead of hand writing. So the benefit is more or less greater than its cost in that case. Could we have a configuration to enable it and its default value should be disabled.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org