You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by WeichenXu123 <gi...@git.apache.org> on 2016/09/09 14:58:19 UTC

[GitHub] zeppelin pull request #1421: [ZEPPELIN-1422][zeppelin-interpreter] fix Inter...

GitHub user WeichenXu123 opened a pull request:

    https://github.com/apache/zeppelin/pull/1421

    [ZEPPELIN-1422][zeppelin-interpreter] fix InterpreterProperty equals methods, add null check

    ### What is this PR for?
    in PR https://github.com/apache/zeppelin/pull/1382,
    there is a small bug that `InterpreterProperty.equals` do not check `null`.
    jdk lib request the `null` check otherwise it has the risk causing java collections operation throw exception.
    so I fix it.
    
    ### What type of PR is it?
    Bug Fix
    
    ### Todos
    N/A
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-1422
    
    ### How should this be tested?
    existing test.
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/WeichenXu123/zeppelin fix_InterpreterProperty.equals

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1421.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1421
    
----
commit eb8d4ee87c5f681caf8a1c9b4c03c90b71ff851f
Author: WeichenXu <we...@outlook.com>
Date:   2016-09-08T04:46:27Z

    fix_InterpreterProperty.equals

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1421: [ZEPPELIN-1422][zeppelin-interpreter] fix InterpreterP...

Posted by prabhjyotsingh <gi...@git.apache.org>.

Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/1421
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1421: [ZEPPELIN-1422][zeppelin-interpreter] fix Inter...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1421


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1421: [ZEPPELIN-1422][zeppelin-interpreter] fix InterpreterP...

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/1421
  
    LGTM and merge if there're no more discussions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---