You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2019/04/26 17:07:56 UTC
[GitHub] [incubator-gobblin] vikrambohra opened a new pull request #2622: ETL-8363 Added random key generator for reporters. Added reporters fo…
vikrambohra opened a new pull request #2622: ETL-8363 Added random key generator for reporters. Added reporters fo…
URL: https://github.com/apache/incubator-gobblin/pull/2622
…r metrics and events that do not serialize records before pushing them.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-758] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-758
### Description
- Using randomly generated keys for reporters to reduce the number of connections to Kafka
- Introduces a KeyValuePusher interface that provides a cleaner way to push key value messages to kafka.
- Default implementation of the above interface for kafka.
- New Reporters for reporting GobblinTrackingEvent and MetricReport without serializing them.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
- KafkaKeyValueMetricObjectReporterTest
- KafkaKeyValueEventObjectReporterTest
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services