You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "aryehgigi (via GitHub)" <gi...@apache.org> on 2023/09/07 11:59:59 UTC
[GitHub] [airflow] aryehgigi opened a new pull request, #34171: fix
aryehgigi opened a new pull request, #34171:
URL: https://github.com/apache/airflow/pull/34171
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #34171: fix
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #34171:
URL: https://github.com/apache/airflow/pull/34171#issuecomment-1710025081
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #34171: Fix `ComputeEngineInsertInstanceOperator` doesn't respect jinja-templated instance name when given in body argument
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #34171:
URL: https://github.com/apache/airflow/pull/34171#issuecomment-1713557268
Hmm. We usually use `@cached_property` for similar cases - which is much cleaner and more straightforward. Maybe you should also consider it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #34171: Fix `ComputeEngineInsertInstanceOperator` doesn't respect jinja-templated instance name when given in body argument
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #34171:
URL: https://github.com/apache/airflow/pull/34171#issuecomment-1713624378
That works as well and is way better. No there should be no negative side effects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #34171: Fix `ComputeEngineInsertInstanceOperator` doesn't respect jinja-templated instance name when given in body argument
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #34171:
URL: https://github.com/apache/airflow/pull/34171#issuecomment-1713855196
Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #34171: Fix for issue: ComputeEngineInsertInstanceOperator doesn't respect jinja-templated instance name when given in body argument
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #34171:
URL: https://github.com/apache/airflow/pull/34171#issuecomment-1710597202
You need to fix tests, I am afraid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] aryehgigi commented on pull request #34171: Fix for issue: ComputeEngineInsertInstanceOperator doesn't respect jinja-templated instance name when given in body argument
Posted by "aryehgigi (via GitHub)" <gi...@apache.org>.
aryehgigi commented on PR #34171:
URL: https://github.com/apache/airflow/pull/34171#issuecomment-1710865034
hey @potiuk ,
i dont mind trying to fix the tests, but i wondered what do you think of the code changes, looks right?
we can alternatively add the `resource_id` to the jinja-template list - this will resolve the problem with no other changes required - but would it cause other problems that im not aware of?
wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] aryehgigi commented on pull request #34171: Fix `ComputeEngineInsertInstanceOperator` doesn't respect jinja-templated instance name when given in body argument
Posted by "aryehgigi (via GitHub)" <gi...@apache.org>.
aryehgigi commented on PR #34171:
URL: https://github.com/apache/airflow/pull/34171#issuecomment-1712758842
added tests, and covered also other machine instantiations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] aryehgigi commented on pull request #34171: Fix `ComputeEngineInsertInstanceOperator` doesn't respect jinja-templated instance name when given in body argument
Posted by "aryehgigi (via GitHub)" <gi...@apache.org>.
aryehgigi commented on PR #34171:
URL: https://github.com/apache/airflow/pull/34171#issuecomment-1713853043
can i merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] aryehgigi commented on pull request #34171: Fix `ComputeEngineInsertInstanceOperator` doesn't respect jinja-templated instance name when given in body argument
Posted by "aryehgigi (via GitHub)" <gi...@apache.org>.
aryehgigi commented on PR #34171:
URL: https://github.com/apache/airflow/pull/34171#issuecomment-1713620560
@potiuk
mmm I dont see how would that solve anything?
to which method do you think we should add it? init? execute?
if you are looking for simpler alternatives, i suggested above that adding `resource_id` to the `template_fields` filed would solve the issue with no other change required. i was just not sure if it would have other unintended/unwanted side-effects..
wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #34171: Fix `ComputeEngineInsertInstanceOperator` doesn't respect jinja-templated instance name when given in body argument
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #34171:
URL: https://github.com/apache/airflow/pull/34171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #34171: Fix `ComputeEngineInsertInstanceOperator` doesn't respect jinja-templated instance name when given in body argument
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #34171:
URL: https://github.com/apache/airflow/pull/34171#issuecomment-1712646139
Can you add unit test to cover this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org