You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by ni...@apache.org on 2012/12/28 04:39:15 UTC
svn commit: r1426385 - /camel/trunk/components/camel-test-spring/pom.xml
Author: ningjiang
Date: Fri Dec 28 03:39:15 2012
New Revision: 1426385
URL: http://svn.apache.org/viewvc?rev=1426385&view=rev
Log:
CAMEL-5915 fixed the camel-test-spring mixed up no related classes issue
Modified:
camel/trunk/components/camel-test-spring/pom.xml
Modified: camel/trunk/components/camel-test-spring/pom.xml
URL: http://svn.apache.org/viewvc/camel/trunk/components/camel-test-spring/pom.xml?rev=1426385&r1=1426384&r2=1426385&view=diff
==============================================================================
--- camel/trunk/components/camel-test-spring/pom.xml (original)
+++ camel/trunk/components/camel-test-spring/pom.xml Fri Dec 28 03:39:15 2012
@@ -32,7 +32,7 @@
<properties>
<spring-version>${spring31-version}</spring-version>
- <camel.osgi.export.pkg>org.apache.camel.test.*</camel.osgi.export.pkg>
+ <camel.osgi.export.pkg>org.apache.camel.test.spring.*</camel.osgi.export.pkg>
</properties>
<dependencies>
Re: svn commit: r1426385 -
/camel/trunk/components/camel-test-spring/pom.xml
Posted by Willem jiang <wi...@gmail.com>.
User may run unit tests with pax-exam which could need to install the bundle of camel-test and camel-test-spring.
It will have some trouble when camel-test and camel-test-spring export the same package of org.apache.camel.test.
--
Willem Jiang
Red Hat, Inc.
FuseSource is now part of Red Hat
Web: http://www.fusesource.com | http://www.redhat.com
Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) (English)
http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
Twitter: willemjiang
Weibo: 姜宁willem
On Friday, December 28, 2012 at 6:08 PM, Claus Ibsen wrote:
> Well I think camel-test, camel-test-spring, camel-test-xxx should not
> be OSGi bundles.
> Then we dont have issue with the bundle plugin packing the JARs wrong!
>
> On Fri, Dec 28, 2012 at 11:03 AM, Claus Ibsen <claus.ibsen@gmail.com (mailto:claus.ibsen@gmail.com)> wrote:
> > Why not rever the change. The old code worked fine.
> >
> > On Fri, Dec 28, 2012 at 10:47 AM, Willem jiang <willem.jiang@gmail.com (mailto:willem.jiang@gmail.com)> wrote:
> > > It looks like we need to put the CamelSpringTestSupport and ExcludingPackageScanClassResolver to the camel-test to avoid exporting the package of org.apache.camel.test.
> > >
> > > Any suggestion ?
> > >
> > > --
> > > Willem Jiang
> > >
> > > Red Hat, Inc.
> > > FuseSource is now part of Red Hat
> > > Web: http://www.fusesource.com | http://www.redhat.com
> > > Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) (English)
> > > http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
> > > Twitter: willemjiang
> > > Weibo: 姜宁willem
> > >
> > >
> > >
> > > On Friday, December 28, 2012 at 4:50 PM, Willem jiang wrote:
> > >
> > > > Hi Claus,
> > > >
> > > > Thanks for pointing that out. I will commit the fix shortly.
> > > >
> > > > --
> > > > Willem Jiang
> > > >
> > > > Red Hat, Inc.
> > > > FuseSource is now part of Red Hat
> > > > Web: http://www.fusesource.com | http://www.redhat.com
> > > > Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) (English)
> > > > http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
> > > > Twitter: willemjiang
> > > > Weibo: 姜宁willem
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > On Friday, December 28, 2012 at 4:38 PM, Claus Ibsen wrote:
> > > >
> > > > > Hi
> > > > >
> > > > > I think something broke camel-testng (eg TestNG). This morning I get
> > > > > this compilation error with latest code
> > > > >
> > > > > [INFO] ------------------------------------------------------------------------
> > > > > [INFO] BUILD FAILURE
> > > > > [INFO] ------------------------------------------------------------------------
> > > > > [INFO] Total time: 3:23.882s
> > > > > [INFO] Finished at: Fri Dec 28 09:38:26 CET 2012
> > > > > [INFO] Final Memory: 129M/370M
> > > > > [INFO] ------------------------------------------------------------------------
> > > > > [ERROR] Failed to execute goal
> > > > > org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile
> > > > > (default-compile) on project camel-testng: Compilation failure:
> > > > > Compilation failure:
> > > > > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[26,28]
> > > > > cannot find symbol
> > > > > [ERROR] symbol : class ExcludingPackageScanClassResolver
> > > > > [ERROR] location: package org.apache.camel.test
> > > > > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[126,97]
> > > > > cannot find symbol
> > > > > [ERROR] symbol : class ExcludingPackageScanClassResolver
> > > > > [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
> > > > > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[129,8]
> > > > > cannot find symbol
> > > > > [ERROR] symbol : class ExcludingPackageScanClassResolver
> > > > > [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
> > > > > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[129,113]
> > > > > cannot find symbol
> > > > > [ERROR] symbol : class ExcludingPackageScanClassResolver
> > > > > [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
> > > > > [ERROR] -> [Help 1]
> > > > > [ERROR]
> > > > > [ERROR] To see the full stack trace of the errors, re-run Maven with
> > > > > the -e switch.
> > > > > [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> > > > > [ERROR]
> > > > > [ERROR] For more information about the errors and possible solutions,
> > > > > please read the following articles:
> > > > > [ERROR] [Help 1]
> > > > > http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> > > > > [ERROR]
> > > > > [ERROR] After correcting the problems, you can resume the build with the command
> > > > > [ERROR] mvn <goals> -rf :camel-testng
> > > > >
> > > > >
> > > > > On Fri, Dec 28, 2012 at 4:39 AM, <ningjiang@apache.org (mailto:ningjiang@apache.org)> wrote:
> > > > > > Author: ningjiang
> > > > > > Date: Fri Dec 28 03:39:15 2012
> > > > > > New Revision: 1426385
> > > > > >
> > > > > > URL: http://svn.apache.org/viewvc?rev=1426385&view=rev
> > > > > > Log:
> > > > > > CAMEL-5915 fixed the camel-test-spring mixed up no related classes issue
> > > > > >
> > > > > > Modified:
> > > > > > camel/trunk/components/camel-test-spring/pom.xml
> > > > > >
> > > > > > Modified: camel/trunk/components/camel-test-spring/pom.xml
> > > > > > URL: http://svn.apache.org/viewvc/camel/trunk/components/camel-test-spring/pom.xml?rev=1426385&r1=1426384&r2=1426385&view=diff
> > > > > > ==============================================================================
> > > > > > --- camel/trunk/components/camel-test-spring/pom.xml (original)
> > > > > > +++ camel/trunk/components/camel-test-spring/pom.xml Fri Dec 28 03:39:15 2012
> > > > > > @@ -32,7 +32,7 @@
> > > > > >
> > > > > > <properties>
> > > > > > <spring-version>${spring31-version}</spring-version>
> > > > > > - <camel.osgi.export.pkg>org.apache.camel.test.*</camel.osgi.export.pkg>
> > > > > > + <camel.osgi.export.pkg>org.apache.camel.test.spring.*</camel.osgi.export.pkg>
> > > > > > </properties>
> > > > > >
> > > > > > <dependencies>
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Claus Ibsen
> > > > > -----------------
> > > > > Red Hat, Inc.
> > > > > FuseSource is now part of Red Hat
> > > > > Email: cibsen@redhat.com (mailto:cibsen@redhat.com)
> > > > > Web: http://fusesource.com
> > > > > Twitter: davsclaus
> > > > > Blog: http://davsclaus.com
> > > > > Author of Camel in Action: http://www.manning.com/ibsen
> > > >
> > >
> >
> >
> >
> >
> >
> > --
> > Claus Ibsen
> > -----------------
> > Red Hat, Inc.
> > FuseSource is now part of Red Hat
> > Email: cibsen@redhat.com (mailto:cibsen@redhat.com)
> > Web: http://fusesource.com
> > Twitter: davsclaus
> > Blog: http://davsclaus.com
> > Author of Camel in Action: http://www.manning.com/ibsen
>
>
>
>
>
> --
> Claus Ibsen
> -----------------
> Red Hat, Inc.
> FuseSource is now part of Red Hat
> Email: cibsen@redhat.com (mailto:cibsen@redhat.com)
> Web: http://fusesource.com
> Twitter: davsclaus
> Blog: http://davsclaus.com
> Author of Camel in Action: http://www.manning.com/ibsen
Re: svn commit: r1426385 - /camel/trunk/components/camel-test-spring/pom.xml
Posted by Claus Ibsen <cl...@gmail.com>.
Well I think camel-test, camel-test-spring, camel-test-xxx should not
be OSGi bundles.
Then we dont have issue with the bundle plugin packing the JARs wrong!
On Fri, Dec 28, 2012 at 11:03 AM, Claus Ibsen <cl...@gmail.com> wrote:
> Why not rever the change. The old code worked fine.
>
> On Fri, Dec 28, 2012 at 10:47 AM, Willem jiang <wi...@gmail.com> wrote:
>> It looks like we need to put the CamelSpringTestSupport and ExcludingPackageScanClassResolver to the camel-test to avoid exporting the package of org.apache.camel.test.
>>
>> Any suggestion ?
>>
>> --
>> Willem Jiang
>>
>> Red Hat, Inc.
>> FuseSource is now part of Red Hat
>> Web: http://www.fusesource.com | http://www.redhat.com
>> Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) (English)
>> http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
>> Twitter: willemjiang
>> Weibo: 姜宁willem
>>
>>
>>
>> On Friday, December 28, 2012 at 4:50 PM, Willem jiang wrote:
>>
>>> Hi Claus,
>>>
>>> Thanks for pointing that out. I will commit the fix shortly.
>>>
>>> --
>>> Willem Jiang
>>>
>>> Red Hat, Inc.
>>> FuseSource is now part of Red Hat
>>> Web: http://www.fusesource.com | http://www.redhat.com
>>> Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) (English)
>>> http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
>>> Twitter: willemjiang
>>> Weibo: 姜宁willem
>>>
>>>
>>>
>>>
>>>
>>> On Friday, December 28, 2012 at 4:38 PM, Claus Ibsen wrote:
>>>
>>> > Hi
>>> >
>>> > I think something broke camel-testng (eg TestNG). This morning I get
>>> > this compilation error with latest code
>>> >
>>> > [INFO] ------------------------------------------------------------------------
>>> > [INFO] BUILD FAILURE
>>> > [INFO] ------------------------------------------------------------------------
>>> > [INFO] Total time: 3:23.882s
>>> > [INFO] Finished at: Fri Dec 28 09:38:26 CET 2012
>>> > [INFO] Final Memory: 129M/370M
>>> > [INFO] ------------------------------------------------------------------------
>>> > [ERROR] Failed to execute goal
>>> > org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile
>>> > (default-compile) on project camel-testng: Compilation failure:
>>> > Compilation failure:
>>> > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[26,28]
>>> > cannot find symbol
>>> > [ERROR] symbol : class ExcludingPackageScanClassResolver
>>> > [ERROR] location: package org.apache.camel.test
>>> > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[126,97]
>>> > cannot find symbol
>>> > [ERROR] symbol : class ExcludingPackageScanClassResolver
>>> > [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
>>> > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[129,8]
>>> > cannot find symbol
>>> > [ERROR] symbol : class ExcludingPackageScanClassResolver
>>> > [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
>>> > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[129,113]
>>> > cannot find symbol
>>> > [ERROR] symbol : class ExcludingPackageScanClassResolver
>>> > [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
>>> > [ERROR] -> [Help 1]
>>> > [ERROR]
>>> > [ERROR] To see the full stack trace of the errors, re-run Maven with
>>> > the -e switch.
>>> > [ERROR] Re-run Maven using the -X switch to enable full debug logging.
>>> > [ERROR]
>>> > [ERROR] For more information about the errors and possible solutions,
>>> > please read the following articles:
>>> > [ERROR] [Help 1]
>>> > http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
>>> > [ERROR]
>>> > [ERROR] After correcting the problems, you can resume the build with the command
>>> > [ERROR] mvn <goals> -rf :camel-testng
>>> >
>>> >
>>> > On Fri, Dec 28, 2012 at 4:39 AM, <ningjiang@apache.org (mailto:ningjiang@apache.org)> wrote:
>>> > > Author: ningjiang
>>> > > Date: Fri Dec 28 03:39:15 2012
>>> > > New Revision: 1426385
>>> > >
>>> > > URL: http://svn.apache.org/viewvc?rev=1426385&view=rev
>>> > > Log:
>>> > > CAMEL-5915 fixed the camel-test-spring mixed up no related classes issue
>>> > >
>>> > > Modified:
>>> > > camel/trunk/components/camel-test-spring/pom.xml
>>> > >
>>> > > Modified: camel/trunk/components/camel-test-spring/pom.xml
>>> > > URL: http://svn.apache.org/viewvc/camel/trunk/components/camel-test-spring/pom.xml?rev=1426385&r1=1426384&r2=1426385&view=diff
>>> > > ==============================================================================
>>> > > --- camel/trunk/components/camel-test-spring/pom.xml (original)
>>> > > +++ camel/trunk/components/camel-test-spring/pom.xml Fri Dec 28 03:39:15 2012
>>> > > @@ -32,7 +32,7 @@
>>> > >
>>> > > <properties>
>>> > > <spring-version>${spring31-version}</spring-version>
>>> > > - <camel.osgi.export.pkg>org.apache.camel.test.*</camel.osgi.export.pkg>
>>> > > + <camel.osgi.export.pkg>org.apache.camel.test.spring.*</camel.osgi.export.pkg>
>>> > > </properties>
>>> > >
>>> > > <dependencies>
>>> >
>>> >
>>> >
>>> >
>>> > --
>>> > Claus Ibsen
>>> > -----------------
>>> > Red Hat, Inc.
>>> > FuseSource is now part of Red Hat
>>> > Email: cibsen@redhat.com (mailto:cibsen@redhat.com)
>>> > Web: http://fusesource.com
>>> > Twitter: davsclaus
>>> > Blog: http://davsclaus.com
>>> > Author of Camel in Action: http://www.manning.com/ibsen
>>>
>>
>>
>>
>
>
>
> --
> Claus Ibsen
> -----------------
> Red Hat, Inc.
> FuseSource is now part of Red Hat
> Email: cibsen@redhat.com
> Web: http://fusesource.com
> Twitter: davsclaus
> Blog: http://davsclaus.com
> Author of Camel in Action: http://www.manning.com/ibsen
--
Claus Ibsen
-----------------
Red Hat, Inc.
FuseSource is now part of Red Hat
Email: cibsen@redhat.com
Web: http://fusesource.com
Twitter: davsclaus
Blog: http://davsclaus.com
Author of Camel in Action: http://www.manning.com/ibsen
Re: svn commit: r1426385 - /camel/trunk/components/camel-test-spring/pom.xml
Posted by Claus Ibsen <cl...@gmail.com>.
Why not rever the change. The old code worked fine.
On Fri, Dec 28, 2012 at 10:47 AM, Willem jiang <wi...@gmail.com> wrote:
> It looks like we need to put the CamelSpringTestSupport and ExcludingPackageScanClassResolver to the camel-test to avoid exporting the package of org.apache.camel.test.
>
> Any suggestion ?
>
> --
> Willem Jiang
>
> Red Hat, Inc.
> FuseSource is now part of Red Hat
> Web: http://www.fusesource.com | http://www.redhat.com
> Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) (English)
> http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
> Twitter: willemjiang
> Weibo: 姜宁willem
>
>
>
> On Friday, December 28, 2012 at 4:50 PM, Willem jiang wrote:
>
>> Hi Claus,
>>
>> Thanks for pointing that out. I will commit the fix shortly.
>>
>> --
>> Willem Jiang
>>
>> Red Hat, Inc.
>> FuseSource is now part of Red Hat
>> Web: http://www.fusesource.com | http://www.redhat.com
>> Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) (English)
>> http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
>> Twitter: willemjiang
>> Weibo: 姜宁willem
>>
>>
>>
>>
>>
>> On Friday, December 28, 2012 at 4:38 PM, Claus Ibsen wrote:
>>
>> > Hi
>> >
>> > I think something broke camel-testng (eg TestNG). This morning I get
>> > this compilation error with latest code
>> >
>> > [INFO] ------------------------------------------------------------------------
>> > [INFO] BUILD FAILURE
>> > [INFO] ------------------------------------------------------------------------
>> > [INFO] Total time: 3:23.882s
>> > [INFO] Finished at: Fri Dec 28 09:38:26 CET 2012
>> > [INFO] Final Memory: 129M/370M
>> > [INFO] ------------------------------------------------------------------------
>> > [ERROR] Failed to execute goal
>> > org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile
>> > (default-compile) on project camel-testng: Compilation failure:
>> > Compilation failure:
>> > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[26,28]
>> > cannot find symbol
>> > [ERROR] symbol : class ExcludingPackageScanClassResolver
>> > [ERROR] location: package org.apache.camel.test
>> > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[126,97]
>> > cannot find symbol
>> > [ERROR] symbol : class ExcludingPackageScanClassResolver
>> > [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
>> > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[129,8]
>> > cannot find symbol
>> > [ERROR] symbol : class ExcludingPackageScanClassResolver
>> > [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
>> > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[129,113]
>> > cannot find symbol
>> > [ERROR] symbol : class ExcludingPackageScanClassResolver
>> > [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
>> > [ERROR] -> [Help 1]
>> > [ERROR]
>> > [ERROR] To see the full stack trace of the errors, re-run Maven with
>> > the -e switch.
>> > [ERROR] Re-run Maven using the -X switch to enable full debug logging.
>> > [ERROR]
>> > [ERROR] For more information about the errors and possible solutions,
>> > please read the following articles:
>> > [ERROR] [Help 1]
>> > http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
>> > [ERROR]
>> > [ERROR] After correcting the problems, you can resume the build with the command
>> > [ERROR] mvn <goals> -rf :camel-testng
>> >
>> >
>> > On Fri, Dec 28, 2012 at 4:39 AM, <ningjiang@apache.org (mailto:ningjiang@apache.org)> wrote:
>> > > Author: ningjiang
>> > > Date: Fri Dec 28 03:39:15 2012
>> > > New Revision: 1426385
>> > >
>> > > URL: http://svn.apache.org/viewvc?rev=1426385&view=rev
>> > > Log:
>> > > CAMEL-5915 fixed the camel-test-spring mixed up no related classes issue
>> > >
>> > > Modified:
>> > > camel/trunk/components/camel-test-spring/pom.xml
>> > >
>> > > Modified: camel/trunk/components/camel-test-spring/pom.xml
>> > > URL: http://svn.apache.org/viewvc/camel/trunk/components/camel-test-spring/pom.xml?rev=1426385&r1=1426384&r2=1426385&view=diff
>> > > ==============================================================================
>> > > --- camel/trunk/components/camel-test-spring/pom.xml (original)
>> > > +++ camel/trunk/components/camel-test-spring/pom.xml Fri Dec 28 03:39:15 2012
>> > > @@ -32,7 +32,7 @@
>> > >
>> > > <properties>
>> > > <spring-version>${spring31-version}</spring-version>
>> > > - <camel.osgi.export.pkg>org.apache.camel.test.*</camel.osgi.export.pkg>
>> > > + <camel.osgi.export.pkg>org.apache.camel.test.spring.*</camel.osgi.export.pkg>
>> > > </properties>
>> > >
>> > > <dependencies>
>> >
>> >
>> >
>> >
>> > --
>> > Claus Ibsen
>> > -----------------
>> > Red Hat, Inc.
>> > FuseSource is now part of Red Hat
>> > Email: cibsen@redhat.com (mailto:cibsen@redhat.com)
>> > Web: http://fusesource.com
>> > Twitter: davsclaus
>> > Blog: http://davsclaus.com
>> > Author of Camel in Action: http://www.manning.com/ibsen
>>
>
>
>
--
Claus Ibsen
-----------------
Red Hat, Inc.
FuseSource is now part of Red Hat
Email: cibsen@redhat.com
Web: http://fusesource.com
Twitter: davsclaus
Blog: http://davsclaus.com
Author of Camel in Action: http://www.manning.com/ibsen
Re: svn commit: r1426385 -
/camel/trunk/components/camel-test-spring/pom.xml
Posted by Willem jiang <wi...@gmail.com>.
OK, I'd like to revert the change and add some note on the camel release.
Even camel-test-spring has the classes from camel-test, it has no negative effect, we just need to let user know if he wants to use camel-test-spring in osgi, he should avoid install camel-test bundle.
--
Willem Jiang
Red Hat, Inc.
FuseSource is now part of Red Hat
Web: http://www.fusesource.com | http://www.redhat.com
Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) (English)
http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
Twitter: willemjiang
Weibo: 姜宁willem
On Friday, December 28, 2012 at 6:50 PM, Claus Ibsen wrote:
> On Fri, Dec 28, 2012 at 10:47 AM, Willem jiang <willem.jiang@gmail.com (mailto:willem.jiang@gmail.com)> wrote:
> > It looks like we need to put the CamelSpringTestSupport and ExcludingPackageScanClassResolver to the camel-test to avoid exporting the package of org.apache.camel.test.
>
>
>
> -1
>
> We cannot have spring dependency in camel-test.
> And the classes should stay in the current packages. It breaks to much
> moving stuff around.
>
>
>
> > Any suggestion ?
>
> Look at that merge-split package or what ever that osgi directive is called.
>
>
> >
> > --
> > Willem Jiang
> >
> > Red Hat, Inc.
> > FuseSource is now part of Red Hat
> > Web: http://www.fusesource.com | http://www.redhat.com
> > Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) (English)
> > http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
> > Twitter: willemjiang
> > Weibo: 姜宁willem
> >
> >
> >
> > On Friday, December 28, 2012 at 4:50 PM, Willem jiang wrote:
> >
> > > Hi Claus,
> > >
> > > Thanks for pointing that out. I will commit the fix shortly.
> > >
> > > --
> > > Willem Jiang
> > >
> > > Red Hat, Inc.
> > > FuseSource is now part of Red Hat
> > > Web: http://www.fusesource.com | http://www.redhat.com
> > > Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) (English)
> > > http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
> > > Twitter: willemjiang
> > > Weibo: 姜宁willem
> > >
> > >
> > >
> > >
> > >
> > > On Friday, December 28, 2012 at 4:38 PM, Claus Ibsen wrote:
> > >
> > > > Hi
> > > >
> > > > I think something broke camel-testng (eg TestNG). This morning I get
> > > > this compilation error with latest code
> > > >
> > > > [INFO] ------------------------------------------------------------------------
> > > > [INFO] BUILD FAILURE
> > > > [INFO] ------------------------------------------------------------------------
> > > > [INFO] Total time: 3:23.882s
> > > > [INFO] Finished at: Fri Dec 28 09:38:26 CET 2012
> > > > [INFO] Final Memory: 129M/370M
> > > > [INFO] ------------------------------------------------------------------------
> > > > [ERROR] Failed to execute goal
> > > > org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile
> > > > (default-compile) on project camel-testng: Compilation failure:
> > > > Compilation failure:
> > > > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[26,28]
> > > > cannot find symbol
> > > > [ERROR] symbol : class ExcludingPackageScanClassResolver
> > > > [ERROR] location: package org.apache.camel.test
> > > > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[126,97]
> > > > cannot find symbol
> > > > [ERROR] symbol : class ExcludingPackageScanClassResolver
> > > > [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
> > > > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[129,8]
> > > > cannot find symbol
> > > > [ERROR] symbol : class ExcludingPackageScanClassResolver
> > > > [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
> > > > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[129,113]
> > > > cannot find symbol
> > > > [ERROR] symbol : class ExcludingPackageScanClassResolver
> > > > [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
> > > > [ERROR] -> [Help 1]
> > > > [ERROR]
> > > > [ERROR] To see the full stack trace of the errors, re-run Maven with
> > > > the -e switch.
> > > > [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> > > > [ERROR]
> > > > [ERROR] For more information about the errors and possible solutions,
> > > > please read the following articles:
> > > > [ERROR] [Help 1]
> > > > http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> > > > [ERROR]
> > > > [ERROR] After correcting the problems, you can resume the build with the command
> > > > [ERROR] mvn <goals> -rf :camel-testng
> > > >
> > > >
> > > > On Fri, Dec 28, 2012 at 4:39 AM, <ningjiang@apache.org (mailto:ningjiang@apache.org)> wrote:
> > > > > Author: ningjiang
> > > > > Date: Fri Dec 28 03:39:15 2012
> > > > > New Revision: 1426385
> > > > >
> > > > > URL: http://svn.apache.org/viewvc?rev=1426385&view=rev
> > > > > Log:
> > > > > CAMEL-5915 fixed the camel-test-spring mixed up no related classes issue
> > > > >
> > > > > Modified:
> > > > > camel/trunk/components/camel-test-spring/pom.xml
> > > > >
> > > > > Modified: camel/trunk/components/camel-test-spring/pom.xml
> > > > > URL: http://svn.apache.org/viewvc/camel/trunk/components/camel-test-spring/pom.xml?rev=1426385&r1=1426384&r2=1426385&view=diff
> > > > > ==============================================================================
> > > > > --- camel/trunk/components/camel-test-spring/pom.xml (original)
> > > > > +++ camel/trunk/components/camel-test-spring/pom.xml Fri Dec 28 03:39:15 2012
> > > > > @@ -32,7 +32,7 @@
> > > > >
> > > > > <properties>
> > > > > <spring-version>${spring31-version}</spring-version>
> > > > > - <camel.osgi.export.pkg>org.apache.camel.test.*</camel.osgi.export.pkg>
> > > > > + <camel.osgi.export.pkg>org.apache.camel.test.spring.*</camel.osgi.export.pkg>
> > > > > </properties>
> > > > >
> > > > > <dependencies>
> > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Claus Ibsen
> > > > -----------------
> > > > Red Hat, Inc.
> > > > FuseSource is now part of Red Hat
> > > > Email: cibsen@redhat.com (mailto:cibsen@redhat.com)
> > > > Web: http://fusesource.com
> > > > Twitter: davsclaus
> > > > Blog: http://davsclaus.com
> > > > Author of Camel in Action: http://www.manning.com/ibsen
> > >
> >
>
>
>
>
>
> --
> Claus Ibsen
> -----------------
> Red Hat, Inc.
> FuseSource is now part of Red Hat
> Email: cibsen@redhat.com (mailto:cibsen@redhat.com)
> Web: http://fusesource.com
> Twitter: davsclaus
> Blog: http://davsclaus.com
> Author of Camel in Action: http://www.manning.com/ibsen
Re: svn commit: r1426385 - /camel/trunk/components/camel-test-spring/pom.xml
Posted by Claus Ibsen <cl...@gmail.com>.
On Fri, Dec 28, 2012 at 10:47 AM, Willem jiang <wi...@gmail.com> wrote:
> It looks like we need to put the CamelSpringTestSupport and ExcludingPackageScanClassResolver to the camel-test to avoid exporting the package of org.apache.camel.test.
>
-1
We cannot have spring dependency in camel-test.
And the classes should stay in the current packages. It breaks to much
moving stuff around.
> Any suggestion ?
Look at that merge-split package or what ever that osgi directive is called.
>
> --
> Willem Jiang
>
> Red Hat, Inc.
> FuseSource is now part of Red Hat
> Web: http://www.fusesource.com | http://www.redhat.com
> Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) (English)
> http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
> Twitter: willemjiang
> Weibo: 姜宁willem
>
>
>
> On Friday, December 28, 2012 at 4:50 PM, Willem jiang wrote:
>
>> Hi Claus,
>>
>> Thanks for pointing that out. I will commit the fix shortly.
>>
>> --
>> Willem Jiang
>>
>> Red Hat, Inc.
>> FuseSource is now part of Red Hat
>> Web: http://www.fusesource.com | http://www.redhat.com
>> Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) (English)
>> http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
>> Twitter: willemjiang
>> Weibo: 姜宁willem
>>
>>
>>
>>
>>
>> On Friday, December 28, 2012 at 4:38 PM, Claus Ibsen wrote:
>>
>> > Hi
>> >
>> > I think something broke camel-testng (eg TestNG). This morning I get
>> > this compilation error with latest code
>> >
>> > [INFO] ------------------------------------------------------------------------
>> > [INFO] BUILD FAILURE
>> > [INFO] ------------------------------------------------------------------------
>> > [INFO] Total time: 3:23.882s
>> > [INFO] Finished at: Fri Dec 28 09:38:26 CET 2012
>> > [INFO] Final Memory: 129M/370M
>> > [INFO] ------------------------------------------------------------------------
>> > [ERROR] Failed to execute goal
>> > org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile
>> > (default-compile) on project camel-testng: Compilation failure:
>> > Compilation failure:
>> > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[26,28]
>> > cannot find symbol
>> > [ERROR] symbol : class ExcludingPackageScanClassResolver
>> > [ERROR] location: package org.apache.camel.test
>> > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[126,97]
>> > cannot find symbol
>> > [ERROR] symbol : class ExcludingPackageScanClassResolver
>> > [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
>> > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[129,8]
>> > cannot find symbol
>> > [ERROR] symbol : class ExcludingPackageScanClassResolver
>> > [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
>> > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[129,113]
>> > cannot find symbol
>> > [ERROR] symbol : class ExcludingPackageScanClassResolver
>> > [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
>> > [ERROR] -> [Help 1]
>> > [ERROR]
>> > [ERROR] To see the full stack trace of the errors, re-run Maven with
>> > the -e switch.
>> > [ERROR] Re-run Maven using the -X switch to enable full debug logging.
>> > [ERROR]
>> > [ERROR] For more information about the errors and possible solutions,
>> > please read the following articles:
>> > [ERROR] [Help 1]
>> > http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
>> > [ERROR]
>> > [ERROR] After correcting the problems, you can resume the build with the command
>> > [ERROR] mvn <goals> -rf :camel-testng
>> >
>> >
>> > On Fri, Dec 28, 2012 at 4:39 AM, <ningjiang@apache.org (mailto:ningjiang@apache.org)> wrote:
>> > > Author: ningjiang
>> > > Date: Fri Dec 28 03:39:15 2012
>> > > New Revision: 1426385
>> > >
>> > > URL: http://svn.apache.org/viewvc?rev=1426385&view=rev
>> > > Log:
>> > > CAMEL-5915 fixed the camel-test-spring mixed up no related classes issue
>> > >
>> > > Modified:
>> > > camel/trunk/components/camel-test-spring/pom.xml
>> > >
>> > > Modified: camel/trunk/components/camel-test-spring/pom.xml
>> > > URL: http://svn.apache.org/viewvc/camel/trunk/components/camel-test-spring/pom.xml?rev=1426385&r1=1426384&r2=1426385&view=diff
>> > > ==============================================================================
>> > > --- camel/trunk/components/camel-test-spring/pom.xml (original)
>> > > +++ camel/trunk/components/camel-test-spring/pom.xml Fri Dec 28 03:39:15 2012
>> > > @@ -32,7 +32,7 @@
>> > >
>> > > <properties>
>> > > <spring-version>${spring31-version}</spring-version>
>> > > - <camel.osgi.export.pkg>org.apache.camel.test.*</camel.osgi.export.pkg>
>> > > + <camel.osgi.export.pkg>org.apache.camel.test.spring.*</camel.osgi.export.pkg>
>> > > </properties>
>> > >
>> > > <dependencies>
>> >
>> >
>> >
>> >
>> > --
>> > Claus Ibsen
>> > -----------------
>> > Red Hat, Inc.
>> > FuseSource is now part of Red Hat
>> > Email: cibsen@redhat.com (mailto:cibsen@redhat.com)
>> > Web: http://fusesource.com
>> > Twitter: davsclaus
>> > Blog: http://davsclaus.com
>> > Author of Camel in Action: http://www.manning.com/ibsen
>>
>
>
>
--
Claus Ibsen
-----------------
Red Hat, Inc.
FuseSource is now part of Red Hat
Email: cibsen@redhat.com
Web: http://fusesource.com
Twitter: davsclaus
Blog: http://davsclaus.com
Author of Camel in Action: http://www.manning.com/ibsen
Re: svn commit: r1426385 - /camel/trunk/components/camel-test-spring/pom.xml
Posted by Claus Ibsen <cl...@gmail.com>.
On Mon, Dec 31, 2012 at 9:52 AM, Willem jiang <wi...@gmail.com> wrote:
>
>
> On Saturday, December 29, 2012 at 6:38 PM, Claus Ibsen wrote:
>
>> On Fri, Dec 28, 2012 at 2:06 PM, Willem jiang <willem.jiang@gmail.com (mailto:willem.jiang@gmail.com)> wrote:
>> > The CamelSpringTestSupport is marked as @deprecated already, it will be removed in Camel 3.0.
>>
>>
>>
>> Ah yeah it has been @deprecated for a rather long time (eg junit 3.x support).
>> In light of this we could consider to
>> - remove junit 3.x support in Camel 2.11 which will "fix this". We
>> have marked junit 3.x as @deprecated for a long time now.
>
> +1.
> I think it should be safe to remove it in Camel 2.11 to fix the issue we got.
> We could add some lines on the Camel 2.11 release note.
I logged a ticket
https://issues.apache.org/jira/browse/CAMEL-5919
And also added a note to the Camel 2.10 release notes that junit 3.x
is to be removed in Camel 2.11.
>> - mark it for removal in Camel 2.12 so Camel 2.11 will be the last
>> release with junit 3.x support.
>>
>> Then its fixed sooner, than Camel 3.0.
>>
>>
>> > I think ExcludingPackageScanClassResolver can be move to camel-test as it has no other dependency of Spring.
>> >
>> >
>> > --
>> > Willem Jiang
>> >
>> > Red Hat, Inc.
>> > FuseSource is now part of Red Hat
>> > Web: http://www.fusesource.com | http://www.redhat.com
>> > Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) (English)
>> > http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
>> > Twitter: willemjiang
>> > Weibo: 姜宁willem
>> >
>> >
>> >
>> >
>> >
>> > On Friday, December 28, 2012 at 8:30 PM, Claus Ibsen wrote:
>> >
>> > > On Fri, Dec 28, 2012 at 10:47 AM, Willem jiang <willem.jiang@gmail.com (mailto:willem.jiang@gmail.com)> wrote:
>> > > > It looks like we need to put the CamelSpringTestSupport and ExcludingPackageScanClassResolver to the camel-test to avoid exporting the package of org.apache.camel.test.
>> > > >
>> > > > Any suggestion ?
>> > >
>> > > Maybe a better solution could be to
>> > >
>> > > copy these 2 classes to the spring package.
>> > > And then the let the original classes be stubs (eg extend the copied
>> > > classes), and mark these as @deprecated.
>> > > And refer ppl to use the classes from the spring package.
>> > >
>> > > Then in Camel 3.0 we can remove these 2 classes so the package is
>> > > empty in camel-test-spring.
>> > > Then we wont have any split package anymore.
>> > >
>> > > And ppl on 2.x can keep code as is. And for 3.0 they need to migrate
>> > > the code, which would be acceptable.
>> > >
>> > > >
>> > > > --
>> > > > Willem Jiang
>> > > >
>> > > > Red Hat, Inc.
>> > > > FuseSource is now part of Red Hat
>> > > > Web: http://www.fusesource.com | http://www.redhat.com
>> > > > Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) (English)
>> > > > http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
>> > > > Twitter: willemjiang
>> > > > Weibo: 姜宁willem
>> > > >
>> > > >
>> > > >
>> > > > On Friday, December 28, 2012 at 4:50 PM, Willem jiang wrote:
>> > > >
>> > > > > Hi Claus,
>> > > > >
>> > > > > Thanks for pointing that out. I will commit the fix shortly.
>> > > > >
>> > > > > --
>> > > > > Willem Jiang
>> > > > >
>> > > > > Red Hat, Inc.
>> > > > > FuseSource is now part of Red Hat
>> > > > > Web: http://www.fusesource.com | http://www.redhat.com
>> > > > > Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) (English)
>> > > > > http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
>> > > > > Twitter: willemjiang
>> > > > > Weibo: 姜宁willem
>> > > > >
>> > > > >
>> > > > >
>> > > > >
>> > > > >
>> > > > > On Friday, December 28, 2012 at 4:38 PM, Claus Ibsen wrote:
>> > > > >
>> > > > > > Hi
>> > > > > >
>> > > > > > I think something broke camel-testng (eg TestNG). This morning I get
>> > > > > > this compilation error with latest code
>> > > > > >
>> > > > > > [INFO] ------------------------------------------------------------------------
>> > > > > > [INFO] BUILD FAILURE
>> > > > > > [INFO] ------------------------------------------------------------------------
>> > > > > > [INFO] Total time: 3:23.882s
>> > > > > > [INFO] Finished at: Fri Dec 28 09:38:26 CET 2012
>> > > > > > [INFO] Final Memory: 129M/370M
>> > > > > > [INFO] ------------------------------------------------------------------------
>> > > > > > [ERROR] Failed to execute goal
>> > > > > > org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile
>> > > > > > (default-compile) on project camel-testng: Compilation failure:
>> > > > > > Compilation failure:
>> > > > > > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[26,28]
>> > > > > > cannot find symbol
>> > > > > > [ERROR] symbol : class ExcludingPackageScanClassResolver
>> > > > > > [ERROR] location: package org.apache.camel.test
>> > > > > > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[126,97]
>> > > > > > cannot find symbol
>> > > > > > [ERROR] symbol : class ExcludingPackageScanClassResolver
>> > > > > > [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
>> > > > > > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[129,8]
>> > > > > > cannot find symbol
>> > > > > > [ERROR] symbol : class ExcludingPackageScanClassResolver
>> > > > > > [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
>> > > > > > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[129,113]
>> > > > > > cannot find symbol
>> > > > > > [ERROR] symbol : class ExcludingPackageScanClassResolver
>> > > > > > [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
>> > > > > > [ERROR] -> [Help 1]
>> > > > > > [ERROR]
>> > > > > > [ERROR] To see the full stack trace of the errors, re-run Maven with
>> > > > > > the -e switch.
>> > > > > > [ERROR] Re-run Maven using the -X switch to enable full debug logging.
>> > > > > > [ERROR]
>> > > > > > [ERROR] For more information about the errors and possible solutions,
>> > > > > > please read the following articles:
>> > > > > > [ERROR] [Help 1]
>> > > > > > http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
>> > > > > > [ERROR]
>> > > > > > [ERROR] After correcting the problems, you can resume the build with the command
>> > > > > > [ERROR] mvn <goals> -rf :camel-testng
>> > > > > >
>> > > > > >
>> > > > > > On Fri, Dec 28, 2012 at 4:39 AM, <ningjiang@apache.org (mailto:ningjiang@apache.org)> wrote:
>> > > > > > > Author: ningjiang
>> > > > > > > Date: Fri Dec 28 03:39:15 2012
>> > > > > > > New Revision: 1426385
>> > > > > > >
>> > > > > > > URL: http://svn.apache.org/viewvc?rev=1426385&view=rev
>> > > > > > > Log:
>> > > > > > > CAMEL-5915 fixed the camel-test-spring mixed up no related classes issue
>> > > > > > >
>> > > > > > > Modified:
>> > > > > > > camel/trunk/components/camel-test-spring/pom.xml
>> > > > > > >
>> > > > > > > Modified: camel/trunk/components/camel-test-spring/pom.xml
>> > > > > > > URL: http://svn.apache.org/viewvc/camel/trunk/components/camel-test-spring/pom.xml?rev=1426385&r1=1426384&r2=1426385&view=diff
>> > > > > > > ==============================================================================
>> > > > > > > --- camel/trunk/components/camel-test-spring/pom.xml (original)
>> > > > > > > +++ camel/trunk/components/camel-test-spring/pom.xml Fri Dec 28 03:39:15 2012
>> > > > > > > @@ -32,7 +32,7 @@
>> > > > > > >
>> > > > > > > <properties>
>> > > > > > > <spring-version>${spring31-version}</spring-version>
>> > > > > > > - <camel.osgi.export.pkg>org.apache.camel.test.*</camel.osgi.export.pkg>
>> > > > > > > + <camel.osgi.export.pkg>org.apache.camel.test.spring.*</camel.osgi.export.pkg>
>> > > > > > > </properties>
>> > > > > > >
>> > > > > > > <dependencies>
>> > > > > >
>> > > > > >
>> > > > > >
>> > > > > >
>> > > > > > --
>> > > > > > Claus Ibsen
>> > > > > > -----------------
>> > > > > > Red Hat, Inc.
>> > > > > > FuseSource is now part of Red Hat
>> > > > > > Email: cibsen@redhat.com (mailto:cibsen@redhat.com)
>> > > > > > Web: http://fusesource.com
>> > > > > > Twitter: davsclaus
>> > > > > > Blog: http://davsclaus.com
>> > > > > > Author of Camel in Action: http://www.manning.com/ibsen
>> > > > >
>> > > >
>> > >
>> > >
>> > >
>> > >
>> > >
>> > >
>> > >
>> > > --
>> > > Claus Ibsen
>> > > -----------------
>> > > Red Hat, Inc.
>> > > FuseSource is now part of Red Hat
>> > > Email: cibsen@redhat.com (mailto:cibsen@redhat.com)
>> > > Web: http://fusesource.com
>> > > Twitter: davsclaus
>> > > Blog: http://davsclaus.com
>> > > Author of Camel in Action: http://www.manning.com/ibsen
>> >
>>
>>
>>
>>
>>
>> --
>> Claus Ibsen
>> -----------------
>> Red Hat, Inc.
>> FuseSource is now part of Red Hat
>> Email: cibsen@redhat.com (mailto:cibsen@redhat.com)
>> Web: http://fusesource.com
>> Twitter: davsclaus
>> Blog: http://davsclaus.com
>> Author of Camel in Action: http://www.manning.com/ibsen
>
>
>
--
Claus Ibsen
-----------------
Red Hat, Inc.
FuseSource is now part of Red Hat
Email: cibsen@redhat.com
Web: http://fusesource.com
Twitter: davsclaus
Blog: http://davsclaus.com
Author of Camel in Action: http://www.manning.com/ibsen
Re: svn commit: r1426385 -
/camel/trunk/components/camel-test-spring/pom.xml
Posted by Willem jiang <wi...@gmail.com>.
On Saturday, December 29, 2012 at 6:38 PM, Claus Ibsen wrote:
> On Fri, Dec 28, 2012 at 2:06 PM, Willem jiang <willem.jiang@gmail.com (mailto:willem.jiang@gmail.com)> wrote:
> > The CamelSpringTestSupport is marked as @deprecated already, it will be removed in Camel 3.0.
>
>
>
> Ah yeah it has been @deprecated for a rather long time (eg junit 3.x support).
> In light of this we could consider to
> - remove junit 3.x support in Camel 2.11 which will "fix this". We
> have marked junit 3.x as @deprecated for a long time now.
+1.
I think it should be safe to remove it in Camel 2.11 to fix the issue we got.
We could add some lines on the Camel 2.11 release note.
> - mark it for removal in Camel 2.12 so Camel 2.11 will be the last
> release with junit 3.x support.
>
> Then its fixed sooner, than Camel 3.0.
>
>
> > I think ExcludingPackageScanClassResolver can be move to camel-test as it has no other dependency of Spring.
> >
> >
> > --
> > Willem Jiang
> >
> > Red Hat, Inc.
> > FuseSource is now part of Red Hat
> > Web: http://www.fusesource.com | http://www.redhat.com
> > Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) (English)
> > http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
> > Twitter: willemjiang
> > Weibo: 姜宁willem
> >
> >
> >
> >
> >
> > On Friday, December 28, 2012 at 8:30 PM, Claus Ibsen wrote:
> >
> > > On Fri, Dec 28, 2012 at 10:47 AM, Willem jiang <willem.jiang@gmail.com (mailto:willem.jiang@gmail.com)> wrote:
> > > > It looks like we need to put the CamelSpringTestSupport and ExcludingPackageScanClassResolver to the camel-test to avoid exporting the package of org.apache.camel.test.
> > > >
> > > > Any suggestion ?
> > >
> > > Maybe a better solution could be to
> > >
> > > copy these 2 classes to the spring package.
> > > And then the let the original classes be stubs (eg extend the copied
> > > classes), and mark these as @deprecated.
> > > And refer ppl to use the classes from the spring package.
> > >
> > > Then in Camel 3.0 we can remove these 2 classes so the package is
> > > empty in camel-test-spring.
> > > Then we wont have any split package anymore.
> > >
> > > And ppl on 2.x can keep code as is. And for 3.0 they need to migrate
> > > the code, which would be acceptable.
> > >
> > > >
> > > > --
> > > > Willem Jiang
> > > >
> > > > Red Hat, Inc.
> > > > FuseSource is now part of Red Hat
> > > > Web: http://www.fusesource.com | http://www.redhat.com
> > > > Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) (English)
> > > > http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
> > > > Twitter: willemjiang
> > > > Weibo: 姜宁willem
> > > >
> > > >
> > > >
> > > > On Friday, December 28, 2012 at 4:50 PM, Willem jiang wrote:
> > > >
> > > > > Hi Claus,
> > > > >
> > > > > Thanks for pointing that out. I will commit the fix shortly.
> > > > >
> > > > > --
> > > > > Willem Jiang
> > > > >
> > > > > Red Hat, Inc.
> > > > > FuseSource is now part of Red Hat
> > > > > Web: http://www.fusesource.com | http://www.redhat.com
> > > > > Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) (English)
> > > > > http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
> > > > > Twitter: willemjiang
> > > > > Weibo: 姜宁willem
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > On Friday, December 28, 2012 at 4:38 PM, Claus Ibsen wrote:
> > > > >
> > > > > > Hi
> > > > > >
> > > > > > I think something broke camel-testng (eg TestNG). This morning I get
> > > > > > this compilation error with latest code
> > > > > >
> > > > > > [INFO] ------------------------------------------------------------------------
> > > > > > [INFO] BUILD FAILURE
> > > > > > [INFO] ------------------------------------------------------------------------
> > > > > > [INFO] Total time: 3:23.882s
> > > > > > [INFO] Finished at: Fri Dec 28 09:38:26 CET 2012
> > > > > > [INFO] Final Memory: 129M/370M
> > > > > > [INFO] ------------------------------------------------------------------------
> > > > > > [ERROR] Failed to execute goal
> > > > > > org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile
> > > > > > (default-compile) on project camel-testng: Compilation failure:
> > > > > > Compilation failure:
> > > > > > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[26,28]
> > > > > > cannot find symbol
> > > > > > [ERROR] symbol : class ExcludingPackageScanClassResolver
> > > > > > [ERROR] location: package org.apache.camel.test
> > > > > > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[126,97]
> > > > > > cannot find symbol
> > > > > > [ERROR] symbol : class ExcludingPackageScanClassResolver
> > > > > > [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
> > > > > > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[129,8]
> > > > > > cannot find symbol
> > > > > > [ERROR] symbol : class ExcludingPackageScanClassResolver
> > > > > > [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
> > > > > > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[129,113]
> > > > > > cannot find symbol
> > > > > > [ERROR] symbol : class ExcludingPackageScanClassResolver
> > > > > > [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
> > > > > > [ERROR] -> [Help 1]
> > > > > > [ERROR]
> > > > > > [ERROR] To see the full stack trace of the errors, re-run Maven with
> > > > > > the -e switch.
> > > > > > [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> > > > > > [ERROR]
> > > > > > [ERROR] For more information about the errors and possible solutions,
> > > > > > please read the following articles:
> > > > > > [ERROR] [Help 1]
> > > > > > http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> > > > > > [ERROR]
> > > > > > [ERROR] After correcting the problems, you can resume the build with the command
> > > > > > [ERROR] mvn <goals> -rf :camel-testng
> > > > > >
> > > > > >
> > > > > > On Fri, Dec 28, 2012 at 4:39 AM, <ningjiang@apache.org (mailto:ningjiang@apache.org)> wrote:
> > > > > > > Author: ningjiang
> > > > > > > Date: Fri Dec 28 03:39:15 2012
> > > > > > > New Revision: 1426385
> > > > > > >
> > > > > > > URL: http://svn.apache.org/viewvc?rev=1426385&view=rev
> > > > > > > Log:
> > > > > > > CAMEL-5915 fixed the camel-test-spring mixed up no related classes issue
> > > > > > >
> > > > > > > Modified:
> > > > > > > camel/trunk/components/camel-test-spring/pom.xml
> > > > > > >
> > > > > > > Modified: camel/trunk/components/camel-test-spring/pom.xml
> > > > > > > URL: http://svn.apache.org/viewvc/camel/trunk/components/camel-test-spring/pom.xml?rev=1426385&r1=1426384&r2=1426385&view=diff
> > > > > > > ==============================================================================
> > > > > > > --- camel/trunk/components/camel-test-spring/pom.xml (original)
> > > > > > > +++ camel/trunk/components/camel-test-spring/pom.xml Fri Dec 28 03:39:15 2012
> > > > > > > @@ -32,7 +32,7 @@
> > > > > > >
> > > > > > > <properties>
> > > > > > > <spring-version>${spring31-version}</spring-version>
> > > > > > > - <camel.osgi.export.pkg>org.apache.camel.test.*</camel.osgi.export.pkg>
> > > > > > > + <camel.osgi.export.pkg>org.apache.camel.test.spring.*</camel.osgi.export.pkg>
> > > > > > > </properties>
> > > > > > >
> > > > > > > <dependencies>
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Claus Ibsen
> > > > > > -----------------
> > > > > > Red Hat, Inc.
> > > > > > FuseSource is now part of Red Hat
> > > > > > Email: cibsen@redhat.com (mailto:cibsen@redhat.com)
> > > > > > Web: http://fusesource.com
> > > > > > Twitter: davsclaus
> > > > > > Blog: http://davsclaus.com
> > > > > > Author of Camel in Action: http://www.manning.com/ibsen
> > > > >
> > > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > > --
> > > Claus Ibsen
> > > -----------------
> > > Red Hat, Inc.
> > > FuseSource is now part of Red Hat
> > > Email: cibsen@redhat.com (mailto:cibsen@redhat.com)
> > > Web: http://fusesource.com
> > > Twitter: davsclaus
> > > Blog: http://davsclaus.com
> > > Author of Camel in Action: http://www.manning.com/ibsen
> >
>
>
>
>
>
> --
> Claus Ibsen
> -----------------
> Red Hat, Inc.
> FuseSource is now part of Red Hat
> Email: cibsen@redhat.com (mailto:cibsen@redhat.com)
> Web: http://fusesource.com
> Twitter: davsclaus
> Blog: http://davsclaus.com
> Author of Camel in Action: http://www.manning.com/ibsen
Re: svn commit: r1426385 - /camel/trunk/components/camel-test-spring/pom.xml
Posted by Claus Ibsen <cl...@gmail.com>.
On Fri, Dec 28, 2012 at 2:06 PM, Willem jiang <wi...@gmail.com> wrote:
> The CamelSpringTestSupport is marked as @deprecated already, it will be removed in Camel 3.0.
Ah yeah it has been @deprecated for a rather long time (eg junit 3.x support).
In light of this we could consider to
- remove junit 3.x support in Camel 2.11 which will "fix this". We
have marked junit 3.x as @deprecated for a long time now.
- mark it for removal in Camel 2.12 so Camel 2.11 will be the last
release with junit 3.x support.
Then its fixed sooner, than Camel 3.0.
> I think ExcludingPackageScanClassResolver can be move to camel-test as it has no other dependency of Spring.
>
>
> --
> Willem Jiang
>
> Red Hat, Inc.
> FuseSource is now part of Red Hat
> Web: http://www.fusesource.com | http://www.redhat.com
> Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) (English)
> http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
> Twitter: willemjiang
> Weibo: 姜宁willem
>
>
>
>
>
> On Friday, December 28, 2012 at 8:30 PM, Claus Ibsen wrote:
>
>> On Fri, Dec 28, 2012 at 10:47 AM, Willem jiang <willem.jiang@gmail.com (mailto:willem.jiang@gmail.com)> wrote:
>> > It looks like we need to put the CamelSpringTestSupport and ExcludingPackageScanClassResolver to the camel-test to avoid exporting the package of org.apache.camel.test.
>> >
>> > Any suggestion ?
>>
>> Maybe a better solution could be to
>>
>> copy these 2 classes to the spring package.
>> And then the let the original classes be stubs (eg extend the copied
>> classes), and mark these as @deprecated.
>> And refer ppl to use the classes from the spring package.
>>
>> Then in Camel 3.0 we can remove these 2 classes so the package is
>> empty in camel-test-spring.
>> Then we wont have any split package anymore.
>>
>> And ppl on 2.x can keep code as is. And for 3.0 they need to migrate
>> the code, which would be acceptable.
>>
>> >
>> > --
>> > Willem Jiang
>> >
>> > Red Hat, Inc.
>> > FuseSource is now part of Red Hat
>> > Web: http://www.fusesource.com | http://www.redhat.com
>> > Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) (English)
>> > http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
>> > Twitter: willemjiang
>> > Weibo: 姜宁willem
>> >
>> >
>> >
>> > On Friday, December 28, 2012 at 4:50 PM, Willem jiang wrote:
>> >
>> > > Hi Claus,
>> > >
>> > > Thanks for pointing that out. I will commit the fix shortly.
>> > >
>> > > --
>> > > Willem Jiang
>> > >
>> > > Red Hat, Inc.
>> > > FuseSource is now part of Red Hat
>> > > Web: http://www.fusesource.com | http://www.redhat.com
>> > > Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) (English)
>> > > http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
>> > > Twitter: willemjiang
>> > > Weibo: 姜宁willem
>> > >
>> > >
>> > >
>> > >
>> > >
>> > > On Friday, December 28, 2012 at 4:38 PM, Claus Ibsen wrote:
>> > >
>> > > > Hi
>> > > >
>> > > > I think something broke camel-testng (eg TestNG). This morning I get
>> > > > this compilation error with latest code
>> > > >
>> > > > [INFO] ------------------------------------------------------------------------
>> > > > [INFO] BUILD FAILURE
>> > > > [INFO] ------------------------------------------------------------------------
>> > > > [INFO] Total time: 3:23.882s
>> > > > [INFO] Finished at: Fri Dec 28 09:38:26 CET 2012
>> > > > [INFO] Final Memory: 129M/370M
>> > > > [INFO] ------------------------------------------------------------------------
>> > > > [ERROR] Failed to execute goal
>> > > > org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile
>> > > > (default-compile) on project camel-testng: Compilation failure:
>> > > > Compilation failure:
>> > > > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[26,28]
>> > > > cannot find symbol
>> > > > [ERROR] symbol : class ExcludingPackageScanClassResolver
>> > > > [ERROR] location: package org.apache.camel.test
>> > > > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[126,97]
>> > > > cannot find symbol
>> > > > [ERROR] symbol : class ExcludingPackageScanClassResolver
>> > > > [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
>> > > > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[129,8]
>> > > > cannot find symbol
>> > > > [ERROR] symbol : class ExcludingPackageScanClassResolver
>> > > > [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
>> > > > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[129,113]
>> > > > cannot find symbol
>> > > > [ERROR] symbol : class ExcludingPackageScanClassResolver
>> > > > [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
>> > > > [ERROR] -> [Help 1]
>> > > > [ERROR]
>> > > > [ERROR] To see the full stack trace of the errors, re-run Maven with
>> > > > the -e switch.
>> > > > [ERROR] Re-run Maven using the -X switch to enable full debug logging.
>> > > > [ERROR]
>> > > > [ERROR] For more information about the errors and possible solutions,
>> > > > please read the following articles:
>> > > > [ERROR] [Help 1]
>> > > > http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
>> > > > [ERROR]
>> > > > [ERROR] After correcting the problems, you can resume the build with the command
>> > > > [ERROR] mvn <goals> -rf :camel-testng
>> > > >
>> > > >
>> > > > On Fri, Dec 28, 2012 at 4:39 AM, <ningjiang@apache.org (mailto:ningjiang@apache.org)> wrote:
>> > > > > Author: ningjiang
>> > > > > Date: Fri Dec 28 03:39:15 2012
>> > > > > New Revision: 1426385
>> > > > >
>> > > > > URL: http://svn.apache.org/viewvc?rev=1426385&view=rev
>> > > > > Log:
>> > > > > CAMEL-5915 fixed the camel-test-spring mixed up no related classes issue
>> > > > >
>> > > > > Modified:
>> > > > > camel/trunk/components/camel-test-spring/pom.xml
>> > > > >
>> > > > > Modified: camel/trunk/components/camel-test-spring/pom.xml
>> > > > > URL: http://svn.apache.org/viewvc/camel/trunk/components/camel-test-spring/pom.xml?rev=1426385&r1=1426384&r2=1426385&view=diff
>> > > > > ==============================================================================
>> > > > > --- camel/trunk/components/camel-test-spring/pom.xml (original)
>> > > > > +++ camel/trunk/components/camel-test-spring/pom.xml Fri Dec 28 03:39:15 2012
>> > > > > @@ -32,7 +32,7 @@
>> > > > >
>> > > > > <properties>
>> > > > > <spring-version>${spring31-version}</spring-version>
>> > > > > - <camel.osgi.export.pkg>org.apache.camel.test.*</camel.osgi.export.pkg>
>> > > > > + <camel.osgi.export.pkg>org.apache.camel.test.spring.*</camel.osgi.export.pkg>
>> > > > > </properties>
>> > > > >
>> > > > > <dependencies>
>> > > >
>> > > >
>> > > >
>> > > >
>> > > > --
>> > > > Claus Ibsen
>> > > > -----------------
>> > > > Red Hat, Inc.
>> > > > FuseSource is now part of Red Hat
>> > > > Email: cibsen@redhat.com (mailto:cibsen@redhat.com)
>> > > > Web: http://fusesource.com
>> > > > Twitter: davsclaus
>> > > > Blog: http://davsclaus.com
>> > > > Author of Camel in Action: http://www.manning.com/ibsen
>> > >
>> >
>>
>>
>>
>>
>>
>> --
>> Claus Ibsen
>> -----------------
>> Red Hat, Inc.
>> FuseSource is now part of Red Hat
>> Email: cibsen@redhat.com (mailto:cibsen@redhat.com)
>> Web: http://fusesource.com
>> Twitter: davsclaus
>> Blog: http://davsclaus.com
>> Author of Camel in Action: http://www.manning.com/ibsen
>
>
>
--
Claus Ibsen
-----------------
Red Hat, Inc.
FuseSource is now part of Red Hat
Email: cibsen@redhat.com
Web: http://fusesource.com
Twitter: davsclaus
Blog: http://davsclaus.com
Author of Camel in Action: http://www.manning.com/ibsen
Re: svn commit: r1426385 - /camel/trunk/components/camel-test-spring/pom.xml
Posted by Claus Ibsen <cl...@gmail.com>.
On Fri, Dec 28, 2012 at 2:06 PM, Willem jiang <wi...@gmail.com> wrote:
> The CamelSpringTestSupport is marked as @deprecated already, it will be removed in Camel 3.0.
Okay so we have already prepared for that.
> I think ExcludingPackageScanClassResolver can be move to camel-test as it has no other dependency of Spring.
Yeah then thats fine +1
>
>
> --
> Willem Jiang
>
> Red Hat, Inc.
> FuseSource is now part of Red Hat
> Web: http://www.fusesource.com | http://www.redhat.com
> Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) (English)
> http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
> Twitter: willemjiang
> Weibo: 姜宁willem
>
>
>
>
>
> On Friday, December 28, 2012 at 8:30 PM, Claus Ibsen wrote:
>
>> On Fri, Dec 28, 2012 at 10:47 AM, Willem jiang <willem.jiang@gmail.com (mailto:willem.jiang@gmail.com)> wrote:
>> > It looks like we need to put the CamelSpringTestSupport and ExcludingPackageScanClassResolver to the camel-test to avoid exporting the package of org.apache.camel.test.
>> >
>> > Any suggestion ?
>>
>> Maybe a better solution could be to
>>
>> copy these 2 classes to the spring package.
>> And then the let the original classes be stubs (eg extend the copied
>> classes), and mark these as @deprecated.
>> And refer ppl to use the classes from the spring package.
>>
>> Then in Camel 3.0 we can remove these 2 classes so the package is
>> empty in camel-test-spring.
>> Then we wont have any split package anymore.
>>
>> And ppl on 2.x can keep code as is. And for 3.0 they need to migrate
>> the code, which would be acceptable.
>>
>> >
>> > --
>> > Willem Jiang
>> >
>> > Red Hat, Inc.
>> > FuseSource is now part of Red Hat
>> > Web: http://www.fusesource.com | http://www.redhat.com
>> > Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) (English)
>> > http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
>> > Twitter: willemjiang
>> > Weibo: 姜宁willem
>> >
>> >
>> >
>> > On Friday, December 28, 2012 at 4:50 PM, Willem jiang wrote:
>> >
>> > > Hi Claus,
>> > >
>> > > Thanks for pointing that out. I will commit the fix shortly.
>> > >
>> > > --
>> > > Willem Jiang
>> > >
>> > > Red Hat, Inc.
>> > > FuseSource is now part of Red Hat
>> > > Web: http://www.fusesource.com | http://www.redhat.com
>> > > Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) (English)
>> > > http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
>> > > Twitter: willemjiang
>> > > Weibo: 姜宁willem
>> > >
>> > >
>> > >
>> > >
>> > >
>> > > On Friday, December 28, 2012 at 4:38 PM, Claus Ibsen wrote:
>> > >
>> > > > Hi
>> > > >
>> > > > I think something broke camel-testng (eg TestNG). This morning I get
>> > > > this compilation error with latest code
>> > > >
>> > > > [INFO] ------------------------------------------------------------------------
>> > > > [INFO] BUILD FAILURE
>> > > > [INFO] ------------------------------------------------------------------------
>> > > > [INFO] Total time: 3:23.882s
>> > > > [INFO] Finished at: Fri Dec 28 09:38:26 CET 2012
>> > > > [INFO] Final Memory: 129M/370M
>> > > > [INFO] ------------------------------------------------------------------------
>> > > > [ERROR] Failed to execute goal
>> > > > org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile
>> > > > (default-compile) on project camel-testng: Compilation failure:
>> > > > Compilation failure:
>> > > > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[26,28]
>> > > > cannot find symbol
>> > > > [ERROR] symbol : class ExcludingPackageScanClassResolver
>> > > > [ERROR] location: package org.apache.camel.test
>> > > > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[126,97]
>> > > > cannot find symbol
>> > > > [ERROR] symbol : class ExcludingPackageScanClassResolver
>> > > > [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
>> > > > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[129,8]
>> > > > cannot find symbol
>> > > > [ERROR] symbol : class ExcludingPackageScanClassResolver
>> > > > [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
>> > > > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[129,113]
>> > > > cannot find symbol
>> > > > [ERROR] symbol : class ExcludingPackageScanClassResolver
>> > > > [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
>> > > > [ERROR] -> [Help 1]
>> > > > [ERROR]
>> > > > [ERROR] To see the full stack trace of the errors, re-run Maven with
>> > > > the -e switch.
>> > > > [ERROR] Re-run Maven using the -X switch to enable full debug logging.
>> > > > [ERROR]
>> > > > [ERROR] For more information about the errors and possible solutions,
>> > > > please read the following articles:
>> > > > [ERROR] [Help 1]
>> > > > http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
>> > > > [ERROR]
>> > > > [ERROR] After correcting the problems, you can resume the build with the command
>> > > > [ERROR] mvn <goals> -rf :camel-testng
>> > > >
>> > > >
>> > > > On Fri, Dec 28, 2012 at 4:39 AM, <ningjiang@apache.org (mailto:ningjiang@apache.org)> wrote:
>> > > > > Author: ningjiang
>> > > > > Date: Fri Dec 28 03:39:15 2012
>> > > > > New Revision: 1426385
>> > > > >
>> > > > > URL: http://svn.apache.org/viewvc?rev=1426385&view=rev
>> > > > > Log:
>> > > > > CAMEL-5915 fixed the camel-test-spring mixed up no related classes issue
>> > > > >
>> > > > > Modified:
>> > > > > camel/trunk/components/camel-test-spring/pom.xml
>> > > > >
>> > > > > Modified: camel/trunk/components/camel-test-spring/pom.xml
>> > > > > URL: http://svn.apache.org/viewvc/camel/trunk/components/camel-test-spring/pom.xml?rev=1426385&r1=1426384&r2=1426385&view=diff
>> > > > > ==============================================================================
>> > > > > --- camel/trunk/components/camel-test-spring/pom.xml (original)
>> > > > > +++ camel/trunk/components/camel-test-spring/pom.xml Fri Dec 28 03:39:15 2012
>> > > > > @@ -32,7 +32,7 @@
>> > > > >
>> > > > > <properties>
>> > > > > <spring-version>${spring31-version}</spring-version>
>> > > > > - <camel.osgi.export.pkg>org.apache.camel.test.*</camel.osgi.export.pkg>
>> > > > > + <camel.osgi.export.pkg>org.apache.camel.test.spring.*</camel.osgi.export.pkg>
>> > > > > </properties>
>> > > > >
>> > > > > <dependencies>
>> > > >
>> > > >
>> > > >
>> > > >
>> > > > --
>> > > > Claus Ibsen
>> > > > -----------------
>> > > > Red Hat, Inc.
>> > > > FuseSource is now part of Red Hat
>> > > > Email: cibsen@redhat.com (mailto:cibsen@redhat.com)
>> > > > Web: http://fusesource.com
>> > > > Twitter: davsclaus
>> > > > Blog: http://davsclaus.com
>> > > > Author of Camel in Action: http://www.manning.com/ibsen
>> > >
>> >
>>
>>
>>
>>
>>
>> --
>> Claus Ibsen
>> -----------------
>> Red Hat, Inc.
>> FuseSource is now part of Red Hat
>> Email: cibsen@redhat.com (mailto:cibsen@redhat.com)
>> Web: http://fusesource.com
>> Twitter: davsclaus
>> Blog: http://davsclaus.com
>> Author of Camel in Action: http://www.manning.com/ibsen
>
>
>
--
Claus Ibsen
-----------------
Red Hat, Inc.
FuseSource is now part of Red Hat
Email: cibsen@redhat.com
Web: http://fusesource.com
Twitter: davsclaus
Blog: http://davsclaus.com
Author of Camel in Action: http://www.manning.com/ibsen
Re: svn commit: r1426385 -
/camel/trunk/components/camel-test-spring/pom.xml
Posted by Willem jiang <wi...@gmail.com>.
The CamelSpringTestSupport is marked as @deprecated already, it will be removed in Camel 3.0.
I think ExcludingPackageScanClassResolver can be move to camel-test as it has no other dependency of Spring.
--
Willem Jiang
Red Hat, Inc.
FuseSource is now part of Red Hat
Web: http://www.fusesource.com | http://www.redhat.com
Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) (English)
http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
Twitter: willemjiang
Weibo: 姜宁willem
On Friday, December 28, 2012 at 8:30 PM, Claus Ibsen wrote:
> On Fri, Dec 28, 2012 at 10:47 AM, Willem jiang <willem.jiang@gmail.com (mailto:willem.jiang@gmail.com)> wrote:
> > It looks like we need to put the CamelSpringTestSupport and ExcludingPackageScanClassResolver to the camel-test to avoid exporting the package of org.apache.camel.test.
> >
> > Any suggestion ?
>
> Maybe a better solution could be to
>
> copy these 2 classes to the spring package.
> And then the let the original classes be stubs (eg extend the copied
> classes), and mark these as @deprecated.
> And refer ppl to use the classes from the spring package.
>
> Then in Camel 3.0 we can remove these 2 classes so the package is
> empty in camel-test-spring.
> Then we wont have any split package anymore.
>
> And ppl on 2.x can keep code as is. And for 3.0 they need to migrate
> the code, which would be acceptable.
>
> >
> > --
> > Willem Jiang
> >
> > Red Hat, Inc.
> > FuseSource is now part of Red Hat
> > Web: http://www.fusesource.com | http://www.redhat.com
> > Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) (English)
> > http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
> > Twitter: willemjiang
> > Weibo: 姜宁willem
> >
> >
> >
> > On Friday, December 28, 2012 at 4:50 PM, Willem jiang wrote:
> >
> > > Hi Claus,
> > >
> > > Thanks for pointing that out. I will commit the fix shortly.
> > >
> > > --
> > > Willem Jiang
> > >
> > > Red Hat, Inc.
> > > FuseSource is now part of Red Hat
> > > Web: http://www.fusesource.com | http://www.redhat.com
> > > Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) (English)
> > > http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
> > > Twitter: willemjiang
> > > Weibo: 姜宁willem
> > >
> > >
> > >
> > >
> > >
> > > On Friday, December 28, 2012 at 4:38 PM, Claus Ibsen wrote:
> > >
> > > > Hi
> > > >
> > > > I think something broke camel-testng (eg TestNG). This morning I get
> > > > this compilation error with latest code
> > > >
> > > > [INFO] ------------------------------------------------------------------------
> > > > [INFO] BUILD FAILURE
> > > > [INFO] ------------------------------------------------------------------------
> > > > [INFO] Total time: 3:23.882s
> > > > [INFO] Finished at: Fri Dec 28 09:38:26 CET 2012
> > > > [INFO] Final Memory: 129M/370M
> > > > [INFO] ------------------------------------------------------------------------
> > > > [ERROR] Failed to execute goal
> > > > org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile
> > > > (default-compile) on project camel-testng: Compilation failure:
> > > > Compilation failure:
> > > > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[26,28]
> > > > cannot find symbol
> > > > [ERROR] symbol : class ExcludingPackageScanClassResolver
> > > > [ERROR] location: package org.apache.camel.test
> > > > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[126,97]
> > > > cannot find symbol
> > > > [ERROR] symbol : class ExcludingPackageScanClassResolver
> > > > [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
> > > > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[129,8]
> > > > cannot find symbol
> > > > [ERROR] symbol : class ExcludingPackageScanClassResolver
> > > > [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
> > > > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[129,113]
> > > > cannot find symbol
> > > > [ERROR] symbol : class ExcludingPackageScanClassResolver
> > > > [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
> > > > [ERROR] -> [Help 1]
> > > > [ERROR]
> > > > [ERROR] To see the full stack trace of the errors, re-run Maven with
> > > > the -e switch.
> > > > [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> > > > [ERROR]
> > > > [ERROR] For more information about the errors and possible solutions,
> > > > please read the following articles:
> > > > [ERROR] [Help 1]
> > > > http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> > > > [ERROR]
> > > > [ERROR] After correcting the problems, you can resume the build with the command
> > > > [ERROR] mvn <goals> -rf :camel-testng
> > > >
> > > >
> > > > On Fri, Dec 28, 2012 at 4:39 AM, <ningjiang@apache.org (mailto:ningjiang@apache.org)> wrote:
> > > > > Author: ningjiang
> > > > > Date: Fri Dec 28 03:39:15 2012
> > > > > New Revision: 1426385
> > > > >
> > > > > URL: http://svn.apache.org/viewvc?rev=1426385&view=rev
> > > > > Log:
> > > > > CAMEL-5915 fixed the camel-test-spring mixed up no related classes issue
> > > > >
> > > > > Modified:
> > > > > camel/trunk/components/camel-test-spring/pom.xml
> > > > >
> > > > > Modified: camel/trunk/components/camel-test-spring/pom.xml
> > > > > URL: http://svn.apache.org/viewvc/camel/trunk/components/camel-test-spring/pom.xml?rev=1426385&r1=1426384&r2=1426385&view=diff
> > > > > ==============================================================================
> > > > > --- camel/trunk/components/camel-test-spring/pom.xml (original)
> > > > > +++ camel/trunk/components/camel-test-spring/pom.xml Fri Dec 28 03:39:15 2012
> > > > > @@ -32,7 +32,7 @@
> > > > >
> > > > > <properties>
> > > > > <spring-version>${spring31-version}</spring-version>
> > > > > - <camel.osgi.export.pkg>org.apache.camel.test.*</camel.osgi.export.pkg>
> > > > > + <camel.osgi.export.pkg>org.apache.camel.test.spring.*</camel.osgi.export.pkg>
> > > > > </properties>
> > > > >
> > > > > <dependencies>
> > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Claus Ibsen
> > > > -----------------
> > > > Red Hat, Inc.
> > > > FuseSource is now part of Red Hat
> > > > Email: cibsen@redhat.com (mailto:cibsen@redhat.com)
> > > > Web: http://fusesource.com
> > > > Twitter: davsclaus
> > > > Blog: http://davsclaus.com
> > > > Author of Camel in Action: http://www.manning.com/ibsen
> > >
> >
>
>
>
>
>
> --
> Claus Ibsen
> -----------------
> Red Hat, Inc.
> FuseSource is now part of Red Hat
> Email: cibsen@redhat.com (mailto:cibsen@redhat.com)
> Web: http://fusesource.com
> Twitter: davsclaus
> Blog: http://davsclaus.com
> Author of Camel in Action: http://www.manning.com/ibsen
Re: svn commit: r1426385 - /camel/trunk/components/camel-test-spring/pom.xml
Posted by Claus Ibsen <cl...@gmail.com>.
On Fri, Dec 28, 2012 at 10:47 AM, Willem jiang <wi...@gmail.com> wrote:
> It looks like we need to put the CamelSpringTestSupport and ExcludingPackageScanClassResolver to the camel-test to avoid exporting the package of org.apache.camel.test.
>
> Any suggestion ?
Maybe a better solution could be to
copy these 2 classes to the spring package.
And then the let the original classes be stubs (eg extend the copied
classes), and mark these as @deprecated.
And refer ppl to use the classes from the spring package.
Then in Camel 3.0 we can remove these 2 classes so the package is
empty in camel-test-spring.
Then we wont have any split package anymore.
And ppl on 2.x can keep code as is. And for 3.0 they need to migrate
the code, which would be acceptable.
>
> --
> Willem Jiang
>
> Red Hat, Inc.
> FuseSource is now part of Red Hat
> Web: http://www.fusesource.com | http://www.redhat.com
> Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) (English)
> http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
> Twitter: willemjiang
> Weibo: 姜宁willem
>
>
>
> On Friday, December 28, 2012 at 4:50 PM, Willem jiang wrote:
>
>> Hi Claus,
>>
>> Thanks for pointing that out. I will commit the fix shortly.
>>
>> --
>> Willem Jiang
>>
>> Red Hat, Inc.
>> FuseSource is now part of Red Hat
>> Web: http://www.fusesource.com | http://www.redhat.com
>> Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) (English)
>> http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
>> Twitter: willemjiang
>> Weibo: 姜宁willem
>>
>>
>>
>>
>>
>> On Friday, December 28, 2012 at 4:38 PM, Claus Ibsen wrote:
>>
>> > Hi
>> >
>> > I think something broke camel-testng (eg TestNG). This morning I get
>> > this compilation error with latest code
>> >
>> > [INFO] ------------------------------------------------------------------------
>> > [INFO] BUILD FAILURE
>> > [INFO] ------------------------------------------------------------------------
>> > [INFO] Total time: 3:23.882s
>> > [INFO] Finished at: Fri Dec 28 09:38:26 CET 2012
>> > [INFO] Final Memory: 129M/370M
>> > [INFO] ------------------------------------------------------------------------
>> > [ERROR] Failed to execute goal
>> > org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile
>> > (default-compile) on project camel-testng: Compilation failure:
>> > Compilation failure:
>> > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[26,28]
>> > cannot find symbol
>> > [ERROR] symbol : class ExcludingPackageScanClassResolver
>> > [ERROR] location: package org.apache.camel.test
>> > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[126,97]
>> > cannot find symbol
>> > [ERROR] symbol : class ExcludingPackageScanClassResolver
>> > [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
>> > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[129,8]
>> > cannot find symbol
>> > [ERROR] symbol : class ExcludingPackageScanClassResolver
>> > [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
>> > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[129,113]
>> > cannot find symbol
>> > [ERROR] symbol : class ExcludingPackageScanClassResolver
>> > [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
>> > [ERROR] -> [Help 1]
>> > [ERROR]
>> > [ERROR] To see the full stack trace of the errors, re-run Maven with
>> > the -e switch.
>> > [ERROR] Re-run Maven using the -X switch to enable full debug logging.
>> > [ERROR]
>> > [ERROR] For more information about the errors and possible solutions,
>> > please read the following articles:
>> > [ERROR] [Help 1]
>> > http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
>> > [ERROR]
>> > [ERROR] After correcting the problems, you can resume the build with the command
>> > [ERROR] mvn <goals> -rf :camel-testng
>> >
>> >
>> > On Fri, Dec 28, 2012 at 4:39 AM, <ningjiang@apache.org (mailto:ningjiang@apache.org)> wrote:
>> > > Author: ningjiang
>> > > Date: Fri Dec 28 03:39:15 2012
>> > > New Revision: 1426385
>> > >
>> > > URL: http://svn.apache.org/viewvc?rev=1426385&view=rev
>> > > Log:
>> > > CAMEL-5915 fixed the camel-test-spring mixed up no related classes issue
>> > >
>> > > Modified:
>> > > camel/trunk/components/camel-test-spring/pom.xml
>> > >
>> > > Modified: camel/trunk/components/camel-test-spring/pom.xml
>> > > URL: http://svn.apache.org/viewvc/camel/trunk/components/camel-test-spring/pom.xml?rev=1426385&r1=1426384&r2=1426385&view=diff
>> > > ==============================================================================
>> > > --- camel/trunk/components/camel-test-spring/pom.xml (original)
>> > > +++ camel/trunk/components/camel-test-spring/pom.xml Fri Dec 28 03:39:15 2012
>> > > @@ -32,7 +32,7 @@
>> > >
>> > > <properties>
>> > > <spring-version>${spring31-version}</spring-version>
>> > > - <camel.osgi.export.pkg>org.apache.camel.test.*</camel.osgi.export.pkg>
>> > > + <camel.osgi.export.pkg>org.apache.camel.test.spring.*</camel.osgi.export.pkg>
>> > > </properties>
>> > >
>> > > <dependencies>
>> >
>> >
>> >
>> >
>> > --
>> > Claus Ibsen
>> > -----------------
>> > Red Hat, Inc.
>> > FuseSource is now part of Red Hat
>> > Email: cibsen@redhat.com (mailto:cibsen@redhat.com)
>> > Web: http://fusesource.com
>> > Twitter: davsclaus
>> > Blog: http://davsclaus.com
>> > Author of Camel in Action: http://www.manning.com/ibsen
>>
>
>
>
--
Claus Ibsen
-----------------
Red Hat, Inc.
FuseSource is now part of Red Hat
Email: cibsen@redhat.com
Web: http://fusesource.com
Twitter: davsclaus
Blog: http://davsclaus.com
Author of Camel in Action: http://www.manning.com/ibsen
Re: svn commit: r1426385 -
/camel/trunk/components/camel-test-spring/pom.xml
Posted by Willem jiang <wi...@gmail.com>.
It looks like we need to put the CamelSpringTestSupport and ExcludingPackageScanClassResolver to the camel-test to avoid exporting the package of org.apache.camel.test.
Any suggestion ?
--
Willem Jiang
Red Hat, Inc.
FuseSource is now part of Red Hat
Web: http://www.fusesource.com | http://www.redhat.com
Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) (English)
http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
Twitter: willemjiang
Weibo: 姜宁willem
On Friday, December 28, 2012 at 4:50 PM, Willem jiang wrote:
> Hi Claus,
>
> Thanks for pointing that out. I will commit the fix shortly.
>
> --
> Willem Jiang
>
> Red Hat, Inc.
> FuseSource is now part of Red Hat
> Web: http://www.fusesource.com | http://www.redhat.com
> Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) (English)
> http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
> Twitter: willemjiang
> Weibo: 姜宁willem
>
>
>
>
>
> On Friday, December 28, 2012 at 4:38 PM, Claus Ibsen wrote:
>
> > Hi
> >
> > I think something broke camel-testng (eg TestNG). This morning I get
> > this compilation error with latest code
> >
> > [INFO] ------------------------------------------------------------------------
> > [INFO] BUILD FAILURE
> > [INFO] ------------------------------------------------------------------------
> > [INFO] Total time: 3:23.882s
> > [INFO] Finished at: Fri Dec 28 09:38:26 CET 2012
> > [INFO] Final Memory: 129M/370M
> > [INFO] ------------------------------------------------------------------------
> > [ERROR] Failed to execute goal
> > org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile
> > (default-compile) on project camel-testng: Compilation failure:
> > Compilation failure:
> > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[26,28]
> > cannot find symbol
> > [ERROR] symbol : class ExcludingPackageScanClassResolver
> > [ERROR] location: package org.apache.camel.test
> > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[126,97]
> > cannot find symbol
> > [ERROR] symbol : class ExcludingPackageScanClassResolver
> > [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
> > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[129,8]
> > cannot find symbol
> > [ERROR] symbol : class ExcludingPackageScanClassResolver
> > [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
> > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[129,113]
> > cannot find symbol
> > [ERROR] symbol : class ExcludingPackageScanClassResolver
> > [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
> > [ERROR] -> [Help 1]
> > [ERROR]
> > [ERROR] To see the full stack trace of the errors, re-run Maven with
> > the -e switch.
> > [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> > [ERROR]
> > [ERROR] For more information about the errors and possible solutions,
> > please read the following articles:
> > [ERROR] [Help 1]
> > http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> > [ERROR]
> > [ERROR] After correcting the problems, you can resume the build with the command
> > [ERROR] mvn <goals> -rf :camel-testng
> >
> >
> > On Fri, Dec 28, 2012 at 4:39 AM, <ningjiang@apache.org (mailto:ningjiang@apache.org)> wrote:
> > > Author: ningjiang
> > > Date: Fri Dec 28 03:39:15 2012
> > > New Revision: 1426385
> > >
> > > URL: http://svn.apache.org/viewvc?rev=1426385&view=rev
> > > Log:
> > > CAMEL-5915 fixed the camel-test-spring mixed up no related classes issue
> > >
> > > Modified:
> > > camel/trunk/components/camel-test-spring/pom.xml
> > >
> > > Modified: camel/trunk/components/camel-test-spring/pom.xml
> > > URL: http://svn.apache.org/viewvc/camel/trunk/components/camel-test-spring/pom.xml?rev=1426385&r1=1426384&r2=1426385&view=diff
> > > ==============================================================================
> > > --- camel/trunk/components/camel-test-spring/pom.xml (original)
> > > +++ camel/trunk/components/camel-test-spring/pom.xml Fri Dec 28 03:39:15 2012
> > > @@ -32,7 +32,7 @@
> > >
> > > <properties>
> > > <spring-version>${spring31-version}</spring-version>
> > > - <camel.osgi.export.pkg>org.apache.camel.test.*</camel.osgi.export.pkg>
> > > + <camel.osgi.export.pkg>org.apache.camel.test.spring.*</camel.osgi.export.pkg>
> > > </properties>
> > >
> > > <dependencies>
> >
> >
> >
> >
> > --
> > Claus Ibsen
> > -----------------
> > Red Hat, Inc.
> > FuseSource is now part of Red Hat
> > Email: cibsen@redhat.com (mailto:cibsen@redhat.com)
> > Web: http://fusesource.com
> > Twitter: davsclaus
> > Blog: http://davsclaus.com
> > Author of Camel in Action: http://www.manning.com/ibsen
>
Re: svn commit: r1426385 -
/camel/trunk/components/camel-test-spring/pom.xml
Posted by Willem jiang <wi...@gmail.com>.
Hi Claus,
Thanks for pointing that out. I will commit the fix shortly.
--
Willem Jiang
Red Hat, Inc.
FuseSource is now part of Red Hat
Web: http://www.fusesource.com | http://www.redhat.com
Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) (English)
http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
Twitter: willemjiang
Weibo: 姜宁willem
On Friday, December 28, 2012 at 4:38 PM, Claus Ibsen wrote:
> Hi
>
> I think something broke camel-testng (eg TestNG). This morning I get
> this compilation error with latest code
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 3:23.882s
> [INFO] Finished at: Fri Dec 28 09:38:26 CET 2012
> [INFO] Final Memory: 129M/370M
> [INFO] ------------------------------------------------------------------------
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile
> (default-compile) on project camel-testng: Compilation failure:
> Compilation failure:
> [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[26,28]
> cannot find symbol
> [ERROR] symbol : class ExcludingPackageScanClassResolver
> [ERROR] location: package org.apache.camel.test
> [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[126,97]
> cannot find symbol
> [ERROR] symbol : class ExcludingPackageScanClassResolver
> [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
> [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[129,8]
> cannot find symbol
> [ERROR] symbol : class ExcludingPackageScanClassResolver
> [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
> [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[129,113]
> cannot find symbol
> [ERROR] symbol : class ExcludingPackageScanClassResolver
> [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
> [ERROR] -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with
> the -e switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions,
> please read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> [ERROR]
> [ERROR] After correcting the problems, you can resume the build with the command
> [ERROR] mvn <goals> -rf :camel-testng
>
>
> On Fri, Dec 28, 2012 at 4:39 AM, <ningjiang@apache.org (mailto:ningjiang@apache.org)> wrote:
> > Author: ningjiang
> > Date: Fri Dec 28 03:39:15 2012
> > New Revision: 1426385
> >
> > URL: http://svn.apache.org/viewvc?rev=1426385&view=rev
> > Log:
> > CAMEL-5915 fixed the camel-test-spring mixed up no related classes issue
> >
> > Modified:
> > camel/trunk/components/camel-test-spring/pom.xml
> >
> > Modified: camel/trunk/components/camel-test-spring/pom.xml
> > URL: http://svn.apache.org/viewvc/camel/trunk/components/camel-test-spring/pom.xml?rev=1426385&r1=1426384&r2=1426385&view=diff
> > ==============================================================================
> > --- camel/trunk/components/camel-test-spring/pom.xml (original)
> > +++ camel/trunk/components/camel-test-spring/pom.xml Fri Dec 28 03:39:15 2012
> > @@ -32,7 +32,7 @@
> >
> > <properties>
> > <spring-version>${spring31-version}</spring-version>
> > - <camel.osgi.export.pkg>org.apache.camel.test.*</camel.osgi.export.pkg>
> > + <camel.osgi.export.pkg>org.apache.camel.test.spring.*</camel.osgi.export.pkg>
> > </properties>
> >
> > <dependencies>
>
>
>
> --
> Claus Ibsen
> -----------------
> Red Hat, Inc.
> FuseSource is now part of Red Hat
> Email: cibsen@redhat.com (mailto:cibsen@redhat.com)
> Web: http://fusesource.com
> Twitter: davsclaus
> Blog: http://davsclaus.com
> Author of Camel in Action: http://www.manning.com/ibsen
Re: svn commit: r1426385 - /camel/trunk/components/camel-test-spring/pom.xml
Posted by Claus Ibsen <cl...@gmail.com>.
Hi
I think something broke camel-testng (eg TestNG). This morning I get
this compilation error with latest code
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 3:23.882s
[INFO] Finished at: Fri Dec 28 09:38:26 CET 2012
[INFO] Final Memory: 129M/370M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile
(default-compile) on project camel-testng: Compilation failure:
Compilation failure:
[ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[26,28]
cannot find symbol
[ERROR] symbol : class ExcludingPackageScanClassResolver
[ERROR] location: package org.apache.camel.test
[ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[126,97]
cannot find symbol
[ERROR] symbol : class ExcludingPackageScanClassResolver
[ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
[ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[129,8]
cannot find symbol
[ERROR] symbol : class ExcludingPackageScanClassResolver
[ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
[ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[129,113]
cannot find symbol
[ERROR] symbol : class ExcludingPackageScanClassResolver
[ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with
the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions,
please read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <goals> -rf :camel-testng
On Fri, Dec 28, 2012 at 4:39 AM, <ni...@apache.org> wrote:
> Author: ningjiang
> Date: Fri Dec 28 03:39:15 2012
> New Revision: 1426385
>
> URL: http://svn.apache.org/viewvc?rev=1426385&view=rev
> Log:
> CAMEL-5915 fixed the camel-test-spring mixed up no related classes issue
>
> Modified:
> camel/trunk/components/camel-test-spring/pom.xml
>
> Modified: camel/trunk/components/camel-test-spring/pom.xml
> URL: http://svn.apache.org/viewvc/camel/trunk/components/camel-test-spring/pom.xml?rev=1426385&r1=1426384&r2=1426385&view=diff
> ==============================================================================
> --- camel/trunk/components/camel-test-spring/pom.xml (original)
> +++ camel/trunk/components/camel-test-spring/pom.xml Fri Dec 28 03:39:15 2012
> @@ -32,7 +32,7 @@
>
> <properties>
> <spring-version>${spring31-version}</spring-version>
> - <camel.osgi.export.pkg>org.apache.camel.test.*</camel.osgi.export.pkg>
> + <camel.osgi.export.pkg>org.apache.camel.test.spring.*</camel.osgi.export.pkg>
> </properties>
>
> <dependencies>
>
>
--
Claus Ibsen
-----------------
Red Hat, Inc.
FuseSource is now part of Red Hat
Email: cibsen@redhat.com
Web: http://fusesource.com
Twitter: davsclaus
Blog: http://davsclaus.com
Author of Camel in Action: http://www.manning.com/ibsen