You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by ni...@apache.org on 2010/01/09 23:34:51 UTC
svn commit: r897570 - /httpd/httpd/trunk/modules/http/http_request.c
Author: niq
Date: Sat Jan 9 22:34:51 2010
New Revision: 897570
URL: http://svn.apache.org/viewvc?rev=897570&view=rev
Log:
We shouldn't need to create r->allowed_methods twice!
Modified:
httpd/httpd/trunk/modules/http/http_request.c
Modified: httpd/httpd/trunk/modules/http/http_request.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http/http_request.c?rev=897570&r1=897569&r2=897570&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/http/http_request.c (original)
+++ httpd/httpd/trunk/modules/http/http_request.c Sat Jan 9 22:34:51 2010
@@ -447,7 +447,6 @@
new->err_headers_out = r->err_headers_out;
new->subprocess_env = rename_original_env(r->pool, r->subprocess_env);
new->notes = apr_table_make(r->pool, 5);
- new->allowed_methods = ap_make_method_list(new->pool, 2);
new->htaccess = r->htaccess;
new->no_cache = r->no_cache;
Re: svn commit: r897570 - /httpd/httpd/trunk/modules/http/http_request.c
Posted by Ruediger Pluem <rp...@apache.org>.
On 10.01.2010 10:04, Ruediger Pluem wrote:
> On 09.01.2010 23:34, niq@apache.org wrote:
>> Author: niq
>> Date: Sat Jan 9 22:34:51 2010
>> New Revision: 897570
>>
>> URL: http://svn.apache.org/viewvc?rev=897570&view=rev
>> Log:
>> We shouldn't need to create r->allowed_methods twice!
>
> Maybe we should not create it twice, but shouldn't we
>
> new->allowed_methods = r->allowed_methods;
>
> instead?
Ok, forget about it. Your pointer in the backport proposal gave me
the correct hint.
Regards
Rüdiger
Re: svn commit: r897570 - /httpd/httpd/trunk/modules/http/http_request.c
Posted by Ruediger Pluem <rp...@apache.org>.
On 09.01.2010 23:34, niq@apache.org wrote:
> Author: niq
> Date: Sat Jan 9 22:34:51 2010
> New Revision: 897570
>
> URL: http://svn.apache.org/viewvc?rev=897570&view=rev
> Log:
> We shouldn't need to create r->allowed_methods twice!
Maybe we should not create it twice, but shouldn't we
new->allowed_methods = r->allowed_methods;
instead?
>
> Modified:
> httpd/httpd/trunk/modules/http/http_request.c
>
> Modified: httpd/httpd/trunk/modules/http/http_request.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http/http_request.c?rev=897570&r1=897569&r2=897570&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/modules/http/http_request.c (original)
> +++ httpd/httpd/trunk/modules/http/http_request.c Sat Jan 9 22:34:51 2010
> @@ -447,7 +447,6 @@
> new->err_headers_out = r->err_headers_out;
> new->subprocess_env = rename_original_env(r->pool, r->subprocess_env);
> new->notes = apr_table_make(r->pool, 5);
> - new->allowed_methods = ap_make_method_list(new->pool, 2);
>
> new->htaccess = r->htaccess;
> new->no_cache = r->no_cache;
>
>
>
Regards
Rüdiger